From nobody Wed Jan 22 10:17:58 2025 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YdKlZ2lCwz5lGMJ; Wed, 22 Jan 2025 10:18:02 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YdKlZ1v90z4N9Z; Wed, 22 Jan 2025 10:18:02 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737541082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZSx7LdePIXJ+TdW3HHfXYtym3Y1J7vJRWovhrxm/M4s=; b=cj6jWt2STIE2L+09uUWP+zvmJVYtdNCYrMkinkCJEDpYS5OMr+XT28dXqQrTMvwytuE6h4 H7lWMHhYgl/7yo0XS7ltjobiM9EZwRi0DNsE/XojOPOGOK+lxZgnTL/Hsm2ksfR53OkF4T USXuuMMwGvhV3ZyRwO7lbTQ2jm9dZ3hiQEubo1WONIEWpbkugOu4rYIZyodP6R7YOkeMIN /M5xzPTOSe8n+Ey+2WFuPMC8AU+xp3j1yt8jaWw9i7c8JiKrOH24YrDqySiHJ8FXaAL3TO iJu5Q03CNKgdiKPg6j7TZHoH6FfjkXp39dZJj1oACHEXrh3xW43Mk+G+fatOLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1737541082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZSx7LdePIXJ+TdW3HHfXYtym3Y1J7vJRWovhrxm/M4s=; b=SVwKAREdRfr7AdKRAChn724QD0+cHk0emSaCq1jwi5bF7xVINTbTt0kjS+pDn6MGDwhYKY r61zgzxU0YNj3cDeWO83hH4Q6qdsQZ4TDx/tU8UDWNBgUMGiJ8tyd+auP2kXXz0XMt2mtp 2mfIQNaPrFisHgf5kEU6jmOkD9wGnbYDt64ceHfWbLvZ3262LNlELna2+wg60GsQcWcbTD HGT9zmuOHvwqBFp/xms3EY0lBXuQqe1nYDFXyUBIey1U+0md8ndYr2zF+1CyBOWYI2RrgH eEbS4LZ776D51EabnZtAEL8yejOf1ZAmg6lWt1GzMnD0peDI5gY4MuqDuUlNOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1737541082; a=rsa-sha256; cv=none; b=gCu5ScmdxDwdAR4oh4mY5lHwQqK4d+ss+01jYi3k0AcBmsMrC8RKC7MGW9qW1XpWpTFrAd ChRQKv8QcJMudrckZJZZRlM5VclDDcJvewztMrSeEqBjx7C+BCMZrZ8iPWCT9J1plWOT+1 /7yXWFdPwTQ5i26N4mfsZi/Pl1xHpMBEq5DBxcYS0njuPKNRH9+6S+eJ1YkPOspzY3EHh6 WklOBwpwgtYbx+0Q43+eOpdveYMFOCnz9fntFRpVFY86nLib0sdoSgLSDSjAMjghZokV/A zSN9eqRWpDDOQpaoVUgX2n7ait337CJhIWdslxTDuPBxPjol3QJW0YUIJ13J1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from hal.tijl.coosemans.org (unknown [IPv6:2a02:a03f:8941:cb00:2c17:74ac:4eef:e12d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YdKlY3DW8zwV3; Wed, 22 Jan 2025 10:18:01 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Wed, 22 Jan 2025 11:17:58 +0100 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Charlie Li Cc: Vladimir Druzenko , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: e94a554e5542 - main - net/libproxy: bump consumers Message-ID: <20250122111754.3e138cdc@hal.tijl.coosemans.org> In-Reply-To: <55b9ba3e-103f-4b09-bb07-09c0b0856ef4@freebsd.org> References: <202501200502.50K52FZ0040498@gitrepo.freebsd.org> <365f4bcd-67c6-406a-ab09-c183760ee2b4@freebsd.org> <20250121102511.211135db@hal.tijl.coosemans.org> <20250121162913.042a2cce@hal.tijl.coosemans.org> <55b9ba3e-103f-4b09-bb07-09c0b0856ef4@freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 21 Jan 2025 10:34:59 -0500 Charlie Li wrote: > T=C4=B3l Coosemans wrote: >> On Tue, 21 Jan 2025 08:36:35 -0500 Charlie Li wrote: =20 >>> T=C4=B3l Coosemans wrote: =20 >>>> This error means there's something wrong with symbol versioning in >>>> libproxy. The meson output contains this line: =20 >>> >>> These patches are not necessary. The total rewrite (using glib no less) >>> introduced a subtle ABI break despite keeping the API pretty much intact >>> from before, so consumers needed rebuilding. =20 >>=20 >> The patches are needed to restore symbol versions. >>=20 >> Output of "objdump -T libproxy.so | grep text" with and without patches: >>=20 >> 0000000000001d90 g DF .text 0000000000000028 LIBPROXY_0.4.16 px_prox= y_factory_free >> 0000000000001d30 g DF .text 000000000000001b LIBPROXY_0.4.16 px_prox= y_factory_new >> 0000000000001cb0 g DF .text 0000000000000045 LIBPROXY_0.5.5 px_proxy= _factory_get_type >> 0000000000001d50 g DF .text 000000000000001a LIBPROXY_0.5.5 px_proxy= _factory_copy >> 0000000000001d70 g DF .text 0000000000000008 LIBPROXY_0.4.16 px_prox= y_factory_get_proxies >> 0000000000001d80 g DF .text 000000000000000a LIBPROXY_0.4.16 px_prox= y_factory_free_proxies >>=20 >>=20 >> 0000000000001d10 g DF .text 0000000000000028 Base px_proxy_fa= ctory_free >> 0000000000001cb0 g DF .text 000000000000001b Base px_proxy_fa= ctory_new >> 0000000000001c30 g DF .text 0000000000000045 Base px_proxy_fa= ctory_get_type >> 0000000000001cd0 g DF .text 000000000000001a Base px_proxy_fa= ctory_copy >> 0000000000001cf0 g DF .text 0000000000000008 Base px_proxy_fa= ctory_get_proxies >> 0000000000001d00 g DF .text 000000000000000a Base px_proxy_fa= ctory_free_proxies =20 > Lack of symbol versioning in the current version is correct. This is the= =20 > subtle (and intentional) ABI break I was referring to which necessitated= =20 > rebuilding every consumer hence the PORTREVISION bumps. That doesn't make much sense to me. Symbol versions are a good practice. If upstream provides them we should use them. They are disabled only because a configure test fails with clang (actually lld). That test does succeed with gcc (gnu ld). This means that a library built with gcc is not ABI compatible with the one built with clang. That's not good. So please commit or approve the patches. (There's no need to bump dependent ports again.)