Re: git: 98582ae673d8 - main - mail/opensmtpd-table-sqlite: new port

On 2025-01-19T13:31:40.000+01:00, Pietro Cerutti <gahr@FreeBSD.org>
wrote:

> The branch main has been updated by gahr:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=98582ae673d871b51f1c0b6b7cafb35879c02efc
> 
> commit 98582ae673d871b51f1c0b6b7cafb35879c02efc
> 
> Author:     Pietro Cerutti <gahr@FreeBSD.org>
> 
> AuthorDate: 2025-01-19 12:25:14 +0000
> 
> Commit:     Pietro Cerutti <gahr@FreeBSD.org>
> 
> CommitDate: 2025-01-19 12:31:27 +0000
> 
>     mail/opensmtpd-table-sqlite: new port
> 
>     
> 
>     This port replaces mail/opensmtpd-extras-table-sqlite.
> 
>     
> 
>     The opensmtpd-extras-table-* ports got broken by the latest update of
> 
>     OpenSMTPD, see my message on the mailing list:
> 
>     https://lists.freebsd.org/archives/dev-commits-ports-main/2025-January/134537.html
> 
>     
> 
>     I have requested action by fluffy@ both on the message linked above and
> 
>     privately via email, but I haven't got any response back.
> 
>     
> 
>     At this point, I want to unblock my workflow and be able to upgrade
> 
>     OpenSMTPD.  I don't have plans to provide alternatives to all the
> 
>     opensmtpd-extras-table-* ports.
> 
> ---
> 
>  mail/Makefile                         |  1 +
> 
>  mail/opensmtpd-table-sqlite/Makefile  | 26 ++++++++++++++++++++++++++
> 
>  mail/opensmtpd-table-sqlite/distinfo  |  5 +++++
> 
>  mail/opensmtpd-table-sqlite/pkg-descr |  2 ++
> 
>  4 files changed, 34 insertions(+)
> 
> diff --git a/mail/Makefile b/mail/Makefile
> 
> index 7fc7b579932a..09a72821dd5f 100644
> 
> --- a/mail/Makefile
> 
> +++ b/mail/Makefile
> 
> @@ -290,6 +290,7 @@
> 
>      SUBDIR += opensmtpd-extras-table-sqlite
> 
>      SUBDIR += opensmtpd-filter-rspamd
> 
>      SUBDIR += opensmtpd-filter-senderscore
> 
> +    SUBDIR += opensmtpd-table-sqlite
> 
>      SUBDIR += osbf-lua
> 
>      SUBDIR += ovs
> 
>      SUBDIR += p5-CGP-CLI
> 
> diff --git a/mail/opensmtpd-table-sqlite/Makefile b/mail/opensmtpd-table-sqlite/Makefile
> 
> new file mode 100644
> 
> index 000000000000..dfd64f7c1ecf
> 
> --- /dev/null
> 
> +++ b/mail/opensmtpd-table-sqlite/Makefile
> 
> @@ -0,0 +1,26 @@
> 
> +PORTNAME=    opensmtpd-table-sqlite
> 
> +DISTVERSION=    1.0.1
> 
> +CATEGORIES=    mail
> 
> +
> 
> +PATCH_SITES=    https://github.com/OpenSMTPD/table-sqlite/commit/
> 
> +PATCHFILES=    f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch:-p1
> 
> +
> 
> +MAINTAINER=    gahr@FreeBSD.org
> 
> +COMMENT=    SQLite table for OpenSMTPD
> 
> +WWW=        https://github.com/opensmtpd/table-sqlite
> 
> +
> 
> +LICENSE=    ISCL
> 
> +
> 
> +USES=        autoreconf localbase sqlite
> 
> +GNU_CONFIGURE=    yes
> 
> +
> 
> +PATCH_ARGS=    -p1
> 
> +
> 
> +USE_GITHUB=    yes
> 
> +GH_ACCOUNT=    opensmtpd
> 
> +GH_PROJECT=    table-sqlite
> 
> +
> 
> +PLIST_FILES=    libexec/smtpd/table-sqlite \
> 
> +        share/man/man5/table-sqlite.5.gz
> 
> +
> 
> +.include <bsd.port.mk> [http://bsd.port.mk>];
> 
> diff --git a/mail/opensmtpd-table-sqlite/distinfo b/mail/opensmtpd-table-sqlite/distinfo
> 
> new file mode 100644
> 
> index 000000000000..f19d8caf3cda
> 
> --- /dev/null
> 
> +++ b/mail/opensmtpd-table-sqlite/distinfo
> 
> @@ -0,0 +1,5 @@
> 
> +TIMESTAMP = 1737289442
> 
> +SHA256 (opensmtpd-table-sqlite-1.0.1_GH0.tar.gz) = 74f40788aec40087235cb82391ad21ed4aeb6d79dd7a0e89571f398825b653b0
> 
> +SIZE (opensmtpd-table-sqlite-1.0.1_GH0.tar.gz) = 21718
> 
> +SHA256 (f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch) = 0256ee0d826543e4ae4263f05c6ddedc635f72a713f34592663e4dbdd40e6d6c
> 
> +SIZE (f3c46da1cbbb2a9d32cd9b4cf31e9fdb5b941a16.patch) = 1552
> 
> diff --git a/mail/opensmtpd-table-sqlite/pkg-descr b/mail/opensmtpd-table-sqlite/pkg-descr
> 
> new file mode 100644
> 
> index 000000000000..ede5705d7728
> 
> --- /dev/null
> 
> +++ b/mail/opensmtpd-table-sqlite/pkg-descr
> 
> @@ -0,0 +1,2 @@
> 
> +The SQLite table addon for OpenSMTPD allows the storing of usernames,
> 
> +passwords, aliases, and domains in a sqlite3 table.

Hi,

Any reason why you're not using upstream's release archive?

That gets rid of patching and USES= autoreconf and you probably also
want USES= localbase:ldflags instead of localbase . Looking at Porters
Handbook you should likely also make use of PKGNAMEPREFIX instead of
having opensmtpd- in PORTNAME.

PATCH_ARGS is also unnecessary as you've set -p1 already.

Something like this works fine on my end in ports and Poudriere

https://projects.pyret.net/files/freebsd-patches/opensmtpd-table-sqlite-improve.patch

Best regards,

Daniel