Re: git: a8d366898894 - main - textproc/docproj: remove gnuplot-lite dependency
Date: Fri, 17 Jan 2025 18:38:45 UTC
> On Jan 17, 2025, at 7:11 PM, Fernando Apesteguía <fernape@freebsd.org> wrote: > > > > On Thu, Jan 16, 2025 at 1:21 PM Moin Rahman <bofh@freebsd.org> wrote: > > >> On 16 Jan 2025, at 13:02, Fernando Apesteguía <fernape@freebsd.org> wrote: >> >> >> >> On Thu, Jan 16, 2025 at 8:56 AM Moin Rahman <bofh@freebsd.org> wrote: >> >> >> > On Jan 16, 2025, at 08:41, Fernando Apesteguía <fernape@FreeBSD.org> wrote: >> > >> > The branch main has been updated by fernape: >> > >> > URL: https://cgit.FreeBSD.org/ports/commit/?id=a8d3668988945bf23844a1733da214113e08d6ec >> > >> > commit a8d3668988945bf23844a1733da214113e08d6ec >> > Author: Fernando Apesteguía <fernape@FreeBSD.org> >> > AuthorDate: 2025-01-14 17:26:26 +0000 >> > Commit: Fernando Apesteguía <fernape@FreeBSD.org> >> > CommitDate: 2025-01-16 07:41:00 +0000 >> > >> > textproc/docproj: remove gnuplot-lite dependency >> > >> > It was a leftover from the previous docproj. >> > --- >> > textproc/docproj/Makefile | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/textproc/docproj/Makefile b/textproc/docproj/Makefile >> > index 6d362be1878a..a0b3c298573c 100644 >> > --- a/textproc/docproj/Makefile >> > +++ b/textproc/docproj/Makefile >> > @@ -1,5 +1,6 @@ >> > PORTNAME= docproj >> > PORTVERSION= 4.1.9 >> > +PORTREVISION= 1 >> > CATEGORIES= textproc >> > >> > MAINTAINER= doceng@FreeBSD.org >> > @@ -7,7 +8,6 @@ COMMENT= Meta-port for the FreeBSD Documentation Project >> > WWW= https://www.freebsd.org/docproj >> > >> > RUN_DEPENDS= asciidoctor:textproc/rubygem-asciidoctor \ >> > - gnuplot-lite>0:math/gnuplot-lite \ >> > gohugo>=0.133.1,1:www/gohugo \ >> > rougify:textproc/rubygem-rouge \ >> > rubygem-asciidoctor-diagram>0:textproc/rubygem-asciidoctor-diagram >> >> I don't think this is correct. gnuplot was used to generate the graph >> of number of ports here: >> >> https://docs.freebsd.org/en/books/dev-model/#sub-project-ports >> >> Interesting. I don't see any invocations to gnuplot in any of the Makefiles. >> Also, I don't have any gnuplot* packages in my system and I regularly build the documentation just fine: >> >> $ DOC_LANG=en make >> --------------------------------------------------------------- >> Building the documentation >> included languages: en >> excluded languages: bn-bd da de el es fr hu id it ja ko mn nl pl pt-br ru tr zh-cn zh-tw >> --------------------------------------------------------------- >> /usr/local/bin/ruby ./tools/global-pgpkeys-creator.rb >> HUGO_DISABLELANGUAGES=" bn-bd da de el es fr hu id it ja ko mn nl pl pt-br ru tr zh-cn zh-tw" /usr/local/bin/hugo --minify >> Start building sites … >> hugo v0.140.2+extended freebsd/amd64 BuildDate=2024-12-30T17:44:54Z+0000 VendorInfo=freebsd >> >> >> | EN >> -------------------+------- >> Pages | 1187 >> Paginator pages | 0 >> Non-page files | 0 >> Static files | 856 >> Processed images | 0 >> Aliases | 1 >> Cleaned | 0 >> >> Total in 200805 ms >> Where is that file generated? > It’s not in a Makefile. Eventually rubygem-asciidoctor-diagram calls it to generate the diagram. Search for a file where asciidoctor-diagram is defined as a plugin. I am travelling today and will share the details at night. > > > The reason the image was not properly loaded is because the syntax was wrong in d7957d161fd when this change was introduced. > I just fixed it in 6abcb860ac: > > -.Number of ports added between 1995 and 2022 [[fig-ports]] > -image::portsstatus.svg > +.Number of ports added between 1995 and 2022 > +[[fig-ports]] > +image::portsstatus.svg[Refer to paragraphs below for a screen-reader friendly version.] > > I don't have any gnuplot packages in my system: > > $ pkg info -x '.*plot.*' > pkg: No package(s) matching .*plot.* > > and yet with that change "make run" now shows the picture in the documentation. > The CI for the documentation tree needs fixing (https://github.com/freebsd/freebsd-ci/pull/178) so the image might not show yet in docs.freebsd.org. > > The image in question is generated by https://people.freebsd.org/~bofh/dropzone/dev-model.sh, which reads at the beginning:# This script will inform the total number of committers per repo at > # the end of the run. This information should be manually updated in > # the file documentation/content/en/books/dev-model/_index.adoc > According to git log, the generated image was last updated in 2022, and I can tell you I've built the whole tree a number of times since 2022 :-) > Are you sure you uploaded it to the repo and hook it to the build? > > Cheers. > I think this was not completed then. :'( Kind regards, Moin