Re: git: 2cf6bc1add64 - main - java/openjdk*: Update pkg-message information about fdescfs and procfs

A quick grep in the source code seems to show /proc is only used for a message
that print how to debug:

jio_snprintf(buf, sizeof(buf), "gdb /proc/%d/exe %d"

The only usecase I can see for /dev/fd is for
Java_com_sun_management_internal_OperatingSystemImpl_getOpenFileDescriptorCount0

Which should not be hard to patch using sysctl(kern.proc.nfds)

Best regards,
Bapt

On Mon 06 Jan 16:09, Alexander Leidinger wrote:
> Hi,
> 
> It would be good to have some indicators how to determine if it is needed or
> not. Some things to watch out for to be able to decide if it is worth a try
> or not.
> 
> Bye,
> Alexander.
> 
> -- 
> Send from a mobile device, please forgive brevity and misspellings.
> Am 6. Januar 2025 15:20:23 schrieb Xavier Beaudouin <kiwi@FreeBSD.org>:
> 
> > The branch main has been updated by kiwi:
> > 
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=2cf6bc1add649b35668b449ab35fb04ed0a6d263
> > 
> > commit 2cf6bc1add649b35668b449ab35fb04ed0a6d263
> > Author:     Xavier Beaudouin <kiwi@FreeBSD.org>
> > AuthorDate: 2024-12-16 14:30:55 +0000
> > Commit:     Xavier Beaudouin <kiwi@FreeBSD.org>
> > CommitDate: 2025-01-06 14:16:58 +0000
> > 
> >    java/openjdk*: Update pkg-message information about fdescfs and procfs
> > 
> >    OpenJDK installation inform that fdescfs(5) and procfs(5) should be
> >    mounted when using OpenJDK.
> >    After doing some test and some traces, it seems that this should be
> >    no so usefull, some applications will require it, but most of java
> >    applications doesn't seems to suffer to work or performance when
> >    such pseudo FS is not mounted.
> > 
> >    So this change request permit to let local administrator to decide if
> >    it is really needed or not.
> > 
> >    Sponsored by:   Entersekt (previously Modirum MDpay)
> >    Sponsored by:   Klara Inc.
> >    Approved by:    0mp (mentor)
> >    PR:     283364		(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283364)
> > ---
> > java/openjdk11/pkg-message | 4 ++--
> > java/openjdk17/pkg-message | 4 ++--
> > java/openjdk18/pkg-message | 4 ++--
> > java/openjdk19/pkg-message | 4 ++--
> > java/openjdk20/pkg-message | 4 ++--
> > java/openjdk21/pkg-message | 4 ++--
> > java/openjdk22/pkg-message | 4 ++--
> > java/openjdk8/pkg-message  | 4 ++--
> > 8 files changed, 16 insertions(+), 16 deletions(-)
> > 
> > diff --git a/java/openjdk11/pkg-message b/java/openjdk11/pkg-message
> > index 2ea3d87d89c8..fcb6defe8dcd 100644
> > --- a/java/openjdk11/pkg-message
> > +++ b/java/openjdk11/pkg-message
> > @@ -1,8 +1,8 @@
> > [
> > { type: install
> >   message: <<EOM
> > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
> > -procfs(5) mounted on /proc.
> > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd
> > +and procfs(5) mounted on /proc for some applications.
> > 
> > If you have not done it yet, please do the following:
> > 
> > diff --git a/java/openjdk17/pkg-message b/java/openjdk17/pkg-message
> > index 2ea3d87d89c8..fcb6defe8dcd 100644
> > --- a/java/openjdk17/pkg-message
> > +++ b/java/openjdk17/pkg-message
> > @@ -1,8 +1,8 @@
> > [
> > { type: install
> >   message: <<EOM
> > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
> > -procfs(5) mounted on /proc.
> > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd
> > +and procfs(5) mounted on /proc for some applications.
> > 
> > If you have not done it yet, please do the following:
> > 
> > diff --git a/java/openjdk18/pkg-message b/java/openjdk18/pkg-message
> > index 2ea3d87d89c8..fcb6defe8dcd 100644
> > --- a/java/openjdk18/pkg-message
> > +++ b/java/openjdk18/pkg-message
> > @@ -1,8 +1,8 @@
> > [
> > { type: install
> >   message: <<EOM
> > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
> > -procfs(5) mounted on /proc.
> > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd
> > +and procfs(5) mounted on /proc for some applications.
> > 
> > If you have not done it yet, please do the following:
> > 
> > diff --git a/java/openjdk19/pkg-message b/java/openjdk19/pkg-message
> > index 2ea3d87d89c8..fcb6defe8dcd 100644
> > --- a/java/openjdk19/pkg-message
> > +++ b/java/openjdk19/pkg-message
> > @@ -1,8 +1,8 @@
> > [
> > { type: install
> >   message: <<EOM
> > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
> > -procfs(5) mounted on /proc.
> > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd
> > +and procfs(5) mounted on /proc for some applications.
> > 
> > If you have not done it yet, please do the following:
> > 
> > diff --git a/java/openjdk20/pkg-message b/java/openjdk20/pkg-message
> > index 2ea3d87d89c8..fcb6defe8dcd 100644
> > --- a/java/openjdk20/pkg-message
> > +++ b/java/openjdk20/pkg-message
> > @@ -1,8 +1,8 @@
> > [
> > { type: install
> >   message: <<EOM
> > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
> > -procfs(5) mounted on /proc.
> > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd
> > +and procfs(5) mounted on /proc for some applications.
> > 
> > If you have not done it yet, please do the following:
> > 
> > diff --git a/java/openjdk21/pkg-message b/java/openjdk21/pkg-message
> > index 2ea3d87d89c8..fcb6defe8dcd 100644
> > --- a/java/openjdk21/pkg-message
> > +++ b/java/openjdk21/pkg-message
> > @@ -1,8 +1,8 @@
> > [
> > { type: install
> >   message: <<EOM
> > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
> > -procfs(5) mounted on /proc.
> > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd
> > +and procfs(5) mounted on /proc for some applications.
> > 
> > If you have not done it yet, please do the following:
> > 
> > diff --git a/java/openjdk22/pkg-message b/java/openjdk22/pkg-message
> > index 2ea3d87d89c8..fcb6defe8dcd 100644
> > --- a/java/openjdk22/pkg-message
> > +++ b/java/openjdk22/pkg-message
> > @@ -1,8 +1,8 @@
> > [
> > { type: install
> >   message: <<EOM
> > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
> > -procfs(5) mounted on /proc.
> > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd
> > +and procfs(5) mounted on /proc for some applications.
> > 
> > If you have not done it yet, please do the following:
> > 
> > diff --git a/java/openjdk8/pkg-message b/java/openjdk8/pkg-message
> > index 2ea3d87d89c8..fcb6defe8dcd 100644
> > --- a/java/openjdk8/pkg-message
> > +++ b/java/openjdk8/pkg-message
> > @@ -1,8 +1,8 @@
> > [
> > { type: install
> >   message: <<EOM
> > -This OpenJDK implementation requires fdescfs(5) mounted on /dev/fd and
> > -procfs(5) mounted on /proc.
> > +This OpenJDK implementation may require fdescfs(5) mounted on /dev/fd
> > +and procfs(5) mounted on /proc for some applications.
> > 
> > If you have not done it yet, please do the following:
>