Re: git: c41e1ace8e98 - main - ftp/curl: Add LIBUV option
Date: Sat, 28 Sep 2024 19:36:12 UTC
On Thu, Sep 19, 2024 at 11:10 AM Adam Weinberger <adamw@adamw.org> wrote: > On Wed, Sep 18, 2024 at 2:19 AM Po-Chuan Hsieh <sunpoet@freebsd.org> > wrote: > >> The branch main has been updated by sunpoet: >> >> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=c41e1ace8e986493e3fc0b22fa0461aa098182e0 >> >> commit c41e1ace8e986493e3fc0b22fa0461aa098182e0 >> Author: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >> AuthorDate: 2024-09-18 05:55:59 +0000 >> Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> >> CommitDate: 2024-09-18 06:13:08 +0000 >> >> ftp/curl: Add LIBUV option >> --- >> ftp/curl/Makefile | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile >> index 0eebfd2224dd..8bacab43595b 100644 >> --- a/ftp/curl/Makefile >> +++ b/ftp/curl/Makefile >> @@ -41,7 +41,7 @@ CPE_VENDOR= haxx >> >> SHEBANG_FILES= */*.pl >> >> -OPTIONS_DEFINE= ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS >> EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD >> +OPTIONS_DEFINE= ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS >> EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD >> OPTIONS_GROUP= PROTOCOL >> OPTIONS_RADIO= SSL >> OPTIONS_SINGLE= GSSAPI RESOLV >> @@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH= libssh >> LIBSSH_LIB_DEPENDS= libssh.so:security/libssh >> LIBSSH2_CONFIGURE_WITH= libssh2 >> LIBSSH2_LIB_DEPENDS= libssh2.so:security/libssh2 >> +LIBUV_CONFIGURE_WITH= libuv >> +LIBUV_LIB_DEPENDS= libuv.so:devel/libuv >> MQTT_CONFIGURE_ENABLE= mqtt >> NTLM_CONFIGURE_ENABLE= ntlm >> OPENSSL_CONFIGURE_ON= --with-ca-fallback >> > > Hi, Po-Chuan! > > There's no description for this new LIBUV option, so I was unclear what > libuv did for Curl. In upstream's configure.ac, it has this: > > dnl ********************************************************************** > dnl libuv is only ever used for debug purposes > dnl ********************************************************************** > > ... > > if test X"$want_libuv" != Xno; then > if test x$want_debug != xyes; then > AC_MSG_ERROR([Using libuv without debug support enabled is useless]) > fi > > So, the LIBUV option *must* be used with the DEBUG option. If linking > against libuv is going to be important for end-users, we probably want > LIBUV_IMPLIES=DEBUG. > > # Adam > Hello Adam, Thanks for taking care of this option. I have added the missing LIBUV_DESC earlier. It is not useful for normal users since it is for testing. Therefore I did not enable it by default. I'll add "LIBUV_IMPLIES=DEBUG" later. Thanks. Best regards, sunpoet