From nobody Sat Sep 28 13:33:41 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XG7Zt0lSyz5XMgJ; Sat, 28 Sep 2024 13:33:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XG7Zt0FFcz4TqN; Sat, 28 Sep 2024 13:33:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727530422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LDyqidbQ1vCHBXzhcqDFp1i1+edRyRZkB/b3+zVjnzU=; b=MvU8yLGxj6zpul1GQTwzgwXL2f0EqCKTanW9B7cFDd0Lz3OdZ40KAQtrJXiJSpzkJjRQdO nDnbBkZPyFKtCEaupy/HZkkBReg8GIvxMSgi5E8oLKzi7hef7xr5Yw9lmSzQeo3lbeXZeL fS0Ae8G/MLSCFaA5grbfKVz0MEr98BhWV7lknn6OPCTbywxKsFSgIHz9e4nzJbaROTkYV4 rhsFBQA90jDUju7MKA9C9uJ8F0Gl2rJiyoAWqzHjic5MOnM+vtwwskJii5WCd/C8mD7Bah LVkSU3ay8Vu9D7dGn725+U5hq0eVlLJ+3h1Llcn7h3MUfymGO5CppR9H/uRslA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727530422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LDyqidbQ1vCHBXzhcqDFp1i1+edRyRZkB/b3+zVjnzU=; b=TUl9+5y3tytwATp6R21vkDNuPdfRnZJS/ywxg7HgE667TAqEelWhoA16sXS4bT9KG7ktom 2pO1AigljTGRqZR7CA86AJaQl16A94NV7WAijD1oWkX2/lL/2igfDXRIKMM1q+Jd2T3oMS c+T9bKHXAae9Xy7uP97/uhs7PuGpwtUuyFt1JSeAzFuXHQn2i38Eb/3E3FmH10joVJ0Jdb tb2gloBSMzA3O59VHz17FibH7uaRPqaddKCpWGarbeUcfFuQH4EFTiUh7v1YY8kwlu1o/Q kdDCXGW///rVK2f1sqipL3ahJDH1HmZCJw9O9JD6j070yhxh7vIm28Y4mA3yMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727530422; a=rsa-sha256; cv=none; b=rfw68pJJvdvjbqeF8QjMs80ifJDq1NmslL4pvjkcyz4Uwr6Dc+m0nmhKHHyjW3JbrPb7td RZVnOzSmtep27YMVEn8e0vyDOoUOXWiCDlPpeqlRfDrEsuxV53b0r9km7tgMBPyVK6yK0x 1H8CuwRTe3YROHY/DIAhkMt01zGIBkBLeybeHW+WpX4yn/nnCnniCXPIS9ZptcGEm91z5S jl2XieceUuh9J5wzHaXj9x8UqL8k81giAZkLfh6jgPsowJAo4eTmjcmImwaOFAqTPYwaAY wAiuqHT862XexZno33eWH1/Qk4W2m6PGdMIVKP0PyHwVPGTdnfUiuzXb+QNrPg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XG7Zs6y7vzQtQ; Sat, 28 Sep 2024 13:33:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48SDXf8Y003078; Sat, 28 Sep 2024 13:33:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48SDXf3g003075; Sat, 28 Sep 2024 13:33:41 GMT (envelope-from git) Date: Sat, 28 Sep 2024 13:33:41 GMT Message-Id: <202409281333.48SDXf3g003075@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: c55157301f31 - main - devel/poco: fix build with libc++ 19 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c55157301f317ab8166349340d4cc0765deaac12 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=c55157301f317ab8166349340d4cc0765deaac12 commit c55157301f317ab8166349340d4cc0765deaac12 Author: Dimitry Andric AuthorDate: 2024-09-17 08:21:22 +0000 Commit: Dimitry Andric CommitDate: 2024-09-28 13:29:44 +0000 devel/poco: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes devel/poco to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ /usr/include/c++/v1/__type_traits/is_constructible.h:42:62: note: in instantiation of template class 'std::basic_string' requested here 42 | : public integral_constant)> {}; | ^ /usr/include/c++/v1/__type_traits/is_swappable.h:43:39: note: in instantiation of template class 'std::is_move_constructible>' requested here 43 | using __swap_result_t = __enable_if_t::value && is_move_assignable<_Tp>::value>; | ^ /usr/include/c++/v1/__type_traits/is_swappable.h:50:60: note: in instantiation of template type alias '__swap_result_t' requested here 50 | inline _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 __swap_result_t<_Tp> swap(_Tp& __x, _Tp& __y) | ^ /wrkdirs/usr/ports/devel/poco/work/poco-1.12.4-all/Data/include/Poco/Data/LOB.h:243:14: note: while substituting explicitly-specified template arguments into function template 'swap' 243 | inline void swap(Poco::Data::BLOB& b1, Poco::Data::BLOB& b2) noexcept | ^ In this case it is enough to only enable the LOB constructor from std::basic_string when the type is plain char. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 281553 MFH: 2024Q3 --- devel/poco/files/patch-Data_include_Poco_Data_LOB.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/devel/poco/files/patch-Data_include_Poco_Data_LOB.h b/devel/poco/files/patch-Data_include_Poco_Data_LOB.h new file mode 100644 index 000000000000..e893a18625b2 --- /dev/null +++ b/devel/poco/files/patch-Data_include_Poco_Data_LOB.h @@ -0,0 +1,14 @@ +--- Data/include/Poco/Data/LOB.h.orig 2022-10-31 17:44:34 UTC ++++ Data/include/Poco/Data/LOB.h +@@ -63,8 +63,9 @@ class LOB (public) + { + } + +- LOB(const std::basic_string& content): +- _pContent(new std::vector(content.begin(), content.end())) ++ template ::value>> ++ LOB(const std::basic_string& content): ++ _pContent(new std::vector(content.begin(), content.end())) + /// Creates a LOB from a string. + { + }