From nobody Sat Sep 28 09:47:36 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XG2Z32g38z5X58k; Sat, 28 Sep 2024 09:47:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XG2Z10Z3Sz3ytm; Sat, 28 Sep 2024 09:47:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727516857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wl1pdmyIPZZUWVjhspw1x9lk8leVr9Yrbd+4Hfdj26w=; b=CEzXBkknhaB+YRzHhmVXi8RI7P1thLLhYIkRrpgkvVydpbv29ncr2+n84VxTjtMnoXZBLF jzTXEOfkjhSoHQmBc7BjVRWnMHFGZ0S1OjRVQvgzy2TFKdW6xOuXSeLAelr/Aby3E6oOX5 AAdmrxRctR8hcOtQBFxGusyZT8tzQFtpTI1lT+wM+zz4jxIBZE+790Ady2EBWRqd6S5lfu o8Jq1ssbPbNw64N5F9Sfur3Q22OaIgfXGVInuGSgbswXVSlRp4tTOoduCjsIRMJ8QqwR2v js6ozUvO9sI3vhctSucE3gmPygk8bkJIjZLGALEuPBDbft4UzBOm/Zb2J3pdJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727516857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wl1pdmyIPZZUWVjhspw1x9lk8leVr9Yrbd+4Hfdj26w=; b=ercnHDWqq4lnYet+wZH0cvcN2q7N3PngCsAK9N1FkMqcVTFCwscClhGbxNSGCGDapD9aGU gHKgg1LQU0CAQsyFAJzNHrJdbBK98LB8l0m8YE/DcMGIpDYq4zYVncv6UoBBr9OAL7giEk u5PDSfeakvOJWtz3vrtzehSQHLkrdAZNpz6jYG5CpxVAar0HHMNXGJB+htYLWKkr7idNQ/ mV99dVsnqClmiu48hzLA1DNIDBllJ/O5DLihOVAy7MQlBqYtTwND5djMjTEGphIFGI1zzh d4rGmwrforVNcegls3xf8XOVrbXLlneiOgSWHcixTx1ifepzW+aZXUzA5gXfFw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727516857; a=rsa-sha256; cv=none; b=K7jONQNKA4e04E3Dl2P7xb6AlUq0BZFBpmac2PU4tdxtJBdmrvLhUaAWJZTHb6eWSC6VqB 1glcbg8XMa5XpxWT/Sx2CJ+fvZEY4LgxzOKIL1zSNz5sMzaDD0Jq0ATLlfj3BvZ+5lWKga cVEPbnYEdspdbUOjWHjbXfT+fqb2L/d1zYvU5HzmjRe9hZX02Hr/KmEcH7M3R7nVnYg4eB 9GVGlcz1ZpmYwxXuEoDIOPL6n+IHELzLbzb1SAtEzA8UXC6qtKLFH7wlffHZRipuuth5aU m4fe0+NrNjKS9O/cd4CjVgK8zcYjjudQfUo2TdsedleQUA7BmpbBsTNrO5XkdQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XG2Z06VWVzKLL; Sat, 28 Sep 2024 09:47:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48S9laNc011117; Sat, 28 Sep 2024 09:47:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48S9laTu011114; Sat, 28 Sep 2024 09:47:36 GMT (envelope-from git) Date: Sat, 28 Sep 2024 09:47:36 GMT Message-Id: <202409280947.48S9laTu011114@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: c1c4aae636e9 - main - devel/libxsd-frontend: fix build with libc++ 19 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c1c4aae636e9e8c5fc146caeb9ad734e20f97115 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=c1c4aae636e9e8c5fc146caeb9ad734e20f97115 commit c1c4aae636e9e8c5fc146caeb9ad734e20f97115 Author: Dimitry Andric AuthorDate: 2024-09-13 10:36:00 +0000 Commit: Dimitry Andric CommitDate: 2024-09-28 09:45:51 +0000 devel/libxsd-frontend: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes www/qt5-webengine to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ /wrkdirs/usr/ports/devel/libxsd-frontend/work/libxsd-frontend-2.1.0/libxsd-frontend/xml.hxx:100:23: note: in instantiation of template class 'std::basic_string' requested here 100 | NarrowString r (s); | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ The `Bits::None` construct used by libxsd-frontend is meant to disable unwanted conversions, but it no longer works if `std::char_traits>` is undefined for this type. Fix it by removing the `Bits` namespace and only enabling the converting constructors if the first type of `StringTemplate` is `wchar_t`. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals PR: 281478 Approved by: maintainer timeout (2 weeks) MFH: 2024Q3 --- .../files/patch-libxsd-frontend_types.hxx | 62 ++++++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/devel/libxsd-frontend/files/patch-libxsd-frontend_types.hxx b/devel/libxsd-frontend/files/patch-libxsd-frontend_types.hxx new file mode 100644 index 000000000000..6162dbf7fe56 --- /dev/null +++ b/devel/libxsd-frontend/files/patch-libxsd-frontend_types.hxx @@ -0,0 +1,62 @@ +--- libxsd-frontend/types.hxx.orig 2022-08-19 06:30:48 UTC ++++ libxsd-frontend/types.hxx +@@ -13,38 +13,13 @@ namespace XSDFrontend + { + using std::size_t; + +- namespace Bits +- { +- struct None {}; +- +- template +- struct NarrowerChar +- { +- typedef None Type; +- }; +- +- template <> +- struct NarrowerChar +- { +- typedef char Type; +- }; +- } +- + struct LIBXSD_FRONTEND_SYMEXPORT NonRepresentable: std::exception + { + virtual char const* + what () const throw (); + }; + +- template ::Type> +- class StringTemplate; +- +- template <> +- class StringTemplate +- { +- }; +- +- template ++ template + class StringTemplate : public std::basic_string + { + typedef std::basic_string Base; +@@ -114,16 +89,19 @@ namespace XSDFrontend + + // Conversion from the Narrower type. Experimental. + // ++ template>> + StringTemplate (NC const* s) + { + from_narrow (s); + } + ++ template>> + StringTemplate (StringTemplate const& other) + { + from_narrow (other.c_str ()); + } + ++ template>> + StringTemplate (NarrowerBase const& other) + { + from_narrow (other.c_str ());