From nobody Sat Sep 28 09:47:37 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XG2Z24sd9z5X4f3; Sat, 28 Sep 2024 09:47:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XG2Z20yjJz40CW; Sat, 28 Sep 2024 09:47:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727516858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dJy9lvI+hz79edSjGLT3Bay9qVI/Crfhlz3bQ23FdB4=; b=U05eRm4lxZl9j2YRm0AO3wahxoxNmZWrs11PC8tTWBT1e++/UayUZ4jr8r+CTbnJBJhGCq Gch00qaZ7pLkSanOqG9w8hmzeLFbJWdIPFmh+u5IgzszyiygrGFXlNdX6qAVXMAm+jmToW q6P+zagIObZRukt6e4oCLfStJJ8QrVg1TeOBY0mI4s3U66cacvyLRKDTW0w+m4kUeOpKpQ XbFLxpBBTQnXCiS3x0rtlB6Mqa+akndw+DiGIr/fovG53OP3W/oLoV7Bm6Y//yyYSG6ZlU nKvFg8VFDlp8fIQxvMFG7lRhF9xMjKmnWHvIHgcKs/v3I2lsxDGNJHoJ4yb6SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727516858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dJy9lvI+hz79edSjGLT3Bay9qVI/Crfhlz3bQ23FdB4=; b=l6BtzI6a48hGaOYmNEAUsUrO0dxFfINQlOEFEbQk/Se7FHhHKHHWiFMnDTHUh4MI5RABl5 bvxpwUvIWkuPICaqd/Aq6LKtfoNvZHkAeIdDjPmMSenxAup+xV/7/NN5W3lFHJIds97FZH JXKYhYVwwrFJ0u3TS5SvyT2GhlkJEid9FPGSMaF8bkPc7fRnsLA6alOJPlWPVmKbJiabzx 2qzRtndr4aKrrplhdWEVh4s3QEVtazNRBrFsCKklT+/tDplGUFQx9jJGIXcVI4WKc73HIn x8k0C2+ZY9fX/njrt2J/txHclkdlQCTc0CA1cjjA5jQ641k7DO1QMi+hehOjXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727516858; a=rsa-sha256; cv=none; b=WRTJ9x4w3qop6HJWDfQUN4o7dTbwP+ZEobPOCIJEByt7QU9HNVzTi2gNmiaOvjlEVTId6V dZFGzBXDmKopQ7gfSGCsjYyNWEYpRBeZ/zygwtksix1UBvYzD6U8WDmXLjDkXcB4twAkYF IW6bEiLz5vGad7ohVXRw+oSHP3jZToJm3snDBp7GzW+NwXA59z7zgamGU2A9/cPRdtS5eU ik+f9FxjBVjDoBC0OiUQWVEm1CyHTGvW52528b/YaLQ+kNMaTECzv7CihOudbyQyDgtTs2 r2ecxG3TE/uOWqJc0fzEwus+WRwOmwm2L5JyHGutDWbMc+KCESs5XUwuV7qXzg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XG2Z20Q0bzK59; Sat, 28 Sep 2024 09:47:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48S9lbqQ011162; Sat, 28 Sep 2024 09:47:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48S9lbXF011159; Sat, 28 Sep 2024 09:47:37 GMT (envelope-from git) Date: Sat, 28 Sep 2024 09:47:37 GMT Message-Id: <202409280947.48S9lbXF011159@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: c42de78032ea - main - security/olm: fix build with clang 19 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c42de78032ea24d6431412e2aec35383c3c66a34 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=c42de78032ea24d6431412e2aec35383c3c66a34 commit c42de78032ea24d6431412e2aec35383c3c66a34 Author: Dimitry Andric AuthorDate: 2024-09-14 11:33:09 +0000 Commit: Dimitry Andric CommitDate: 2024-09-28 09:46:34 +0000 security/olm: fix build with clang 19 Clang 19 has become more strict about assigning to const variables, resulting in an error similar to: /wrkdirs/usr/ports/security/olm/work/olm-6d767aaf29bdf15571c2ef4d3f8f9e953de03733/include/olm/list.hh:106:13: error: cannot assign to variable 'other_pos' with const-qualified type 'T *const' 106 | ++other_pos; | ^ ~~~~~~~~~ /wrkdirs/usr/ports/security/olm/work/olm-6d767aaf29bdf15571c2ef4d3f8f9e953de03733/include/olm/list.hh:102:19: note: variable 'other_pos' declared const here 102 | T * const other_pos = other._data; | ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ In this case, it looks like a typo: "T * const" means that the pointer itself is const, thus it cannot be incremented. Instead, this should be "T const *" (spelled alternatively as "const T *"), which means that the object pointed to is const, not the pointer itself. PR: 281496 Approved by: maintainer timeout (2 weeks) MFH: 2024Q3 --- security/olm/files/patch-include_olm_list.hh | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/security/olm/files/patch-include_olm_list.hh b/security/olm/files/patch-include_olm_list.hh new file mode 100644 index 000000000000..055f0833a4bc --- /dev/null +++ b/security/olm/files/patch-include_olm_list.hh @@ -0,0 +1,11 @@ +--- include/olm/list.hh.orig 2022-10-07 15:00:05 UTC ++++ include/olm/list.hh +@@ -99,7 +99,7 @@ class List { (public) + return *this; + } + T * this_pos = _data; +- T * const other_pos = other._data; ++ T const * other_pos = other._data; + while (other_pos != other._end) { + *this_pos = *other; + ++this_pos;