From nobody Thu Sep 19 03:10:27 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X8LBG1z5Yz5WQn8 for ; Thu, 19 Sep 2024 03:10:46 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X8LBF6Thnz4VHC for ; Thu, 19 Sep 2024 03:10:45 +0000 (UTC) (envelope-from adamw@adamw.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2f7528f4658so2678161fa.3 for ; Wed, 18 Sep 2024 20:10:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20230601.gappssmtp.com; s=20230601; t=1726715444; x=1727320244; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gWwC/uq+uAsxdBuHkrE0SBkOTnNGsyqWhvTwgMzTfZg=; b=jRK3ZrtFZGgEZnholO3cU5vMrw6V3qiLsJFMZWcwRpkyMdhN+N00vYt2nWvZmr07DP HApa7cnVVGMUE9PXI7dYQUbg8vw7780O7lXGIxuNvkxcAoKrFlspVc6/iWx4Qbekon0a dUYxUvp//VVCp4BgBDBUjGWIlCrW5JcQQ6adfYe0VEoGySS6Cqjc+QlI4RpxwI3WgiH2 TQjfrH+HwOQZHkh0N5mqO3R9UsiD6QkB2Ifn3QMePDfd5PrKfvTYB+Jeww4WbSaAdU9r Twh/yLDJdBgFXAO9f58g/1Yu7l05h1fTlsGW9OgBfG39Z+vSbadPKHARbtngS5KyZCMy EPJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726715444; x=1727320244; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gWwC/uq+uAsxdBuHkrE0SBkOTnNGsyqWhvTwgMzTfZg=; b=C15JFoYD71KpoIMJuDkgnR2A+FFbOFn/PYc5xH1nYz77xIpC5xXIdvVqjY8Y1ji87C EA7uuOapeQL380wmhkHnOwsW2sJ2eHnb4bR0hFA0dJB4aZigJ211gvCn6+JADp2FMAhx 0+pkxBdU7DLjvt9Ru8ajHlglVfX/cCITG3WDlh29+mCF/gFDreigTl7DpFLaEBc8CSEn NVJEa/UVh0FSxkLqDDDTXLzbta7ZHS7z9nzs9A3ZFNC5TVao6TDsKRJNW3jR2AqJ4ooV 8xWaxaD4okEAoYCKIcPEMw8ec/mjG8GPOKfijdGIZQ7GWgtSTF4snpXYnoH3dqbdGghi sgcA== X-Forwarded-Encrypted: i=1; AJvYcCVECSHdNp2v6BKRad1xrVBjOs61ZmA56eU9EbJpTkBGlrH04zWKEk47+9RQA5wrWcoV6VR+rjL1For11wvN5l1YfpJfIiA=@freebsd.org X-Gm-Message-State: AOJu0Yw1YsTayAnn973pXtd23boGvfEUHZdW0YtuyrHAdwkAPYLU77uZ I1fcCry2O9lgQ6UD+6lZhDmsHI3aYy84e6aT+W9vZZ6KHzUI8niY+fY3ra4PJ+qxhEMFx9TYRhR 43ThopjWP6suBc0SKne4YFN1eM5XseCs5DGHYNA== X-Google-Smtp-Source: AGHT+IHHEvrQ7Epj21UyYfG5eKVSLTwDRaUDPt0r1Nn2sjw9sEwloGGP2Phj5RzEYKjURVE+QIFX5aF1XAq+um7Fj6A= X-Received: by 2002:a05:6512:3d86:b0:536:a6c6:33f with SMTP id 2adb3069b0e04-536a6c616bbmr421733e87.13.1726715443742; Wed, 18 Sep 2024 20:10:43 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 References: <202409180619.48I6J0G7032519@gitrepo.freebsd.org> In-Reply-To: <202409180619.48I6J0G7032519@gitrepo.freebsd.org> From: Adam Weinberger Date: Wed, 18 Sep 2024 23:10:27 -0400 Message-ID: Subject: Re: git: c41e1ace8e98 - main - ftp/curl: Add LIBUV option To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000a7292506227044ed" X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4X8LBF6Thnz4VHC X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated --000000000000a7292506227044ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 18, 2024 at 2:19=E2=80=AFAM Po-Chuan Hsieh wrote: > The branch main has been updated by sunpoet: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e986493e3fc0b22fa046= 1aa098182e0 > > commit c41e1ace8e986493e3fc0b22fa0461aa098182e0 > Author: Po-Chuan Hsieh > AuthorDate: 2024-09-18 05:55:59 +0000 > Commit: Po-Chuan Hsieh > CommitDate: 2024-09-18 06:13:08 +0000 > > ftp/curl: Add LIBUV option > --- > ftp/curl/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile > index 0eebfd2224dd..8bacab43595b 100644 > --- a/ftp/curl/Makefile > +++ b/ftp/curl/Makefile > @@ -41,7 +41,7 @@ CPE_VENDOR=3D haxx > > SHEBANG_FILES=3D */*.pl > > -OPTIONS_DEFINE=3D ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS > EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD > +OPTIONS_DEFINE=3D ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS > EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD > OPTIONS_GROUP=3D PROTOCOL > OPTIONS_RADIO=3D SSL > OPTIONS_SINGLE=3D GSSAPI RESOLV > @@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH=3D libssh > LIBSSH_LIB_DEPENDS=3D libssh.so:security/libssh > LIBSSH2_CONFIGURE_WITH=3D libssh2 > LIBSSH2_LIB_DEPENDS=3D libssh2.so:security/libssh2 > +LIBUV_CONFIGURE_WITH=3D libuv > +LIBUV_LIB_DEPENDS=3D libuv.so:devel/libuv > MQTT_CONFIGURE_ENABLE=3D mqtt > NTLM_CONFIGURE_ENABLE=3D ntlm > OPENSSL_CONFIGURE_ON=3D --with-ca-fallback > Hi, Po-Chuan! There's no description for this new LIBUV option, so I was unclear what libuv did for Curl. In upstream's configure.ac, it has this: dnl ********************************************************************** dnl libuv is only ever used for debug purposes dnl ********************************************************************** ... if test X"$want_libuv" !=3D Xno; then if test x$want_debug !=3D xyes; then AC_MSG_ERROR([Using libuv without debug support enabled is useless]) fi So, the LIBUV option *must* be used with the DEBUG option. If linking against libuv is going to be important for end-users, we probably want LIBUV_IMPLIES=3DDEBUG. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org --000000000000a7292506227044ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 18, 2024 at 2:19=E2=80=AFAM Po-Chuan= Hsieh <sunpoet@freebsd.org&g= t; wrote:
The branch main has been updated by sunpoet:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e986493e3fc0b22fa0461aa098182e0

commit c41e1ace8e986493e3fc0b22fa0461aa098182e0
Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-09-18 05:55:59 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-09-18 06:13:08 +0000

=C2=A0 =C2=A0 ftp/curl: Add LIBUV option
---
=C2=A0ftp/curl/Makefile | 4 +++-
=C2=A01 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile
index 0eebfd2224dd..8bacab43595b 100644
--- a/ftp/curl/Makefile
+++ b/ftp/curl/Makefile
@@ -41,7 +41,7 @@ CPE_VENDOR=3D=C2=A0 =C2=A0haxx

=C2=A0SHEBANG_FILES=3D */*.pl

-OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTSVC BROTLI COOKIES CURL_DE= BUG DEBUG DOCS EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD
+OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTSVC BROTLI COOKIES CURL_DE= BUG DEBUG DOCS EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD =C2=A0OPTIONS_GROUP=3D PROTOCOL
=C2=A0OPTIONS_RADIO=3D SSL
=C2=A0OPTIONS_SINGLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 GSSAPI RESOLV
@@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH=3D=C2=A0 =C2=A0 =C2=A0 libssh
=C2=A0LIBSSH_LIB_DEPENDS=3D=C2=A0 =C2=A0 libssh.so:security/libssh
=C2=A0LIBSSH2_CONFIGURE_WITH=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 libssh2
=C2=A0LIBSSH2_LIB_DEPENDS=3D=C2=A0 =C2=A0libssh2.so:security/libssh2
+LIBUV_CONFIGURE_WITH=3D=C2=A0 libuv
+LIBUV_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0libuv.so:devel/libuv
=C2=A0MQTT_CONFIGURE_ENABLE=3D mqtt
=C2=A0NTLM_CONFIGURE_ENABLE=3D ntlm
=C2=A0OPENSSL_CONFIGURE_ON=3D=C2=A0 --with-ca-fallback

Hi, Po-Chuan!

There's no description for= this new LIBUV option, so I was unclear what libuv did for Curl. In upstre= am's configure.ac, it has this:

<= /div>
dn= l **********************************************************************dnl libuv is only ever used for debug purposes
dnl ********************= **************************************************

=
..= .
=
if test X"$want_libuv" !=3D Xno; then
=C2=A0 if test x$want= _debug !=3D xyes; then
=C2=A0 =C2=A0 AC_MSG_ERROR([Using libuv without d= ebug support enabled is useless])
=C2=A0 fi

So, the LIBUV option *must*= be used with the DEBUG option. If linking against libuv is going to be imp= ortant for end-users, we probably want LIBUV_IMPLIES=3DDEBUG.

# Adam
=


--
--000000000000a7292506227044ed--