From nobody Sun Sep 15 12:08:23 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X66JS1Myyz5WKPW; Sun, 15 Sep 2024 12:08:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X66JS05Xlz42w3; Sun, 15 Sep 2024 12:08:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726402104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p82Eh359DaCb8Z6S4Noh31jqt20sU2oVKSZ87WO4TGY=; b=Xu/gonxNxt3Rm421xwRx0Lmjl+eklOx/sa3G62rCft163cFcXbFpGJ7kde6WLu/RkHrlhX Dpc5E4yusST1CyLD8DHgWJ2+wlA5f0OK/72vlxFx0zF0C3FgkF9XM4QBrM0IllesdHQ9Bc Tc9Jbv/GFP6PUvhL8+wF7tGD0rB0UnRsvRKsDX4CO9CSpC+zqZqDx2UUFNuEAhP7llurXV Zlz0th2JfsHZyjBUFSKm3AFE3IEj6iqYoNjGdDDDhBklgZMDHjw5UpHTnBXJRO5fHPkuM4 AzbKMnXqWaueIWiTkwDpNQVqZ8y1jVUdXuZOiDDVPlQ9hgctd+2Fk1FP1DLebQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726402104; a=rsa-sha256; cv=none; b=ed9DEbwez6MNxkBuCIzDOdjflYnFNYL/J07xIzxq4J7mxY03P3ABrqn46VspMC8QmSUXSH 36E8azVUbxreqk3lcw6QIi8lFAOcIcDa8rEG1dUFD01qPBtH/iQ5I7gZPATgDsjl2WglSg ejcJwKUqlKGG7X/Lafi+GIs8O4k0DvFD6SV29M6iSap9I2XxXDhVVNZovugTGvTcrnQ6Xy qdAiilpy0lXur/fUXL0hBzlq46DU/Hodj+YDDFw+AtEv1T34nDbJ1xKZIqjStdRg9ve/6L SGrXaFUELyREII3hB1Xr8pNFrKcf9yA6H1dTvXjjQsMYNrVytqeuBzlCbrnicA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726402104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p82Eh359DaCb8Z6S4Noh31jqt20sU2oVKSZ87WO4TGY=; b=XpJyKrE2FCclGZVVwiTQM9sTBoXi4Ck9+wcgwlOzli41BuukzPdWNgIX6FgXV9muLqu2e8 RbEbM1XuTZx/beDJAZu1M9JUBe7/e+Pm0XA5wmGv5WijL3uNMII6ZvmA7rMgXAEoXnvcdE dbtG3zoyuLLpFgKYvEMpacypLrX38N/f9Ogh2PH7Q89eqmP9yPsISxd1mBpETqQooB5JBX XiW7Ok2MxcZZP2+TcmISR2b361ogtaWBpkSWIMpSGD9LjC2acVJ2Utuy35sCol80rWRaPT oJQWEX98ajqH26mccJZO+WNGIXkvTHXhGb7WvKU1j5fkPVP++WlhGCy7qRBXCw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4X66JR6VF3z18wq; Sun, 15 Sep 2024 12:08:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 48FC8NoC044461; Sun, 15 Sep 2024 12:08:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 48FC8NKV044458; Sun, 15 Sep 2024 12:08:23 GMT (envelope-from git) Date: Sun, 15 Sep 2024 12:08:23 GMT Message-Id: <202409151208.48FC8NKV044458@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org From: Gleb Popov Subject: git: 1168d8b84975 - 2024Q3 - math/z3: fix build with clang 19 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: arrowd X-Git-Repository: ports X-Git-Refname: refs/heads/2024Q3 X-Git-Reftype: branch X-Git-Commit: 1168d8b84975a1fde55bd7f25a97970268542a73 Auto-Submitted: auto-generated The branch 2024Q3 has been updated by arrowd: URL: https://cgit.FreeBSD.org/ports/commit/?id=1168d8b84975a1fde55bd7f25a97970268542a73 commit 1168d8b84975a1fde55bd7f25a97970268542a73 Author: Dimitry Andric AuthorDate: 2024-09-15 11:53:50 +0000 Commit: Gleb Popov CommitDate: 2024-09-15 12:08:13 +0000 math/z3: fix build with clang 19 Clang 19 has become more strict about errors in member functions, which results in: /wrkdirs/usr/ports/math/z3/work/z3-z3-4.13.0/src/math/lp/static_matrix.h:82:72: error: no member named 'get' in 'static_matrix'; did you mean 'set'? 82 | ref operator=(ref & v) { m_matrix.set(m_row, m_col, v.m_matrix.get(v.m_row, v.m_col)); return *this; } | ^~~ | set /wrkdirs/usr/ports/math/z3/work/z3-z3-4.13.0/src/math/lp/static_matrix.h:164:10: note: 'set' declared here 164 | void set(unsigned row, unsigned col, T const & val); | ^ Upstream fixed this as part of a few other changes for gcc 15 in , but it does not apply cleanly to this version, so add a backported patch. PR: 281512 MFH: 2024Q3 (cherry picked from commit 88af7aa2d01a15a3d77380bf590921e04996ef45) --- math/z3/files/patch-backport-2ce89e5f4 | 125 +++++++++++++++++++++++++++++++++ 1 file changed, 125 insertions(+) diff --git a/math/z3/files/patch-backport-2ce89e5f4 b/math/z3/files/patch-backport-2ce89e5f4 new file mode 100644 index 000000000000..07161f1d64ed --- /dev/null +++ b/math/z3/files/patch-backport-2ce89e5f4 @@ -0,0 +1,125 @@ +From 2ce89e5f491fa817d02d8fdce8c62798beab258b Mon Sep 17 00:00:00 2001 +From: David Seifert <16636962+SoapGentoo@users.noreply.github.com> +Date: Mon, 29 Jul 2024 20:07:10 +0200 +Subject: [PATCH] Gcc 15 two phase (#7313) + +* Fix `-Wclass-memaccess` + +* Fix for GCC 15 two-phase lookup + +* GCC 15 is more aggressive about checking dependent names: + https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=r15-2117-g313afcfdabeab3 + +Bug: https://bugs.gentoo.org/936634 +--- + src/math/lp/lp_settings.h | 69 ++++++++++++++++----------------- + src/math/lp/static_matrix.h | 2 +- + src/math/lp/static_matrix_def.h | 2 +- + 3 files changed, 36 insertions(+), 37 deletions(-) + +diff --git src/math/lp/lp_settings.h src/math/lp/lp_settings.h +index d1a4be21c64..0d47877c76b 100644 +--- src/math/lp/lp_settings.h ++++ src/math/lp/lp_settings.h +--- src/math/lp/lp_settings.h.orig 2024-03-07 18:25:16 UTC ++++ src/math/lp/lp_settings.h +@@ -97,39 +97,39 @@ struct statistics { + }; + + struct statistics { +- unsigned m_make_feasible; +- unsigned m_total_iterations; +- unsigned m_iters_with_no_cost_growing; +- unsigned m_num_factorizations; +- unsigned m_num_of_implied_bounds; +- unsigned m_need_to_solve_inf; +- unsigned m_max_cols; +- unsigned m_max_rows; +- unsigned m_gcd_calls; +- unsigned m_gcd_conflicts; +- unsigned m_cube_calls; +- unsigned m_cube_success; +- unsigned m_patches; +- unsigned m_patches_success; +- unsigned m_hnf_cutter_calls; +- unsigned m_hnf_cuts; +- unsigned m_nla_calls; +- unsigned m_gomory_cuts; +- unsigned m_nla_add_bounds; +- unsigned m_nla_propagate_bounds; +- unsigned m_nla_propagate_eq; +- unsigned m_nla_lemmas; +- unsigned m_nra_calls; +- unsigned m_nla_bounds_improvements; +- unsigned m_horner_calls; +- unsigned m_horner_conflicts; +- unsigned m_cross_nested_forms; +- unsigned m_grobner_calls; +- unsigned m_grobner_conflicts; +- unsigned m_offset_eqs; +- unsigned m_fixed_eqs; ++ unsigned m_make_feasible = 0; ++ unsigned m_total_iterations = 0; ++ unsigned m_iters_with_no_cost_growing = 0; ++ unsigned m_num_factorizations = 0; ++ unsigned m_num_of_implied_bounds = 0; ++ unsigned m_need_to_solve_inf = 0; ++ unsigned m_max_cols = 0; ++ unsigned m_max_rows = 0; ++ unsigned m_gcd_calls = 0; ++ unsigned m_gcd_conflicts = 0; ++ unsigned m_cube_calls = 0; ++ unsigned m_cube_success = 0; ++ unsigned m_patches = 0; ++ unsigned m_patches_success = 0; ++ unsigned m_hnf_cutter_calls = 0; ++ unsigned m_hnf_cuts = 0; ++ unsigned m_nla_calls = 0; ++ unsigned m_gomory_cuts = 0; ++ unsigned m_nla_add_bounds = 0; ++ unsigned m_nla_propagate_bounds = 0; ++ unsigned m_nla_propagate_eq = 0; ++ unsigned m_nla_lemmas = 0; ++ unsigned m_nra_calls = 0; ++ unsigned m_nla_bounds_improvements = 0; ++ unsigned m_horner_calls = 0; ++ unsigned m_horner_conflicts = 0; ++ unsigned m_cross_nested_forms = 0; ++ unsigned m_grobner_calls = 0; ++ unsigned m_grobner_conflicts = 0; ++ unsigned m_offset_eqs = 0; ++ unsigned m_fixed_eqs = 0; + statistics() { reset(); } +- void reset() { memset(this, 0, sizeof(*this)); } ++ void reset() { *this = statistics{}; } + void collect_statistics(::statistics& st) const { + st.update("arith-factorizations", m_num_factorizations); + st.update("arith-make-feasible", m_make_feasible); +diff --git src/math/lp/static_matrix.h src/math/lp/static_matrix.h +index 9d6bb859964..42dd476b5d4 100644 +--- src/math/lp/static_matrix.h ++++ src/math/lp/static_matrix.h +@@ -79,7 +79,7 @@ class static_matrix (public) + ref(static_matrix & m, unsigned row, unsigned col):m_matrix(m), m_row(row), m_col(col) {} + ref & operator=(T const & v) { m_matrix.set( m_row, m_col, v); return *this; } + +- ref operator=(ref & v) { m_matrix.set(m_row, m_col, v.m_matrix.get(v.m_row, v.m_col)); return *this; } ++ ref operator=(ref & v) { m_matrix.set(m_row, m_col, v.m_matrix.get_elem(v.m_row, v.m_col)); return *this; } + + operator T () const { return m_matrix.get_elem(m_row, m_col); } + }; +diff --git src/math/lp/static_matrix_def.h src/math/lp/static_matrix_def.h +index 0370ee8990a..c3b2fc16821 100644 +--- src/math/lp/static_matrix_def.h ++++ src/math/lp/static_matrix_def.h +--- src/math/lp/static_matrix_def.h.orig 2024-03-07 18:25:16 UTC ++++ src/math/lp/static_matrix_def.h +@@ -92,7 +92,7 @@ static_matrix::static_matrix(static_matrix const + init_row_columns(m, m); + for (; m-- > 0; ) + for (auto & col : A.m_columns[m]) +- set(col.var(), m, A.get_value_of_column_cell(col)); ++ set(col.var(), m, A.get_column_cell(col)); + } + + template void static_matrix::clear() {