From nobody Sun Oct 20 09:59:51 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XWYnz3LfPz5Yq7x; Sun, 20 Oct 2024 09:59:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XWYnz2pt1z4Q78; Sun, 20 Oct 2024 09:59:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729418391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4ZxXABkwBFVLuHJkpFU5XRkHNrszrHFLsOfsyOgsChA=; b=Mh02KeBRjmRzAaVlTkbpJvkbER9WT9DXKa/Ap8wqaopXyZVCKmUnpk/687bvZxeMdz3PDE zWokleKAZ2vP9hCEUD1423PxbXxUrxcIB+7POIOsA5vvudn5O+DYAp/euVMqlAMpJ40YLM QVeUSDo9ZokIL8Lm3Tg6KTXtPrs2YoZit7ijnpSA1VO7VoOAvvDOmVIbjj6R3jw/WTv2Yt XngivY7gU2kL1M27h3AtaqKpMuKc3hGhPjoCXVTZkHNqoGI4/e7Xe6k6XD/O0znPbpcPjw CWCotrh25hx8Pe9SzXSLm7IEwpVbgyWk+MUyTqIU9ptuDFE/tAiId/6ogo2Jtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729418391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4ZxXABkwBFVLuHJkpFU5XRkHNrszrHFLsOfsyOgsChA=; b=vLSPOYmr7chnHF3dae0sjr7UmDf5Cl64kDNstY9S81pvICIXQ4PEKyWbUN4uXNOlEQBxmh 0DNbw+sNepcrx40PMrltK75Yt4srBwbCOIQdVY72ihsyIuIc045oBu96DJQFreWTL3Um7Z 5uD/7J75rtZay3DBUXNwATGzi0/8KYtVtoDx09uS4r/JoxvZNwLxhjJJWXyHTpvTIhrYFv 0CGY7sDR+vKyS+tjf9Vh8+grVlo97hY5ANXKv3GCvTUx/gp/vrlPTVmMJ55GgCRVsB3eBJ ADn65pNt2obPlWrFl6UMTyIBdZHFujGsy/dxdKeuyzis0HV03LVaafgkc5azIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729418391; a=rsa-sha256; cv=none; b=KjwdUg73ACgsJEDBIr8Nif1SHV7erkuV2HoJEJ+w1oB1ptg3CQWn57di6BEfL6/M0p6eod hm6J5luuJah0FZzi2E58M8WaCPAATiiF6nKISpAG1DQwgx8bQFQiOslOHVlvzAzASjYSsO ZmLnKq8VS2Qs4UjSYL6/QbS1p9u5OBSVTGVy0LuBNnbrzvCVIezTS2CnTy/D1BVxnYy3gu swxTddffuJAkrZUPuYk1tbBwc/TbV1hlAFQXN8ayxReii5Ybib09GAw6GGE44vW89sD01K 9/R+FHq1ieXK+F1O4OVf0y4QMq+goDz9xe1u9bfoCMiHqV8R65cxw069v2w0Bw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XWYnz2K9mzxKK; Sun, 20 Oct 2024 09:59:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49K9xpvr098949; Sun, 20 Oct 2024 09:59:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49K9xpdc098946; Sun, 20 Oct 2024 09:59:51 GMT (envelope-from git) Date: Sun, 20 Oct 2024 09:59:51 GMT Message-Id: <202410200959.49K9xpdc098946@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org From: Dimitry Andric Subject: git: 045150b2cda8 - 2024Q4 - multimedia/mjpegtools: fix build with clang 19 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/2024Q4 X-Git-Reftype: branch X-Git-Commit: 045150b2cda816ef0410ab12b6ce155369fd6dd4 Auto-Submitted: auto-generated The branch 2024Q4 has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=045150b2cda816ef0410ab12b6ce155369fd6dd4 commit 045150b2cda816ef0410ab12b6ce155369fd6dd4 Author: Dimitry Andric AuthorDate: 2024-10-06 09:50:53 +0000 Commit: Dimitry Andric CommitDate: 2024-10-20 09:59:39 +0000 multimedia/mjpegtools: fix build with clang 19 Clang 19 has become more strict about errors in member functions, which results in errors building multimedia/mjpegtools: ./Region2D.hh:439:13: error: no member named 'DoesContainPoint' in 'Region2D' 439 | || this->DoesContainPoint (rHere.m_tnY, tnX))) | ~~~~ ^ ./Region2D.hh:446:22: error: no member named 'Begin' in 'Region2D' 446 | for (itHere = this->Begin(); itHere != this->End(); ++itHere) | ~~~~ ^ ./Region2D.hh:446:47: error: no member named 'End' in 'Region2D' 446 | for (itHere = this->Begin(); itHere != this->End(); ++itHere) | ~~~~ ^ ./Region2D.hh:549:14: error: no member named 'DoesContainPoint' in 'Region2D' 549 | && !this->DoesContainPoint (rHere.m_tnY, tnX)) | ~~~~ ^ ./Region2D.hh:556:22: error: no member named 'Begin' in 'Region2D' 556 | for (itHere = this->Begin(); itHere != this->End(); ++itHere) | ~~~~ ^ ./Region2D.hh:556:47: error: no member named 'End' in 'Region2D' 556 | for (itHere = this->Begin(); itHere != this->End(); ++itHere) | ~~~~ ^ ./Region2D.hh:635:16: error: no member named 'DoesContainPoint' in 'Region2D' 635 | if (!(this->DoesContainPoint (rHere.m_tnY, tnX) | ~~~~ ^ ./Region2D.hh:643:22: error: no member named 'Begin' in 'Region2D' 643 | for (itHere = this->Begin(); itHere != this->End(); ++itHere) | ~~~~ ^ ./Region2D.hh:643:47: error: no member named 'End' in 'Region2D' 643 | for (itHere = this->Begin(); itHere != this->End(); ++itHere) | ~~~~ ^ The member functions `DoesContainPoint`, `Begin` and `End` are all commented out in Region2D.hh, probably because the code was never finished up properly. The member functions referencing them are also never used, so comment those out too, using `#if 0`, `#endif` pairs. PR: 281887 Approved by: maintainer timeout (2 weeks) MFH: 2024Q4 (cherry picked from commit 8cf728289caf3a06b225866707277d5ff170dff0) --- .../mjpegtools/files/patch-y4mdenoise_Region2D.hh | 34 ++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/multimedia/mjpegtools/files/patch-y4mdenoise_Region2D.hh b/multimedia/mjpegtools/files/patch-y4mdenoise_Region2D.hh new file mode 100644 index 000000000000..51d5f1420de8 --- /dev/null +++ b/multimedia/mjpegtools/files/patch-y4mdenoise_Region2D.hh @@ -0,0 +1,34 @@ +--- y4mdenoise/Region2D.hh.orig 2021-09-05 06:14:13 UTC ++++ y4mdenoise/Region2D.hh +@@ -404,6 +404,7 @@ Region2D::~Region2D() + + + ++#if 0 + // Add the given horizontal extent to the region. + template + template +@@ -480,6 +481,7 @@ error: + PrintRegion (a_rTemp); + assert (false); + } ++#endif + + + +@@ -513,6 +515,7 @@ Region2D::Union (Status_t &a_reStatus, + + + ++#if 0 + // Make the current region represent the union between itself + // and the other given region. + template +@@ -686,6 +689,7 @@ error: + PrintRegion (a_rTemp); + assert (false); + } ++#endif + + +