Re: git: c1cc8c5f75f6 - main - www/gitea: Update 1.22.2 → 1.22.3 (fixes security vulnerability)

Emanuel Haupt <ehaupt@FreeBSD.org> wrote:
> Vladimir Druzenko <vvd@FreeBSD.org> wrote:
> > The branch main has been updated by vvd:
> > 
> > URL:
> > https://cgit.FreeBSD.org/ports/commit/?id=c1cc8c5f75f6e85e544498d7dc52e6fe5e2be8e0
> > 
> > commit c1cc8c5f75f6e85e544498d7dc52e6fe5e2be8e0
> > Author:     Stefan Bethke <stb@lassitu.de>
> > AuthorDate: 2024-10-09 22:25:16 +0000
> > Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
> > CommitDate: 2024-10-09 22:29:50 +0000
> > 
> >     www/gitea: Update 1.22.2 → 1.22.3 (fixes security vulnerability)
> >     
> >     Changelog:
> >     https://github.com/go-gitea/gitea/releases/tag/v1.22.3
> >     
> >     `su -m` cause checking authorized_keys in wrong place - replace
> > it with `su`. 
> >     PR:     281949 281264
> >     MFH:    2024Q4
> 
> After this gitea fails to start:
> 
> # /usr/local/etc/rc.d/gitea start
> fatal: unrecognized command '/usr/local/sbin/gitea doctor check
> >/dev/null' cannot start gitea because of configuration errors. Run
>     su -m git -c 'gitea doctor check'
> for further details
> 
> Running: su -m git -c 'gitea doctor check' shows no errors.
> 

Patch:

--- patch starts here ---
diff --git a/www/gitea/Makefile b/www/gitea/Makefile
index 9d61421b0223..0ed8bb4eb040 100644
--- a/www/gitea/Makefile
+++ b/www/gitea/Makefile
@@ -1,6 +1,7 @@
 PORTNAME=      gitea
 DISTVERSIONPREFIX=     v
 DISTVERSION=   1.22.3
+PORTREVISION=  1
 CATEGORIES=    www
 MASTER_SITES=  https://github.com/go-gitea/gitea/releases/download/${DISTVERSIONPREFIX}${DISTVERSION}/ \
                https://dl.gitea.io/gitea/${DISTVERSION}/
diff --git a/www/gitea/files/gitea.in b/www/gitea/files/gitea.in
index 3b1814b25fb9..566a4b46ef93 100644
--- a/www/gitea/files/gitea.in
+++ b/www/gitea/files/gitea.in
@@ -52,7 +52,7 @@ gitea_start() {
 
 gitea_prestart() {
        if checkyesno gitea_configcheck_enable; then
-               if su ${gitea_user} -c "%%PREFIX%%/sbin/${name} doctor check >/dev/null"; then
+               if su -m ${gitea_user} -c "%%PREFIX%%/sbin/${name} doctor check >/dev/null"; then
                else
                        echo "cannot start ${name} because of configuration errors. Run" >&2
                        echo "    su -m git -c '${name} doctor check'" >&2
--- patch ends here ---