From nobody Fri Oct 04 03:34:41 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XKZ120Hpjz5XnCP for ; Fri, 04 Oct 2024 03:34:46 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-8fac.mail.infomaniak.ch (smtp-8fac.mail.infomaniak.ch [83.166.143.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XKZ1006Jbz4jhB for ; Fri, 4 Oct 2024 03:34:43 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=pyret.net header.s=20231006 header.b=kuz2Y3oD; spf=pass (mx1.freebsd.org: domain of daniel.engberg.lists@pyret.net designates 83.166.143.172 as permitted sender) smtp.mailfrom=daniel.engberg.lists@pyret.net; dmarc=pass (policy=reject) header.from=pyret.net Received: from smtp-3-0001.mail.infomaniak.ch (unknown [IPv6:2001:1600:4:17::246c]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4XKZ0x3ZbNzwXt; Fri, 4 Oct 2024 05:34:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1728012881; bh=NqXQ4My2o5ZCrh9X0vixTcbREeyXDwQeOj9SmnE5W3w=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=kuz2Y3oDXHmMcXEezedZfWQ6a2AlFEATFE10NSOoKNjJ+tY06jb8qxhXD7GC35XFz Flr5cd/U8BUtD0Y02NnWve3jK7SjtB5XV4YbIPjPdXr0IaNssvZenqHS0C2OLSUX5p c51I3fQYvi3ZTozuSouWlQmdO2IQFp85CkVYLg1l5tu0ZXJCyzpW7ziyEpxZg/aVwi iWWNt/iPx9ehbYKzuJJc9ORiQNjBUzaNGxTZY4OVO0jao8dDOQITlzPGYk0Mr/wbCV HPkYrq+pMoDaGxZ8UTqr0TX+SAs0iRN5ud1PQxIt/sc75cOSMeJ6JNxzx11L3VpM4u thgWjb2TiVBzw== Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4XKZ0x0czMz9M9; Fri, 4 Oct 2024 05:34:41 +0200 (CEST) Message-ID: <1c5e55cb722998c9eff8345c43853aee@mail.infomaniak.com> Date: Fri, 04 Oct 2024 05:34:41 +0200 Subject: Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port From: Daniel Engberg Reply-To: Daniel Engberg To: Pietro Cerutti Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1728012881_0bccc6606dae4cb387a80f3d40376d7d_=_" X-WS-User-Origin: eyJpdiI6IjhnNHRtOWFpbHc4ZE5GZ2E2OFpTNnc9PSIsInZhbHVlIjoidU1oMDlIQlArSTQrR1R3Slg4bnZ1dz09IiwibWFjIjoiZjJlNDRmMzNlZTRiNDk5NTI0NjMwNzM2NmRmYzMzZDFiMGU0MGJhMjkwNzFhY2UxYzM2ZTQ1YTc3MmQzODgwZiIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6ImNCQ1Rzbzc3bHRBRDZnQVNQUXVHbGc9PSIsInZhbHVlIjoiNFJVK2tOTXR3VE5OVnZUNkN5TDF0UT09IiwibWFjIjoiMWQ0NTcyYTJhNjE4Y2E5ZTBlNGI0Mzk3OTNjZGFkYjI2NjJmNmJjMDRhNWVkNzU0YjFlYjlkM2JiMjUwOTVmZSIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.757) References: <202410011223.491CNu6S051590@gitrepo.freebsd.org> <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75> In-Reply-To: <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75> X-Infomaniak-Routing: alpha X-Spamd-Result: default: False [-4.10 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[pyret.net,reject]; R_SPF_ALLOW(-0.20)[+ip4:83.166.143.168/29]; R_DKIM_ALLOW(-0.20)[pyret.net:s=20231006]; RWL_MAILSPIKE_GOOD(-0.10)[83.166.143.172:from]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:29222, ipnet:83.166.128.0/19, country:CH]; TO_DN_SOME(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@FreeBSD.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[pyret.net:+]; HAS_REPLYTO(0.00)[daniel.engberg.lists@pyret.net] X-Rspamd-Queue-Id: 4XKZ1006Jbz4jhB X-Spamd-Bar: ---- --_=_swift_1728012881_0bccc6606dae4cb387a80f3d40376d7d_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-10-02T09:21:13.000+02:00, Pietro Cerutti wrote= : >=C2=A0On=C2=A0Oct=C2=A001=C2=A02024,=C2=A017:04=C2=A0+0000,=C2= =A0Daniel=C2=A0Engberg=C2=A0=C2=A0wrote: = >>=C2=A0=C2=A0Please=C2=A0review=C2=A0Porters=C2=A0Handbook,=C2=A0there= =C2=A0are=C2=A0several=C2=A0"guidelines"=C2=A0to >>=C2=A0=C2=A0make >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0the=C2=A0tree=C2=A0more=C2=A0consistent=C2= =A0and=C2=A0reducing=C2=A0overall=C2=A0workload. >=C2=A0 >=C2=A0I=C2= =A0have=C2=A0pushed=C2=A0a=C2=A0few=C2=A0cleanups=C2=A0in >=C2=A0771ce859= 9db53660f3aa7c1e31dba1c87852586c. Thanks! >>>=C2=A0=C2=A0=C2= =A0PORTVERSION=C2=A0-->=C2=A0DISTVERSION >>=C2=A0=C2=A0 >>=C2=A0=C2= =A0https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master= _sites-github >>=C2=A0=C2=A0 >>=C2=A0=C2=A0...and=C2=A0stray(?)=C2= =A0comment? >=C2=A0 >=C2=A0Thanks,=C2=A0corrected. >=C2=A0 >>=C2= =A0=C2=A0Correct=C2=A0maintainer?=C2=A0There's=C2=A0no=C2=A0reference=C2= =A0and=C2=A0from=C2=A0what=C2=A0I=C2=A0can=C2=A0tell >>=C2=A0=C2=A0no >= >=C2=A0=C2=A0 >>=C2=A0=C2=A0submitted=C2=A0PR=C2=A0in=C2=A0Bugzilla. >= =C2=A0 >=C2=A0The=C2=A0maintainer=C2=A0is=C2=A0correct.=C2=A0It's=C2= =A0a=C2=A0person=C2=A0I=C2=A0know=C2=A0and=C2=A0the=C2=A0port=C2=A0was= =C2=A0 >=C2=A0 >=C2=A0submitted=C2=A0to=C2=A0me=C2=A0privately.=C2= =A0I=C2=A0didn't=C2=A0think=C2=A0anyone=C2=A0would=C2=A0want=C2=A0it=C2= =A0 >=C2=A0 >=C2=A0publicized=C2=A0it=C2=A0in=C2=A0the=C2=A0commit= =C2=A0message. Just add something like "submitted via private email" o= r something similar so it's clear of origin >>=C2=A0=C2=A0libxml2= =C2=A0dependency=C2=A0should=C2=A0use=C2=A0the=C2=A0GNOME=C2=A0helper >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0https://docs.freebsd.org/en/books/porters-hand= book/book/#using-gnome >>=C2=A0=C2=A0 >>=C2=A0=C2=A0https://docs.freebs= d.org/en/books/porters-handbook/book/#gnome-components >>=C2=A0=C2=A0 >= >=C2=A0=C2=A0sqlite3=C2=A0dependency=C2=A0should=C2=A0also=C2=A0use=C2= =A0a=C2=A0helper >>=C2=A0=C2=A0 >>=C2=A0=C2=A0https://docs.freebsd.org/= en/books/porters-handbook/book/#using-databases-uses >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0CMAKE_ARGS=C2=A0can=C2=A0be=C2=A0replaced=C2=A0with=C2=A0CMAKE_= OFF=3D=C2=A0ENABLE_PYTHON >>=C2=A0=C2=A0 >>=C2=A0=C2=A0https://docs.fre= ebsd.org/en/books/porters-handbook/book/#using-cmake >=C2=A0 >=C2=A0Tha= nks,=C2=A0corrected. >=C2=A0 >>=C2=A0=C2=A0do-test=C2=A0section=C2= =A0can=C2=A0be=C2=A0replaced=C2=A0with=C2=A0USES=3D=C2=A0cmake:testing >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0https://cgit.freebsd.org/ports/tree/Mk/Uses/cm= ake.mk#n20 >=C2=A0 >=C2=A0I=C2=A0wasn't=C2=A0able=C2=A0to=C2=A0do=C2= =A0it=C2=A0with=C2=A0cmake:testing.=C2=A0Were=C2=A0you? Upstream uses = from what I can tell an rather old approach for test target, https:/= /github.com/rpm-software-management/createrepo_c/blob/master/CMakeLists.txt= #L160 The "EXCLUDE FROM ALL" part is what causes the issue >>= =C2=A0=C2=A0Poudriere=C2=A0also=C2=A0lists=C2=A0quite=C2=A0a=C2=A0few=C2= =A0warnings=C2=A0about=C2=A0dependencies=C2=A0and >>=C2=A0=C2=A0the >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0REINPLACE_CMD=C2=A0commands.=C2=A0 >>=C2= =A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0https://pdr2.bofh.network/data/141-diizzy/= 2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log >=C2=A0 >=C2=A0Nice.= =C2=A0I=C2=A0wasn't=C2=A0aware=C2=A0of=C2=A0poudriere's=C2=A0Q/A=C2=A0phase= .=C2=A0I=C2=A0used=C2=A0poudriere=C2=A0bulk >=C2=A0to=C2=A0 >=C2=A0 >= =C2=A0test=C2=A0the=C2=A0port=C2=A0but=C2=A0I=C2=A0don't=C2=A0see=C2=A0that= =C2=A0in=C2=A0my=C2=A0logs.=C2=A0How=C2=A0do=C2=A0I=C2=A0enable=C2=A0it? = >=C2=A0 >=C2=A0https://gahr.ch/poudriere/logs/bulk/14amd64-dev/2024-10-01= _12h26m54s/logs/createrepo_c-1.1.4.log >=C2=A0 >=C2=A0Also,=C2=A0I= =C2=A0have=C2=A0run=C2=A0`portlint=C2=A0-AC`=C2=A0multiple=C2=A0times=C2= =A0as=C2=A0I=C2=A0was=C2=A0reviewing >=C2=A0the=C2=A0 >=C2=A0 >=C2= =A0port,=C2=A0and=C2=A0it=C2=A0was=C2=A0happy=C2=A0with=C2=A0what=C2=A0I= =C2=A0had. >=C2=A0 >=C2=A0Yeah,=C2=A0I=C2=A0should=C2=A0skim=C2=A0throu= gh=C2=A0the=C2=A0handbook=C2=A0once=C2=A0in=C2=A0a=C2=A0while.=C2=A0I've= =C2=A0been=C2=A0 >=C2=A0 >=C2=A0doing=C2=A0ports=C2=A0for=C2=A0a=C2= =A0long=C2=A0time=C2=A0and=C2=A0I=C2=A0am=C2=A0probably=C2=A0missing=C2= =A0out=C2=A0on=C2=A0the >=C2=A0latest=C2=A0 >=C2=A0 >=C2=A0enhancemen= ts=C2=A0and=C2=A0developments. >=C2=A0 >>=C2=A0=C2=A0It=C2=A0also=C2= =A0seems=C2=A0to=C2=A0look=C2=A0for=C2=A0Doxygen=C2=A0by=C2=A0default >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0which=C2=A0you=C2=A0probably=C2=A0want=C2= =A0to=C2=A0disable=C2=A0to=C2=A0avoid=C2=A0potential=C2=A0plist >>=C2= =A0=C2=A0issues. >=C2=A0 >=C2=A0Well,=C2=A0they=C2=A0don't=C2=A0provide= =C2=A0a=C2=A0way=C2=A0to=C2=A0turn=C2=A0off=C2=A0docs,=C2=A0but=C2=A0I= =C2=A0don't=C2=A0see=C2=A0an=C2=A0 >=C2=A0 >=C2=A0issue=C2=A0with=C2= =A0it=C2=A0building=C2=A0docs=C2=A0if=C2=A0it=C2=A0finds=C2=A0doxygen.= =C2=A0We=C2=A0won't=C2=A0be >=C2=A0installing=C2=A0 >=C2=A0 >=C2= =A0them=C2=A0anyway. https://cmake.org/cmake/help/latest/variable/CMAK= E_DISABLE_FIND_PACKAGE_PackageName.html works :-) >=C2=A0--=C2=A0 = >=C2=A0 >=C2=A0Pietro=C2=A0Cerutti >=C2=A0 >=C2=A0I=C2=A0have=C2= =A0pledged=C2=A0to=C2=A0give=C2=A010%=C2=A0of=C2=A0income=C2=A0to=C2=A0effe= ctive=C2=A0charities >=C2=A0 >=C2=A0and=C2=A0invite=C2=A0you=C2=A0to= =C2=A0join=C2=A0me=C2=A0-=C2=A0https://givingwhatwecan.org I've hacked= together a patch doing the final cleanups which fixes the Q/A issues. = I've also left a comment in one of the submitted PRs as it breaks buil= d if optional dependencies are disabled. https://pdr2.bofh.network/dat= a/141-diizzy/2024-10-03_21h47m26s/logs/createrepo_c-1.1.4.log (testport)= https://pdr2.bofh.network/data/133-diizzy/2024-10-03_22h05m43s/logs/c= reaterepo_c-1.1.4.log (bulk) Not sure why your Podriere doesn't run = QA on bulk builds :-/ Patch: https://projects.pyret.net/files/fre= ebsd-patches/createrepo_c-improve.patch Best regards, Daniel = --_=_swift_1728012881_0bccc6606dae4cb387a80f3d40376d7d_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-10-02T09:21:13.000+02:00, Pietro Cerut= ti <gahr@FreeBSD.org> wrote:
On Oct 01 2024, 17:04 +0000, Daniel Engberg <daniel.=
engberg.lists@pyret.net> wrote:
 Please review Porters Handbook, there are several "guidelines"=
 to make
the tree more consistent and reducing overall worklo=
ad.
 
I have pushed a few cleanups=
 in 771ce8599db53660f3aa7c1e31dba1c87852586c.
<= /div>
Thanks!
PORTVERSION --> DISTVER= SION


...and stray(?) commen= t?

Thanks, corrected.
<= div>
Correct maintainer? T= here's no reference and from what I can tell no
submitted PR = in Bugzilla.

The maintainer is c= orrect. It's a person I know and the port was
submitted to m= e privately. I didn't think anyone would want it
publicized = it in the commit message.


 =
libxml2 dependency should use the GNOME helper

https://docs.freebsd.org/en/books/porters-handboo=
k/book/#using-gnome


sqlite3 dependency should also use = a helper



htt= ps://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake

Thanks, corrected.

=
do-test section can be replac= ed with USES=3D cmake:testing


I wasn't able to do it with cmake:testing. Were y= ou?
Upstream uses from w= hat I can tell an rather old approach for test target,
= The "EXCLUDE FROM ALL" part is what causes the issue


<= div>
Poudriere also lists = quite a few warnings about dependencies and the
REINPLACE_CMD= commands.
https://pdr2.bofh.network/data/141-diizzy/2024-= 10-01_11h36m29s/logs/createrepo_c-1.1.4.log

Nice. I wasn't aware of poudriere's Q/A phase. I use= d poudriere bulk to
test the port but I don't see that in my= logs. How do I enable it?

A= lso, I have run `portlint -AC` multiple times as I was reviewing the
port, and it was happy with what I had.

Yeah, I should skim through the handbook once in a while. I've been
=
doing ports for a long time and I am probably missing out on the= latest
enhancements and developments.

It also seems to look for Doxyge= n by default
which you probably want to disable to avoid pote= ntial plist issues.

Well, they d= on't provide a way to turn off docs, but I don't see an
issu= e with it building docs if it finds doxygen. We won't be installing
them anyway.


-- 
Pietro Cerutti
I have pledged to give 10% of income t=
o effective charities
and invite you to join me - https://givingwhatwecan.=
org
I've hacked toge= ther a patch doing the final cleanups which fixes the Q/A issues.
=
I've also left a comment in one of the submitted PRs as it= breaks build if optional dependencies are disabled.


N= ot sure why your Podriere doesn't run QA on bulk builds :-/

Patch:

Best reg= ards,
Daniel

= --_=_swift_1728012881_0bccc6606dae4cb387a80f3d40376d7d_=_--