From nobody Wed Oct 02 07:21:13 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XJR7M0ltLz5Y68r; Wed, 02 Oct 2024 07:21:19 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XJR7M01Qvz4gC1; Wed, 2 Oct 2024 07:21:19 +0000 (UTC) (envelope-from gahr@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727853679; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=P4zmGFVxN4YgURN8zeYxn+PU4QFLIsTuWws4EZpYe9Q=; b=h0TM5hf04Nfz+Ol+R2lgU3dFOFIxMWb4kqF7v7wgdWGLdmjK02vUpL5G6fQmqCzK6Bm1KT KNwmQl+7XMo4rcoS/PP3ge7BdzZB8mlxGUWsi1TThss2wdRJrS3pW7KVfgj/1R7PAqGLsH DeIk9Om0xUbZ8Oe9MMavQdD1LbXbO+H8gXIsaAjtRc32h+3Hpx1bJfywlBPwuiWc11AkdX LSFISVPwCouZ9L6HV+r+faqhG9noT+U56wyEwpfGLAhfOGvAnwcvuvjX5kjqhYesmxWG5f xNd/iNFjR+t/ACKK1GzeELShDlhNfgS7fimRp0q0SEW14fY2pcDo2CJqRKdPNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727853679; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=P4zmGFVxN4YgURN8zeYxn+PU4QFLIsTuWws4EZpYe9Q=; b=dLcYyQEnoe0Ei+HMpGbtYvvmmM3kqQHv7zPOxBSNj3ZtqHwZ2pbuUXeBzl+u+LFE2I7yNN L4KxVYpnxGzt76xMROHdjehQNtqsUWqFVqIQHyAjhdpAkXFeAQltK/KZqnkmxKJCxYT6Pa zpq0hsscgKIkoY7mEUHCVLhpHylFTZuKTmKiPL+pa15hPeAV9qpuoVTxuYWHdu5x67rODI nYQYjfTdjmtrh1Xq91RcpcRyEvfVNnmROsz937aGInDaDVYsPKvGERWSTTD1Y/qzekqiWI wrFgqxdkMcVNyfU4pG8lDQdfk49RLs8O6zthLo6WDCCdMNp6GBdymQkRI+rQgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727853679; a=rsa-sha256; cv=none; b=inzzsSbkoXM9S8JbCwwlR8PtpUOrMO1XXopLdn4nIOWsL14JEMhSy7Q+OeX8pI6PWkWf0p +x5qSsIw92FLvIOoH/1HgsXms/by6ufSlspYghlMekEyLfyEM5THX29G/2aKY7E2WvIb+S EWqWazviQHetOrA9YdibXfmNTxBIjn96oN3CA9Py9uLSFmCIkbVHxPZ4NEJDkvYSqrAveP MB+YL8Gd4i32V5c3yrc75WkzcrtdzGTLmZtHVelxnU+ITEiMasXq9n15tFtp1q2hh9Yx/5 9gW3A8VS9yb4eN02pZ+lgIyZTyB4FNMPuOZcXzt54gLI6pb/XOJ/H2yWR3T6pQ== Received: from ptrcrt.ch (ptrcrt.ch [IPv6:2a02:2770:8:0:21a:4aff:fe7e:c6be]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gahr/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XJR7L3WvFz1Rpm; Wed, 2 Oct 2024 07:21:18 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Date: Wed, 2 Oct 2024 07:21:13 +0000 From: Pietro Cerutti To: Daniel Engberg Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port Message-ID: <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75> Reply-To: Pietro Cerutti References: <202410011223.491CNu6S051590@gitrepo.freebsd.org> <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> User-Agent: NeoMutt/20240425-127-771158 On Oct 01 2024, 17:04 +0000, Daniel Engberg wrote: >Please review Porters Handbook, there are several "guidelines" to make >the tree more consistent and reducing overall workload. I have pushed a few cleanups in 771ce8599db53660f3aa7c1e31dba1c87852586c. > >PORTVERSION --> DISTVERSION > >https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github > >...and stray(?) comment? Thanks, corrected. >Correct maintainer? There's no reference and from what I can tell no >submitted PR in Bugzilla. The maintainer is correct. It's a person I know and the port was submitted to me privately. I didn't think anyone would want it publicized it in the commit message. >libxml2 dependency should use the GNOME helper > >https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome > >https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-components > >sqlite3 dependency should also use a helper > >https://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses > >CMAKE_ARGS can be replaced with CMAKE_OFF= ENABLE_PYTHON > >https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake Thanks, corrected. >do-test section can be replaced with USES= cmake:testing > >https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20 I wasn't able to do it with cmake:testing. Were you? >Poudriere also lists quite a few warnings about dependencies and the >REINPLACE_CMD commands. >>https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log Nice. I wasn't aware of poudriere's Q/A phase. I used poudriere bulk to test the port but I don't see that in my logs. How do I enable it? https://gahr.ch/poudriere/logs/bulk/14amd64-dev/2024-10-01_12h26m54s/logs/createrepo_c-1.1.4.log Also, I have run `portlint -AC` multiple times as I was reviewing the port, and it was happy with what I had. Yeah, I should skim through the handbook once in a while. I've been doing ports for a long time and I am probably missing out on the latest enhancements and developments. >It also seems to look for Doxygen by default >which you probably want to disable to avoid potential plist issues. Well, they don't provide a way to turn off docs, but I don't see an issue with it building docs if it finds doxygen. We won't be installing them anyway. -- Pietro Cerutti I have pledged to give 10% of income to effective charities and invite you to join me - https://givingwhatwecan.org