Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Tue, 01 Oct 2024 17:04:42 UTC
On 2024-10-01T14:23:56.000+02:00, Pietro Cerutti <gahr@FreeBSD.org>
wrote:

> The branch main has been updated by gahr:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=2ba4ed91621e5f7054224acda61afed58cb380b1
> 
> commit 2ba4ed91621e5f7054224acda61afed58cb380b1
> 
> Author:     Pietro Cerutti <gahr@FreeBSD.org>
> 
> AuthorDate: 2024-10-01 12:22:30 +0000
> 
> Commit:     Pietro Cerutti <gahr@FreeBSD.org>
> 
> CommitDate: 2024-10-01 12:23:54 +0000
> 
>     sysutils/createrepo_c: new port
> 
>     
> 
>     createrepo_c is a C implementation of the createrepo tool, which generates
> 
>     metadata for RPM package repositories. It is optimized for performance and
> 
>     provides new features compared to the original createrepo written in Python.

....

Hi,

Please review Porters Handbook, there are several "guidelines" to make
the tree more consistent and reducing overall workload.

PORTVERSION --> DISTVERSION

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

...and stray(?) comment?

Correct maintainer? There's no reference and from what I can tell no
submitted PR in Bugzilla.

libxml2 dependency should use the GNOME helper

https://docs.freebsd.org/en/books/porters-handbook/book/#using-gnome

https://docs.freebsd.org/en/books/porters-handbook/book/#gnome-components

sqlite3 dependency should also use a helper

https://docs.freebsd.org/en/books/porters-handbook/book/#using-databases-uses

CMAKE_ARGS can be replaced with CMAKE_OFF= ENABLE_PYTHON

https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake

do-test section can be replaced with USES= cmake:testing

https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20

You also seem to have submitted changes upstream (great initiative,
please add a note about in the commit msg next time), these can
probably apply these using this method to clean up the Makefile
further.

https://cgit.freebsd.org/ports/tree/irc/irssi/Makefile?id=ef1857fc1c757152f595dd87121d260f6e3fb25d#n7

Poudriere also lists quite a few warnings about dependencies and the
REINPLACE_CMD commands. It also seems to look for Doxygen by default
which you probably want to disable to avoid potential plist issues.

https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/createrepo_c-1.1.4.log

Best regards,

Daniel