Re: git: ffac4f7ebb89 - main - science/nwchem: Fix extremely slow build time due to gmake-4.4.1 issues

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Fri, 29 Mar 2024 20:07:43 UTC 
On 2024-03-29T20:36:29.000+01:00, Yuri Victorovich <yuri@FreeBSD.org> wrote:
>  The branch main has been updated by yuri:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=ffac4f7ebb89f9ecd885d633a5a860254040257c
> 
> commit ffac4f7ebb89f9ecd885d633a5a860254040257c
> Author:     Yuri Victorovich <yuri@FreeBSD.org>
> AuthorDate: 2024-03-29 19:33:36 +0000
> Commit:     Yuri Victorovich <yuri@FreeBSD.org>
> CommitDate: 2024-03-29 19:36:23 +0000
> 
>     science/nwchem: Fix extremely slow build time due to gmake-4.4.1 issues
>     
>     Switched back to gmake-4.3
> ---
>  science/nwchem/Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/science/nwchem/Makefile b/science/nwchem/Makefile
> index b1b6bbeea975..639b8987e8ac 100644
> --- a/science/nwchem/Makefile
> +++ b/science/nwchem/Makefile
> @@ -30,9 +30,14 @@ LIB_DEPENDS=	libblas.so:math/blas \
>  RUN_DEPENDS=	nwchem-data>0:science/nwchem-data
>  TEST_DEPENDS=	bash:shells/bash
>  
> -USES=		fortran gettext-runtime gmake perl5 pkgconfig
> +USES=		fortran gettext-runtime perl5 pkgconfig # gmake is temporarily removed, see https://savannah.gnu.org/bugs/?65533
>  USE_PERL5=	build
>  
> +# use gmake-4.3, see https://savannah.gnu.org/bugs/?65533
> +BUILD_DEPENDS+=	gmake43>0:devel/gmake43
> +CONFIGURE_ENV+=	MAKE=gmake
> +MAKE_CMD=	gmake
> +
>  USE_GITHUB=	yes
 GH_ACCOUNT=	nwchemgit

Hi,

With all due respect this is not how we should solve edge cases. While nwchem has been slow to build for a few days you reported to upstream (both gmake and nwchem) only a few hours ago [1]. There's also a newer version of nwchem available [2], this should've preferably been the first thing to test even if it's unlikely to fix the issue in this case. Even so, why the rush? The commit message for adding back gmake 4.3 does not mention anything about contacting the maintainer. Please refrain from committing ports on behalf of others without their consent. Wait for the maintainer to get back to you and if it's an emergency use a local tree or overlays in Poudriere temporarily while people are trying to work out the issue and a potential solution.

1: https://github.com/nwchemgit/nwchem/issues/959
https://savannah.gnu.org/bugs/?65533
2: https://github.com/nwchemgit/nwchem/releases/tag/v7.2.2-release

Best regards,
Daniel (diizzy@)