Re: git: d79ba67c4595 - main - devel/phorgeit-arcanist-lib: New port

Hi,

Thanks for pointing out that I removed that line by accident, fixed.

Portversion is because this is the date this port was actually done.

The remaining issues will be addressed (if required) asap, definitely before cutting 2024Q2 (this was based on existing ports and is not perfect yet). I might fix the existing ports as well while I’m there.

Are you wearing any hat or is this due to a personal interest in the quality of the ports tree (good!) or specifically my commits (which would be weird)?

Again, thanks for pointing out the removed line, shouldn’t have happened.

Cheers




> On 24. Mar 2024, at 12:10, Daniel Engberg <daniel.engberg.lists@pyret.net> wrote:
> 
> Hi,
> 
> Why did this remove "- SUBDIR += php-Psr_Log" in devel/Makefile ?
> 
> Please follow Porters Handbook when it comes to versioning and usage of variables.
> 
> Commit refers to https://github.com/phorgeit/arcanist/commit/174bf094ef9fe26770903c912cf29b6c78760b26 which was committed, Date: Wed, 28 Feb 2024 12:29:14 +0100
> 
> Why does PORTVERSION say 20240304?
> Upstream uses tags so utilize those and do backports of needed unless you never intend to follow upstream, in that case you should use commit date and prefix g.
> See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github
> 
> Use DISTVERSION whenever possible as shown in examples. please use the same length of commits when using GH_TAGNAME as shown in Porters Handbook.
> 
> Best regards,
> Daniel