Re: git: 021fcd36af22 - main - games/coffeebreak: Move man pages to share/man

From: Nuno Teixeira <eduardo_at_freebsd.org>
Date: Mon, 11 Mar 2024 11:07:41 UTC
Fixed in 1128357fc9df commit.

Thanks all,

Alexey Dokuchaev <danfe@freebsd.org> escreveu (segunda, 11/03/2024 à(s) 02:17):
>
> On Sun, Mar 10, 2024 at 09:31:19PM +0100, Mathieu Arnold wrote:
> > On Sun, Mar 10, 2024 at 08:33:55PM +0300, Vladimir Druzenko wrote:
> > > 10.03.2024 18:55, Alexey Dokuchaev пишет:
> > > > On Sun, Mar 10, 2024 at 10:47:07AM +0000, Nuno Teixeira wrote:
> > > > > (...)
> > > > >
> > > > > Works fine:
> > > > >
> > > > > +MAKE_ARGS=     PREFIX=${PREFIX} MANDIR=${STAGEDIR}${PREFIX}/share/man
> > > > >
> > > > > What do you think? This way it is nicely simplified without patch
> > > > > or sed.
> > > >
> > > > Yes, this is what I had in mind.
> > >
> > > I tested same for other ports - doesn't work if Makefile have line:
> > > MANDIR= XXX but work if it have: MANDIR?= XXX
>
> You don't have to *test* this as it were some kind of magic, this is
> well known and documented make(1) behaviour.  Could you be confusing
> with MAKE_ENV perhaps?
>
> > Variables passed as arguments will override variables set with = or ?=
> > Variables in the environemnt will override variables set with ?=
>
> Right.  Alas, apparently this is still needs to be explained even to
> some seasoned ports committers. :-/
>
> ./danfe



-- 
Nuno Teixeira
FreeBSD Committer (ports)