Re: git: 450aafcba559 - main - textproc/tinyxml2: Update to 10.0.0

On Fri, Feb 23, 2024 at 5:23 AM Daniel Engberg <
daniel.engberg.lists@pyret.net> wrote:

> On 2024-02-21T16:20:08.000+01:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> wrote:
>
> The branch main has been updated by sunpoet:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=450aafcba559f95c94c5f195d83b5fe4fdc3748a
>
> commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a
> Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> AuthorDate: 2024-02-21 14:29:27 +0000
> Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> CommitDate: 2024-02-21 15:06:47 +0000
>
>     textproc/tinyxml2: Update to 10.0.0
>
>     - Convert to meson
>     - Fix 0c022f0fc854184d95ff3303049a063a39b1f551
>     - Bump PORTREVISION for package change
>     - Bump PORTREVISION of dependent ports for shlib change
>     - Remove duplicate PORTREVISION from math/linbox
>
>     Changes:        https://github.com/leethomason/tinyxml2/releases
>                     https://github.com/leethomason/tinyxml2/commits/master
> ---
>
> Hi,
>
> Please explain what you fixed as this change makes consumers utilizing
> CMake to find (lib)tinyxml2 now requiring patching when they worked fine
> before your change?
>
> Your patch for net/ecal is not a fix but a workaround for something that
> broke by this commit.
>
> Here's a build log of said port and the PR related.
>
> https://pdr2.bofh.network/data/132-diizzy/2024-01-01_11h58m45s/logs/ecal-5.12.1_3.log
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277227
>
> Best regards,
> Daniel
>

Hello,

Obviously you did not handle the dependent ports which encounter shlib
change.

Enforce port A to use cmake because port B uses cmake.
This behavior is toxic. It works like a virus.

Regarding net/ecal, please explicitly point out what is the broken
in net/ecal.
If you mean something like "(ecal-5.12.1_3)
/wrkdirs/usr/ports/net/ecal/work/stage//usr/local/bin/ecal_mon_gui-5.12.1 -
required shared library libCustomQt.so not found", I see nothing related
with tinyxml2's cmake script.
Not to mention that I see the same message when tinyxml2 is built with
cmake.

The cmake problem is misleading information.

Regards,
sunpoet