Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG
- Reply: Mathieu Arnold : "Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG"
- Reply: Mathieu Arnold : "Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG"
- In reply to: Mathieu Arnold : "Re: git: a995b8b0ab54 - main - multimedia/{mplayer/mencoder}: Move DEBUG from OPTIONS to WITH_DEBUG"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 03 Mar 2024 09:01:41 UTC
On Sun, Mar 3, 2024 at 11:56 AM Mathieu Arnold <mat@freebsd.org> wrote: > > There is no trend, it's a rule, debug must be handled with WITH_DEBUG > knob, and not via an option. > If there is an option that enable some sort of debugging or verbose > thing but that is not supposed to add debugging symbols, then it should > not be called DEBUG. In that case we need a qa check that prevents adding DEBUG option and then we can also introduce a generic DEBUG_VAR helper to get rid of ifdefs?