Re: git: 12594e1aee7b - main - math/mathex: new port, C++ library to parse/evaluate mathematical expressions
Date: Fri, 21 Jun 2024 21:41:49 UTC
On 2024-06-21T22:05:41.000+02:00, Thierry Thomas <thierry@freebsd.org> wrote: > Le ven. 21 juin 24 à 15:42:24 +0200, Daniel Engberg <daniel.engberg.lists@pyret.net> > > écrivait : > >> The only consumer (not linked?) uses CMake too so I don't see >> that >> >> much of a concern? > > Maybe, but I prefer the classical way. > >> Here's a poc with prefix(ed) examples,matching comment (there a >> typo) >> >> and pkg-descr (slightly altered). > > Thanks, I’ve just fixed them! There's still a typo in COMMENT, "C++ library fo" >> Plist is also fixed when EXAMPLES are disabled (needs to be >> patched >> >> either way). > > Do you build it with some unclean environment? It fails using both ports (14.0, amd64) and Poudriere ... math_mathex_UNSET= EXAMPLES ... --> https://pdr2.bofh.network/data/132-diizzy/mathex-no-examples/logs/errors/mathex-0.3.b.log Consider using the OPTIONS_SUB helper which makes it much easier https://docs.freebsd.org/en/books/porters-handbook/book/#options_sub Please also at least prefix the binaries (examples) as they have with very generic names both in terms of figuring out what package they belong to and would clash if more ports would use the same approach (see security/mbedtls for example) > Regards. > > -- > > Th. Thomas. Best regards, Daniel