From nobody Sun Jul 21 09:07:46 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WRcxy3f8mz5R6Q6 for ; Sun, 21 Jul 2024 09:07:50 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-bc0e.mail.infomaniak.ch (smtp-bc0e.mail.infomaniak.ch [45.157.188.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WRcxw5lYVz4rHd for ; Sun, 21 Jul 2024 09:07:48 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=pyret.net header.s=20231006 header.b=VTi4BcX7; dmarc=pass (policy=reject) header.from=pyret.net; spf=pass (mx1.freebsd.org: domain of daniel.engberg.lists@pyret.net designates 45.157.188.14 as permitted sender) smtp.mailfrom=daniel.engberg.lists@pyret.net Received: from smtp-3-0000.mail.infomaniak.ch (smtp-3-0000.mail.infomaniak.ch [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4WRcxt5ThCzt4S; Sun, 21 Jul 2024 11:07:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1721552866; bh=JuyWXIV3BE3Erh6hNrtubuXdItPYOAWTcQktPtMY0tU=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=VTi4BcX7pRZSxm2GrVR69S2e9h8JoWxOnljdtML2ezV4NYtU6VRctD1axzaBDhmMv lODdAEJz/QO5PXeAS6Sr88WYfL01ymsa3N4xET3vp1KOVBDIDHrwCDenJlQs1aEAvR 9otKmPS5WjYljwcJPVRx9MQl2BXsh0M/GWmhv13JHXLssxreB+3FBs9TI94+H9nBPW 9cYv8EpZk8xjZkMxSY4uWi7eO7e/IDl+JIbnjsp4+KjH1uYUS/z4QnGTw1DARe445r eDyT1RLgG1xBgjJpQN5xF5brRKWnrmAfGBOmJwd2XjlKNJiza3ehkDqpNjzG1DVr0f 4YRfAte2dcUEA== Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4WRcxt2pM8zH20; Sun, 21 Jul 2024 11:07:46 +0200 (CEST) Message-ID: <4f2ce2b474bd4d522adbf277c3418393@mail.infomaniak.com> Date: Sun, 21 Jul 2024 11:07:46 +0200 Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code From: Daniel Engberg Reply-To: Daniel Engberg To: Mathieu Arnold Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin , "arrowd@FreeBSD.org" List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1721552866_4dce2c21be23c5add0b4c983a8fecfb2_=_" X-WS-User-Origin: eyJpdiI6InRuQ1JQWmxDbDVRMnBQU3I5cUJGTlE9PSIsInZhbHVlIjoiMTdxSnFrQlJLeEQxQUp3Z1JFZmZWQT09IiwibWFjIjoiMzMzYzUxMjQ2NzExYzYzZDA1MzFmZWMyMmZhYmMxMDI1MGZhMTRhMTQ1ZjJiMDE0ZDBlZTgwMWUxMzljYWRkMiIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6IlROdHZMcVZGZm10bkw5RU9nUkQvckE9PSIsInZhbHVlIjoiWkhvbDJmcGFCTStOMVBXamswdEVZUT09IiwibWFjIjoiYTU1MWRkYzE4NjZiODRmNTZmMTdmNmJiNWU5OTBkMjRhMTM1OTIzOTYzOWVhNjM4NDM3ZDE4OGZlY2Q2ZWY2NCIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.719) References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> <4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k@637dblgngbon> In-Reply-To: X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.19 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.990]; DMARC_POLICY_ALLOW(-0.50)[pyret.net,reject]; R_DKIM_ALLOW(-0.20)[pyret.net:s=20231006]; R_SPF_ALLOW(-0.20)[+ip4:45.157.188.8/29]; RWL_MAILSPIKE_GOOD(-0.10)[45.157.188.14:from]; RCVD_IN_DNSWL_LOW(-0.10)[45.157.188.14:from]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:29222, ipnet:45.157.188.0/22, country:CH]; TO_DN_EQ_ADDR_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[pyret.net:+]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; HAS_REPLYTO(0.00)[daniel.engberg.lists@pyret.net]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Queue-Id: 4WRcxw5lYVz4rHd --_=_swift_1721552866_4dce2c21be23c5add0b4c983a8fecfb2_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-07-13T18:49:27.000+02:00, Daniel Engberg wrote: >=C2=A0On=C2=A02024-07-13T16:30:31.000+02:00,=C2=A0Mat= hieu=C2=A0Arnold=C2=A0 >=C2=A0 >=C2=A0wrote: >=C2= =A0 >>=C2=A0=C2=A0On=C2=A0Sat,=C2=A0Jul=C2=A013,=C2=A02024=C2=A0at=C2= =A002:04:48PM=C2=A0GMT,=C2=A0Daniel=C2=A0Engberg=C2=A0wrote: >>=C2=A0= =C2=A0 >>>=C2=A0=C2=A0=C2=A0On=C2=A02024-07-13T08:47:47.000+02:00,=C2= =A0Mathieu=C2=A0Arnold >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0= =C2=A0 >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0= =C2=A0wrote: >>>=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0On=C2= =A0Sat,=C2=A0Jul=C2=A013,=C2=A02024=C2=A0at=C2=A006:11:04AM=C2=A0GMT,=C2= =A0Daniel=C2=A0Engberg=C2=A0wrote: >>>>=C2=A0=C2=A0=C2=A0=C2=A0 >>>>>= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Hi, >>>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >= >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0This=C2=A0changes=C2=A0so=C2=A0LTO= =C2=A0option=C2=A0is=C2=A0no=C2=A0longer=C2=A0applied=C2=A0to=C2=A0Rust >= >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >>>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0(cargo) >>>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >>>>>=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0ports >>>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >>>>>= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0BY=C2=A0DEFAULT=C2=A0causing=C2=A0a= =C2=A0regresssion,=C2=A0please=C2=A0fix. >>>>=C2=A0=C2=A0=C2=A0=C2=A0 >= >>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0As=C2=A0it=C2=A0has=C2=A0been=C2=A0three= =C2=A0months,=C2=A0nobody=C2=A0complained=C2=A0something=C2=A0was >>>>= =C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0broken >>>>= =C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0so, >>>>= =C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0I=C2=A0don't= =C2=A0think=C2=A0anything=C2=A0is=C2=A0actually=C2=A0broken. >>>>=C2= =A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0LTO=C2=A0as=C2= =A0are=C2=A0a=C2=A0few=C2=A0other=C2=A0features=C2=A0like=C2=A0SSP=C2=A0are= =C2=A0user=C2=A0facing >>>>=C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0features, >>>>=C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0not=C2=A0a >>>>=C2=A0=C2=A0=C2=A0=C2=A0 >>>>= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0porters=C2=A0facing=C2=A0options,=C2=A0it= =C2=A0means,=C2=A0it's=C2=A0up=C2=A0to=C2=A0the=C2=A0person=C2=A0doing >>= >>=C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0the >>>>= =C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0building=C2= =A0to=C2=A0choose=C2=A0wether=C2=A0to=C2=A0enable=C2=A0it=C2=A0or=C2=A0not,= =C2=A0it=C2=A0is=C2=A0**not** >>>>=C2=A0=C2=A0=C2=A0=C2=A0up >>>>=C2= =A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0to >>>>=C2= =A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0the >>>>=C2= =A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0person=C2=A0porti= ng=C2=A0the=C2=A0software=C2=A0to=C2=A0forcefully=C2=A0enable=C2=A0it. >>= >>=C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0--=C2=A0 >= >>>=C2=A0=C2=A0=C2=A0=C2=A0 >>>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Mathieu= =C2=A0Arnold >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0Hi, >>>= =C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0Likely=C2=A0because=C2= =A0this=C2=A0pretty=C2=A0much=C2=A0silently=C2=A0went=C2=A0by=C2=A0because= =C2=A0it=C2=A0was >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0post= ed >>>=C2=A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0on=C2=A0Phab=C2= =A0and=C2=A0you=C2=A0only=C2=A0CCed=C2=A0bapt.=C2=A0It's=C2=A0been=C2=A0ena= bled=C2=A0since=C2=A0Jan >>>=C2=A0=C2=A0=C2=A02023 >>>=C2=A0=C2=A0= =C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0(https://cgit.freebsd.org/ports/commit/= Mk/Uses/cargo.mk?id=3D967022fd812cf67dec264ee4e53bd016b69e7a2b) >>>=C2= =A0=C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0and=C2=A0tested/discussed= =C2=A0here=C2=A0https://reviews.freebsd.org/D36736 >>>=C2=A0=C2=A0=C2= =A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0before >>>=C2=A0=C2=A0=C2=A0 >>>=C2= =A0=C2=A0=C2=A0=C2=A0being=C2=A0enabled/committed.=C2=A0I=C2=A0noticed= =C2=A0it=C2=A0now=C2=A0while=C2=A0updating=C2=A0a=C2=A0Rust >>>=C2=A0= =C2=A0=C2=A0 >>>=C2=A0=C2=A0=C2=A0=C2=A0(cargo-based)=C2=A0port. >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Mmmm,=C2=A0yes,=C2=A0I=C2=A0know=C2= =A0about=C2=A0that,=C2=A0and=C2=A0I=C2=A0agree,=C2=A0this=C2=A0commits= =C2=A0reverts >>=C2=A0=C2=A0this >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2= =A0behavior. >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Because=C2=A0choosing= =C2=A0to=C2=A0build=C2=A0with=C2=A0or=C2=A0without=C2=A0LTO=C2=A0is=C2= =A0a=C2=A0user=C2=A0facing >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0feature,= >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0not=C2=A0a=C2=A0porter=C2=A0facing= =C2=A0feature,=C2=A0so,=C2=A0it=C2=A0has=C2=A0to=C2=A0be=C2=A0set=C2=A0by= =C2=A0people >>=C2=A0=C2=A0building >>=C2=A0=C2=A0 >>=C2=A0=C2=A0= =C2=A0the >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0things,=C2=A0not=C2=A0by= =C2=A0the=C2=A0framework=C2=A0or=C2=A0a=C2=A0port. >>=C2=A0=C2=A0 >>= =C2=A0=C2=A0=C2=A0--=C2=A0 >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0Mathieu= =C2=A0Arnold >=C2=A0 >=C2=A0Hi, >=C2=A0 >=C2=A0Given=C2=A0that= =C2=A0it=C2=A0was=C2=A0commonly=C2=A0agreed=C2=A0upon=C2=A0as=C2=A0a=C2= =A0sane=C2=A0default=C2=A0I=C2=A0don't=C2=A0see >=C2=A0 >=C2=A0how= =C2=A0your=C2=A0opinion=C2=A0in=C2=A0this=C2=A0case=C2=A0weights=C2=A0more.= =C2=A0That=C2=A0being=C2=A0said,=C2=A0any >=C2=A0 >=C2=A0option=C2= =A0could=C2=A0be=C2=A0defined=C2=A0as=C2=A0user=C2=A0facing=C2=A0option= =C2=A0some=C2=A0of=C2=A0which=C2=A0are >=C2=A0 >=C2=A0already=C2=A0agre= ed=C2=A0upon=C2=A0as=C2=A0sane=C2=A0such=C2=A0as=C2=A0DOCS=C2=A0and=C2= =A0EXAMPLES. >=C2=A0 >=C2=A0Best=C2=A0regards, >=C2=A0 >=C2=A0Danie= l Hi, Jsuit a heads up, given that I haven't recieved any further= mail regading this change or further explanation I'll enable LTO again f= or Cargo ports as agreed upon in https://reviews.freebsd.org/D36736 later= today. Best regards, Daniel (diizzyy@) --_=_swift_1721552866_4dce2c21be23c5add0b4c983a8fecfb2_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-07-13T18:49:27.000+02:00, Daniel Engbe= rg <daniel.engberg.lists@pyret.net> wrote:
On 2024-07-13T16:30:31.000+02:00, Mathieu =
Arnold <mat=
@freebsd.org>
wrote:

  On Sat, Jul 13, 2024 at 02:04:48PM GMT, Dan=
iel Engberg wrote:
   On 20=
24-07-13T08:47:47.000+02:00, Mathieu Arnold
  
   wrote:
  
    On Sat, Jul 13, 2024 at 06:11:04AM GMT, D=
aniel Engberg wrote:
   
     Hi,
    
     This changes so =
LTO option is no longer applied to Rust
    (cargo)
=

    
     ports
    
     BY=
 DEFAULT causing a regresssion, please fix.
    =

    As it has been three months, nobody complained something=
 was
   broken
   
    so,
   
    I don't think anything is actually broken.
   
    LTO as are a few other features like SSP =
are user facing
   features,
   
=
    not a
   
    porters facing options, it me=
ans, it's up to the person doing
   the
   
=

    building to choose wether to enable it or not, it is **not**=
 up
   to
   
    the
   
    person porting the software to forcefully enable i=
t.
   
    -- 
   
=
    Mathieu Arnold
   
   Hi,
<=
/div>
  
   Likely because this pretty much silently went=
 by because it was
  posted
  
  =
 on Phab and you only CCed bapt. It's been enabled since Jan 2023
=

  
  
   an=
d tested/discussed here https://reviews.freebsd.org/D36736
  befor=
e
  
   being enabled/committed. I noticed it n=
ow while updating a Rust
  
   (cargo-based) po=
rt.

Mmmm, yes, I know about th= at, and I agree, this commits reverts this

b= ehavior.

Because choosing to build with or w= ithout LTO is a user facing
feature,

not a porter facing feature, so, it has to be set by people buildin= g
the

things, not by the fram= ework or a port.

--

Mathieu Arnold

Hi,

Given that it was commonly agreed upon as a sane de= fault I don't see
how your opinion in this case weights more.= That being said, any
option could be defined as user facing = option some of which are
already agreed upon as sane such as = DOCS and EXAMPLES.

Best regards,

Daniel
H= i,

Jsuit a heads up, g= iven that I haven't recieved any further mail regading this change or furth= er explanation I'll enable LTO again for Cargo ports as agreed upon in https://reviews.freebsd.org/D367= 36 later today.

Be= st regards,
Daniel (diizzyy@)
--_=_swift_1721552866_4dce2c21be23c5add0b4c983a8fecfb2_=_--