Re: git: 7b0c8167940b - main - net/ntpd-rs: mark as broken on i386
- In reply to: Sergey A. Osokin: "Re: git: 7b0c8167940b - main - net/ntpd-rs: mark as broken on i386"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 20 Jul 2024 21:35:02 UTC
On 2024-07-20T21:40:02.000+02:00, Sergey A. Osokin <osa@freebsd.org> wrote: > On Sat, Jul 20, 2024 at 10:36:48PM +0300, Vladimir Druzenko wrote: >> 20.07.2024 21:13, Jan Beich пишет: >> >>> Mikaël Urankar <mikael@FreeBSD.org> writes: >>> >>>> On 7/20/24 17:43, Jan Beich wrote: >>>> >>>>> Mikael Urankar <mikael@FreeBSD.org> writes: >>>>> >>>>>> +NOT_FOR_ARCHS= i386 >>>>>> >>>>>> +NOT_FOR_ARCHS_REASON= the ring crate requires SSE2 >>>>>> instruction on intel cpu >>>>> >>>>> Why not pass -C target-feature=+sse2 like games/jumpy >>>>> instead? >>>> >>>> Per [1] we are supposed to target Pentium Pro / Pentium II >>>> (i686), >>>> >>>> sse2 is not available on these cpus. This is enforced in our >>>> rust >>>> >>>> ports with [2]. > > Add my two cents. I've added the following line to the > security/boringssl > > CFLAGS_i386= -msse2 > > I do believe that's enough. > > Thank you. > > -- > > Sergey A. Osokin Hi, Instead "abusing" C/CXX/*FLAGS utilize our framework instead? https://cgit.freebsd.org/ports/tree/audio/libsidplayfp/Makefile#n51 This will also make builds fail if your target lacks said instructions. Best regards, Daniel