From nobody Sat Jul 20 09:35:53 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WR1cn5NFQz5RKv9; Sat, 20 Jul 2024 09:35:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WR1cn3qNtz4m3b; Sat, 20 Jul 2024 09:35:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721468153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WBk4vDTWGTrY5pyWrxRmA+/3NcBREBfh/U3Z7SUUAVU=; b=WH8UHwzQbKsjrilIFyaae3hoQix8NpdQAjHYaw1mgn2ZhTW4mxUNSnSiuQ2DCCnQHWh+Qk 8kHQuepG/XosodxKDsdzz9VR1+97DEiApEPNwD0itu5yaIEPzvbvAfU2vGh1Kpvl2pwfD5 00TdAjo9TImDtsccrke23Bjpqe5Y96osMoxh2lEWeSWoqDax1OinsswOaKZ/QoFXWvtL/t qijZEcLLpLd91gh1P6v7bjLEYYh188skWh5VHrkxpAwC4grMUtfS/1MpYL3ivaH4hJY5ij PRXUkMphRH7bOeBlQnU7Ly2x5Czn6Ugfb10J9BeEU6ELovv0pBeXRCpXe0RDxA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721468153; a=rsa-sha256; cv=none; b=HtRlVzcDBOlQQfPYjfvnBylviGhhi7X0MXRR86PPkwpZbCnvoOgdV7afg2QlRMPPNjYmV+ Dju5h9pHyenxiFhnmH1if9UUoFmUnIhZBc7nxWbjlcWwfiQK9zpApd1SF/oYoJo95ToMhr 5mgunI71JvQJ+9RYFRj0gXcxGIgHyOTZ2l9XKziRMBv9bxjRi/JK/uWqZnmXiL9Z6cycBx yD2IdToCRwqeVjMGgYDh65XLhqUXluxcwFOKcys4BvCF8ZhGKBhd5JLVPNlWsu+TLp4xme X+etmhbOxr4j+eOCzUio49Sdd5EJSsjS5TScXQ627+k5gYgLWgLKnFAm3UwR+A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721468153; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WBk4vDTWGTrY5pyWrxRmA+/3NcBREBfh/U3Z7SUUAVU=; b=NyvW5+t5HNDogBCQVt2rr4nM5yKSd2kjbihnIUjdOXLJ16QWRGNSCmtMcr1o1rJ7K4qf8C /WYi/8vcPtBWmSLndb1LPenXh3xqHNHebQDwEM22ZITkZPRB8wh8x6VIvL2m+5m9CitwAY /zElLbxYSqtb4X4IBYqwlycVYmAZKHcbzgd+UDXpbN2z2EMujiFBxQb+7ChuOkEUemcPGr /jZImyged9ngJNF02fBEEcEJgGIOtiaNTnA1k1vaRGRzEC423bqx2pXknlcqEb8f2D2NjD CAt3fckkPezUJ9m55RraaByD6FYHIwwRGEQIvAhB+BEZkn+61iMdo3ikfYwkYw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WR1cn3FjKz19G5; Sat, 20 Jul 2024 09:35:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46K9ZrwF003333; Sat, 20 Jul 2024 09:35:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46K9ZrUo003330; Sat, 20 Jul 2024 09:35:53 GMT (envelope-from git) Date: Sat, 20 Jul 2024 09:35:53 GMT Message-Id: <202407200935.46K9ZrUo003330@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Vladimir Druzenko Subject: git: 4b9b21dfcdc6 - main - emulators/virtualbox-ose{,-nox11}-legacy: fix USB passthrough fails with: Failed to create a proxy device for the USB device List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vvd X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4b9b21dfcdc6a213b8b9842dbc7ea8dd8fcd48e3 Auto-Submitted: auto-generated The branch main has been updated by vvd: URL: https://cgit.FreeBSD.org/ports/commit/?id=4b9b21dfcdc6a213b8b9842dbc7ea8dd8fcd48e3 commit 4b9b21dfcdc6a213b8b9842dbc7ea8dd8fcd48e3 Author: Igor Malyshev AuthorDate: 2024-07-20 09:31:14 +0000 Commit: Vladimir Druzenko CommitDate: 2024-07-20 09:35:41 +0000 emulators/virtualbox-ose{,-nox11}-legacy: fix USB passthrough fails with: Failed to create a proxy device for the USB device Failed to create a proxy device for the USB device. (Error: VERR_INVALID_PARAMETER) 00:00:24.961804 usbProxyConstruct: Failed to open '/dev/ugen0.6', rc=VERR_INVALID_PARAMETER 00:00:24.961881 ERROR [COM]: aRC=NS_ERROR_FAILURE (0x80004005) aIID={872da645-4a9b-1727-bee2-5585105b9eed} aComponent={ConsoleWrap} aText={Failed to create a proxy device for the USB device. (Error: VERR_INVALID_PARAMETER)}, preserve=false aResultDetail=-2 In commit https://cgit.freebsd.org/src/commit/?id=9b077d72bcc313baea2b9283afc7f568739eaadc +#define USB_FS_XFER_MAX 126 - if (fs_ep_ptr == NULL || ep_index_max > 127) + if (fs_ep_ptr == NULL || ep_index_max > USB_FS_XFER_MAX) To fix VirtualBox decrease USBFBSD_MAXENDPOINTS from 127 to 126: -#define USBFBSD_MAXENDPOINTS 127 +#define USBFBSD_MAXENDPOINTS 126 PR: 270900 Tested by: groenveld@acm.org, russo@bogodyn.org Approved by: with hat of vbox (maintainer) MFH: 2024Q3 --- emulators/virtualbox-ose-legacy/Makefile | 2 +- .../patch-src_VBox_Devices_USB_USBProxyDevice-freebsd.cpp | 11 +++++++++++ emulators/virtualbox-ose-nox11-legacy/Makefile | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/emulators/virtualbox-ose-legacy/Makefile b/emulators/virtualbox-ose-legacy/Makefile index 4ce61c2bb073..659e3ecdce3a 100644 --- a/emulators/virtualbox-ose-legacy/Makefile +++ b/emulators/virtualbox-ose-legacy/Makefile @@ -1,6 +1,6 @@ PORTNAME= virtualbox-ose PORTVERSION= 5.2.44 -PORTREVISION?= 20 +PORTREVISION?= 21 CATEGORIES= emulators MASTER_SITES= https://download.oracle.com/virtualbox/${PORTVERSION}/:src \ LOCAL/bofh/emulators/virtualbox-ose-legacy:docs diff --git a/emulators/virtualbox-ose-legacy/files/patch-src_VBox_Devices_USB_USBProxyDevice-freebsd.cpp b/emulators/virtualbox-ose-legacy/files/patch-src_VBox_Devices_USB_USBProxyDevice-freebsd.cpp new file mode 100644 index 000000000000..8ece9c316a1e --- /dev/null +++ b/emulators/virtualbox-ose-legacy/files/patch-src_VBox_Devices_USB_USBProxyDevice-freebsd.cpp @@ -0,0 +1,11 @@ +--- src/VBox/Devices/USB/freebsd/USBProxyDevice-freebsd.cpp.orig 2020-07-09 16:55:58 UTC ++++ src/VBox/Devices/USB/freebsd/USBProxyDevice-freebsd.cpp +@@ -57,7 +57,7 @@ + #include "../USBProxyDevice.h" + + /** Maximum endpoints supported. */ +-#define USBFBSD_MAXENDPOINTS 127 ++#define USBFBSD_MAXENDPOINTS 126 + #define USBFBSD_MAXFRAMES 56 + + /** This really needs to be defined in vusb.h! */ diff --git a/emulators/virtualbox-ose-nox11-legacy/Makefile b/emulators/virtualbox-ose-nox11-legacy/Makefile index 0406eecfc7aa..f5b76395f8e9 100644 --- a/emulators/virtualbox-ose-nox11-legacy/Makefile +++ b/emulators/virtualbox-ose-nox11-legacy/Makefile @@ -1,4 +1,4 @@ -PORTREVISION= 18 +PORTREVISION= 19 PKGNAMESUFFIX= -nox11-legacy OPTIONS_EXCLUDE= ALSA DBUS DEBUG GUESTADDITIONS DOCS NLS PULSEAUDIO