From nobody Tue Jul 16 08:08:19 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WNWsb4Xr8z5QpGY; Tue, 16 Jul 2024 08:08:19 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WNWsb42Ldz4yNd; Tue, 16 Jul 2024 08:08:19 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721117299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ei6N32Jki+jd8dsE/WPTsiHS1Ts13G939Wf+OQYQk64=; b=FNw6/CBVZvjURq7FA9WasFxzoZ1548F0sZFm7moA486Z4v4zBjxXaFPTs9yZdZpDRLLj5A 6QnKPifT78V5nSCADrhFrXvqIQ4RJBhxbs+Ne85ZXAo71vZ/84FliRTHHuLOTGhOYaXHb2 W2SLtgyvDt1kvskDVtuOsoYQNSsmMVzM+qLXr+edKns5TgeZqFiBDxsRxC+4+1mEcdcDFk CPVsGgEuGx5CyYcLw/n7vTcbznv/rki3Spw/97pzgXAlwKph5krXBNbFBQCA0A/g2RBJYb NQKt4rrHgP830V1UJcz8KISS1lJA2VDYFxjfXxQh4W/2hbaFNzCLnT+FmSThXQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721117299; a=rsa-sha256; cv=none; b=wAVzb9WzmUqAw/PGTYc4A1Enlni1paUzyRzIoHZPduIp8dJN8INzoGgnjj4JaPpy/HlAQe 3e/aQyaBh8dyWTU4cGp6aAVH1hsw9Iw7E0+ValTwdh032qt0lwN14nPNqlLLItBlnaOF1M EybPq9GnGpzZJ9CQD4pjvrWwFDf0llCcjNYcbc1BHVc6IymZQSAA6gR6mqoKduiOSOtcc2 xvWmfLAK/6b2qobEn+PxrE441Indc9OOqOPNP6GxoBp9I/y8KpIrJK87us9ZGz+v71/eBU D2hwoTCBMRgkvgqPCtTpaU7/hXp5ruX83Vekzv6MZWsxvpIGdON+CqLHeSFJNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721117299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ei6N32Jki+jd8dsE/WPTsiHS1Ts13G939Wf+OQYQk64=; b=gSMqeyIGcyrfTzbmtskWqiXrE1BbFJIfQUh+xlhwdJVX66WzlyTqg4rIpEJH7xcPG6qF62 iLtneQB7OooULZU+KUvepDQVgwyWyiPp3/ip0amWrBQ/EsAAqu6h2CKqINJg6kYThBAFsz XQpFhXOMhqtw502fupzufFHU/fnV72Vbcyq5fxZBO734FmITiB/OHS10YvuqVQoSkALw67 2STT2oN25LFAuA7vBDe4Z94H9EduOP4R4eHAoM9ar2vThywj2Pxc+ORMOGRaHhjoCDLHtL hQNwFxznrjMNvzxYACz+ck11MTqoTRGDp4PVQOtAyKDQcb+U6uIjyZ2lm0ax1w== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 6FBAE529E; Tue, 16 Jul 2024 08:08:19 +0000 (UTC) Date: Tue, 16 Jul 2024 08:08:19 +0000 From: Alexey Dokuchaev To: Zsolt Udvari Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5 Message-ID: References: <202407131836.46DIaqMZ075082@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 16, 2024 at 09:59:00AM +0200, Zsolt Udvari wrote: > On Tue, Jul 16, 2024 at 07:23:49AM +0000, Alexey Dokuchaev wrote: > > On Sat, Jul 13, 2024 at 06:36:52PM +0000, Zsolt Udvari wrote: > > > commit d6a461ce6716be61682e196cd624903be0557e50 > > > > > > games/lolcat: update to 1.5 > > > Pet portfmt while I'm here. > > > ... > > > @@ -19,7 +19,8 @@ CFLAGS+= -lm > > > > > > CONFLICTS_INSTALL= filters > > > > > > -PLIST_FILES= bin/censor bin/lolcat > > > +PLIST_FILES= bin/censor \ > > > + bin/lolcat > > > > I've seen these one-word-per-line splits before, presumably coming > > from this portfmt thingy, and don't quite see the benefit in this > > case for example, when words and lines are short. While I think > > I understand the general rationale behind this, it often makes the > > Makefile actually *less* readable and longer, eating precious > > vertical space. > > Thanks for comment. I understand what you say, but I don't know which > version is better. _For me_ it's more readable this version because > it's similar to pkg-plist file (one-word-per-line). Hmm, interesting point about similarity to pkg-plist, fair enough. > I would avoid PLIST_FILES and use only pkg-plist file. > One port uses PLIST_FILES another uses pkg-plist, it's a little > confusing for me. PLIST_FILES are handy when there's few of them so it's easier to keep all things in one place (the Makefile), also makes the diffs shorter. Another good thing is that they are part of the options helpers, so one can list one or more FOO_PLIST_FILES_[OFF] while leaving the main pkg-plist less cluttered (no need for PLIST_SUBs). ./danfe