Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5

From: Zsolt Udvari <uzsolt_at_freebsd.org>
Date: Tue, 16 Jul 2024 07:59:00 UTC
On Tue, Jul 16, 2024 at 07:23:49AM +0000, Alexey Dokuchaev wrote:
> On Sat, Jul 13, 2024 at 06:36:52PM +0000, Zsolt Udvari wrote:
> > commit d6a461ce6716be61682e196cd624903be0557e50
> > 
> >   games/lolcat: update to 1.5
> >   Pet portfmt while I'm here.
> > ...
> > @@ -19,7 +19,8 @@ CFLAGS+=	-lm
> >  
> >  CONFLICTS_INSTALL=	filters
> >  
> > -PLIST_FILES=	bin/censor bin/lolcat
> > +PLIST_FILES=	bin/censor \
> > +		bin/lolcat
> 
> I've seen these one-word-per-line splits before, presumably coming
> from this portfmt thingy, and don't quite see the benefit in this
> case for example, when words and lines are short.  While I think
> I understand the general rationale behind this, it often make the
> Makefile actually *less* readable and longer, eating precious
> vertical space.
Thanks for comment. I understand what you say, but I don't know which version
is better.
_For me_ it's more readable this version because it's similar to pkg-plist file
(one-word-per-line).
Maybe should create a rule (as a coding style) and add to Porter's
Handbook.

Cheers,
  Zsolt

Ps.
I would avoid PLIST_FILES and use only pkg-plist file.
One port uses PLIST_FILES another uses pkg-plist, it's a little
confusing for me.