From nobody Sat Jul 13 12:04:48 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WLnFx21TTz5Qf3f for ; Sat, 13 Jul 2024 12:04:53 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-bc0d.mail.infomaniak.ch (smtp-bc0d.mail.infomaniak.ch [45.157.188.13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WLnFw4QYVz4GM1 for ; Sat, 13 Jul 2024 12:04:52 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4WLnFr5JjFzCXZ; Sat, 13 Jul 2024 14:04:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1720872288; bh=7Uc2UyA1j8o15K42hFFrEffdjq11HJ+VikokrzE+k8c=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=GzLyUqx/qIZ3d3MO4gB+kf1uEuI5NPdHZS8gElEDmEnPqrdXC8J3JzXWtfPUZeZsX nnA54VVgG5WgRBCrTPmoOLUrCRxuS25rMkB+L/A0Ps9yItBkyq1vKUyV19vZxoIqJr V0QNR3KjPfMGvlppYPD0ex0yiN2y3A63a2w9l5+OrxzCocOy+aQnlLEUBFb/cIm9i5 1zkpCifd1UNO9kerwYbWqAqC6QxhH+w3p4j2KZqpCx0jQBNLj5GkVWq94OFbsz5V/K phXVOwVEjGU5zovcpQ9cFeN0BY9vgZMtVM/gkLyCCEnt7yKFYGCSnoz+RTK0dQJC3E VPTKA+MFQYWyg== Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4WLnFr2bxgzhT1; Sat, 13 Jul 2024 14:04:48 +0200 (CEST) Message-ID: <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> Date: Sat, 13 Jul 2024 14:04:48 +0200 Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code From: Daniel Engberg Reply-To: Daniel Engberg To: Mathieu Arnold Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin , "arrowd@FreeBSD.org" List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1720872288_c5894cfe66e9a9dd9fa67c9e1e890b3a_=_" X-WS-User-Origin: eyJpdiI6IlpPQm5zTHdhRC9rTFE3RkZpL1Q1M3c9PSIsInZhbHVlIjoiQU8xVVhIb1J0c1NidXVmMGhHUEV6QT09IiwibWFjIjoiZGE1MTUyMzhkZGQ4YTJkYmIyMzE2YmEwMTc3MmMyNjFmMGY5ZjEwYzM0M2VkNzFjZGE4ZDBhM2UwZjA4OTRiZCIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6InAyUzZLQm5yeTg1TXhmUjJrT21ZRWc9PSIsInZhbHVlIjoiMWNzT1NJK1BzQTVKa1hNMjFxUEhWdz09IiwibWFjIjoiM2VhYTJkYWIyMzAwN2QxMTliYjczZTFmNzUyYzYyNjQwODQ1OTlkMDU0MTZlNTYxMWE2YWZiYmJmNWI3ZjU5MyIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.716) References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> In-Reply-To: <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:45.157.188.0/22, country:CH] X-Rspamd-Queue-Id: 4WLnFw4QYVz4GM1 --_=_swift_1720872288_c5894cfe66e9a9dd9fa67c9e1e890b3a_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold wrote:= >=C2=A0On=C2=A0Sat,=C2=A0Jul=C2=A013,=C2=A02024=C2=A0at=C2=A006:11:04= AM=C2=A0GMT,=C2=A0Daniel=C2=A0Engberg=C2=A0wrote: >>=C2=A0=C2=A0Hi, >>= =C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0This=C2=A0changes=C2=A0so=C2=A0LTO=C2= =A0option=C2=A0is=C2=A0no=C2=A0longer=C2=A0applied=C2=A0to=C2=A0Rust=C2= =A0(cargo) >>=C2=A0=C2=A0ports >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0BY= =C2=A0DEFAULT=C2=A0causing=C2=A0a=C2=A0regresssion,=C2=A0please=C2=A0fix.= >=C2=A0 >=C2=A0As=C2=A0it=C2=A0has=C2=A0been=C2=A0three=C2=A0months,= =C2=A0nobody=C2=A0complained=C2=A0something=C2=A0was=C2=A0broken >=C2= =A0so, >=C2=A0 >=C2=A0I=C2=A0don't=C2=A0think=C2=A0anything=C2=A0is= =C2=A0actually=C2=A0broken. >=C2=A0 >=C2=A0LTO=C2=A0as=C2=A0are=C2= =A0a=C2=A0few=C2=A0other=C2=A0features=C2=A0like=C2=A0SSP=C2=A0are=C2=A0use= r=C2=A0facing=C2=A0features, >=C2=A0not=C2=A0a >=C2=A0 >=C2=A0porters= =C2=A0facing=C2=A0options,=C2=A0it=C2=A0means,=C2=A0it's=C2=A0up=C2=A0to= =C2=A0the=C2=A0person=C2=A0doing=C2=A0the >=C2=A0 >=C2=A0building=C2= =A0to=C2=A0choose=C2=A0wether=C2=A0to=C2=A0enable=C2=A0it=C2=A0or=C2=A0not,= =C2=A0it=C2=A0is=C2=A0**not**=C2=A0up=C2=A0to >=C2=A0the >=C2=A0 >= =C2=A0person=C2=A0porting=C2=A0the=C2=A0software=C2=A0to=C2=A0forcefully= =C2=A0enable=C2=A0it. >=C2=A0 >=C2=A0--=C2=A0 >=C2=A0 >=C2=A0Mathie= u=C2=A0Arnold Hi, Likely because this pretty much silently went b= y because it was posted on Phab and you only CCed bapt. It's been enabled= since Jan 2023 (https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?i= d=3D967022fd812cf67dec264ee4e53bd016b69e7a2b) and tested/discussed here h= ttps://reviews.freebsd.org/D36736 before being enabled/committed. I notic= ed it now while updating a Rust (cargo-based) port. Best regards, = Daniel --_=_swift_1720872288_c5894cfe66e9a9dd9fa67c9e1e890b3a_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold <mat@f= reebsd.org> wrote:
On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote:
  Hi,
 
 This changes so LTO option is no longer applied to Rust (cargo) ports
 BY DEFAULT causing a regresssion, please fix.
 
As it has been three months, nobody complained s=
omething was broken so,
I don't think anything is actually br=
oken.

LTO as are a few other features like SSP=
 are user facing features, not a
porters facing options, it m=
eans, it's up to the person doing the
building to choose weth=
er to enable it or not, it is **not** up to the
person portin=
g the software to forcefully enable it.

-- 
Mathieu Arnold
Hi,

Likely because this pretty much silently went by be= cause it was posted on Phab and you only CCed bapt. It's been enabled since= Jan 2023 (https://cgit.freebsd.org/p= orts/commit/Mk/Uses/cargo.mk?id=3D967022fd812cf67dec264ee4e53bd016b69e7a2b<= /a>) and tested/discussed here https://reviews.freebsd.org/D36736 before being enabled/committed. I= noticed it now while updating a Rust (cargo-based) port.
Best regards,
Daniel
--_=_swift_1720872288_c5894cfe66e9a9dd9fa67c9e1e890b3a_=_--