Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code

On Sat, Jul 13, 2024 at 9:47 AM Mathieu Arnold <mat@freebsd.org> wrote:
>
> On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote:
> > Hi,
> >
> > This changes so LTO option is no longer applied to Rust (cargo) ports
> > BY DEFAULT causing a regresssion, please fix.
>
> As it has been three months, nobody complained something was broken so,
> I don't think anything is actually broken.

Funny, this was exactly my argument when you were reverting my implementation.

> LTO as are a few other features like SSP are user facing features, not a
porters facing options, it means, it's up to the person doing the
building to choose wether to enable it or not, it is **not** up to the
person porting the software to forcefully enable it.

I don't agree with that and talked about it in my writeup [1], which
seemingly no one in portmgr@ cared to read.

[1] https://reviews.freebsd.org/D44789