From nobody Tue Jul 09 10:35:23 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WJHSW2Bh8z5QLj7; Tue, 09 Jul 2024 10:35:23 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WJHSW1LvJz42ZK; Tue, 9 Jul 2024 10:35:23 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720521323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f0/K4ZcS/1cDNUi2hj+Ae8l8xBXSpqcd6DwQkDXzLhk=; b=k4gqej62zyooa1DN2ZYZaX6cniHLYNslZirhBjJaUXFPS/K1Z12vWStOoNf54jf0XgmHb1 fZ29/PaohpypV7OTqSTI01WNibPCCU7Z+ORvmBfrqBJ0GvBZ+3uVFP9xfD+/q13mj2pl7H dP8SUEqwcZ9bT09ttY7pmvgZ5QMbpsKTGYZZA2SGzmb2tmq9VgO8dLG7rpoXagrn6qM31+ zyHAft5q2oqFZTYIPpWPS9Wf/JiukZc3lent5/17s0QnKd7MIqnzoJVE5doi5k1COAQchb HdvClWfNEL6G0g8eFGPnnUKTnImaRE3qEpNuPQIHGkqfmoNW4UdyBLGGHkB+9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1720521323; a=rsa-sha256; cv=none; b=vgEwiBa9eq9M5+d5EOOq+AvJM21QhvUjxcMuIMJlU70zCudPrYM4A7Pip2fIxD5zuMRsH+ 3m/EzZnzVZIbJerMGamO5lVhOVTs2vycn+EC+djot327mgs9/HhCECfbmmgbZyr2bWa94D BYexsuBM1eAarwQH0nw96HD75y8hch0Nt42SX/fsK6A/4cnd+ewza31V3rXmGZM0lLNQUm A74uKpQCkNAqu+aTx2QPOgGX7qwqbK7WAakG6iEYOMorI3O0xUbv4BkWez9lPJA+0VKdpJ cCTAubFxARU2OxBaWgCqWYsk40gIXdlBoDJK/rWZXrCI9QvKuoKm7wXLtC5ymg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1720521323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f0/K4ZcS/1cDNUi2hj+Ae8l8xBXSpqcd6DwQkDXzLhk=; b=A0hy0uJjt5tPRUzHR4ELBOmAQwDlAvLi+gO4UFrwAw9o7E0ME1G8uE5Bv7ueWKT1QF3x8a y9a0xBx9jophbI1AC+Wf0xb+MtEih/EcGm3px06pWxtvJ7LtfBhTCFo/Pgip2yp+VU5pnD 0mUMDRxFHNktGzJjW+EUI1QZpxxnO1JWKE6oWQU5XSy3AimIwTB4D0VgFjP/4/CFaIDRE2 FFdezCZKomtZyThvjQdhPkTx9pAuCi73kdhfm038mbBBc56P52IygNNEnNnWevJQ4ZqQMn bEvHJmLuD7j03/brVq1KlKf43JEXGzh2A0SlFSDORlHdeZCi03kYkpEN6+lqIw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 19E411982B; Tue, 09 Jul 2024 10:35:23 +0000 (UTC) Date: Tue, 9 Jul 2024 10:35:23 +0000 From: Alexey Dokuchaev To: Piotr Kubaj Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4a72fdf13706 - main - misc/pytorch: fix build on arm64 Message-ID: References: <202407091004.469A4q1M005462@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202407091004.469A4q1M005462@gitrepo.freebsd.org> On Tue, Jul 09, 2024 at 10:04:52AM +0000, Piotr Kubaj wrote: > commit 4a72fdf137062c477b25bf1602d57745b569a352 > > misc/pytorch: fix build on arm64 > ... > + # Enable conditional FP16 arithmetic intrinsics > +-if(CPU_AARCH64 AND LINUX) > ++if(CPU_AARCH64 AND CMAKE_SYSTEM_NAME MATCHES "FreeBSD") Looks like in its current form the patch isn't quite upstreamable. Did you try to raise this issue with developers to come up with more generic solution? Ad-hoc patches might fix some problem in the moment but often become extra burden for ports' maintainers with future updates. ./danfe