Re: Re: git: a3cf7b23ba32 - main - sysutils/vmstated: add new port

Hi, thanks for the point out. I will check it later.

On Wed, Jan 24, 2024 at 06:11:38PM +0100, Jan Beich wrote:
> Koichiro Iwao <meta@FreeBSD.org> writes:
> 
> >  sysutils/Makefile           |  1 +
> >  sysutils/vmstated/Makefile  | 19 +++++++++++++++++++
> >  sysutils/vmstated/README.md | 38 ++++++++++++++++++++++++++++++++++++++
> >  sysutils/vmstated/distinfo  |  3 +++
> >  sysutils/vmstated/pkg-descr |  4 ++++
> >  sysutils/vmstated/pkg-plist |  8 ++++++++
> >  6 files changed, 73 insertions(+)
> [...]
> > diff --git a/sysutils/vmstated/README.md b/sysutils/vmstated/README.md
> > new file mode 100644
> > index 000000000000..2750e950f1a9
> > --- /dev/null
> > +++ b/sysutils/vmstated/README.md
> > @@ -0,0 +1,38 @@
> > +## vmstated
> > +
> > +`vmstated` is a very simple bhyve virtual machine manager for FreeBSD.
> > +
> > +### How to compile
> > +
> > +Eventually, `vmstated` will be released via the regular ports channel; until then,
> > +one can run the following commands:
> > +
> > +```
> > +git clone https://github.com/christian-moerz/vmstated
> > +cd vmstated/port
> > +make package
> > +pkg install work/pkg/vmstated-0.01.pkg
> > +```
> > +
> > +To uninstall vmstated, use the usual pkg command
> > +
> > +```
> > +pkg deinstall vmstated
> > +```
> > +
> > +### How to get started
> > +
> > +Please refer to the man pages for `vmstated(8)` or `vmstatedctl(1)` for further
> > +details on how to use `vmstated`.
> > +
> > +To start `vmstated` run
> > +
> > +```
> > +sysrc vmstated_enable=YES
> > +service vmstated start
> > +```
> > +
> > +- Configuration files go under `/usr/local/etc/vmstated`.
> > +- Log files are under `/var/log/vmstated`
> > +- PID file and socket are under `/var/run/`
> > +
> 
> Stray file? It's not installed and looks redundant: documents the
> standard way to install ports/packages, how to start rc.d(8) services
> and according to vmstatd(8) manpage where configs are located.
> 
> > --- /dev/null
> > +++ b/sysutils/vmstated/pkg-plist
> > @@ -0,0 +1,8 @@
> > +@mode 755
> > +bin/vmstatedctl
> > +etc/rc.d/vmstated
> > +@mode 750
> > +sbin/vmstated
> > +@mode 0444
> > +share/man/man1/vmstatedctl.1.gz
> > +share/man/man8/vmstated.8.gz
> 
> @mode is generally not necessary unless different from default permissions
> set by vendor install target. Also can be limited per file e.g.,
> "@(,,750) sbin/vmstated"; see 20140922 item in /usr/ports/CHANGES.
> 
> Vendor Makefile uses <bsd.prog.mk> but for some reason handrolls
> "install" target (a workaround for missing USES=uidfix?).

-- 
meta <meta@FreeBSD.org>