Re: git: 824cdca032f1 - main - audio/strawberry: Add gstreamer plugins

On Thu, Jan 25, 2024 at 9:02 PM Kevin Bowling <kbowling@freebsd.org> wrote:
>
> The branch main has been updated by kbowling:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=824cdca032f1fc8a7f02ddc8108a1340c7772af9
>
> commit 824cdca032f1fc8a7f02ddc8108a1340c7772af9
> Author:     Kevin Bowling <kbowling@FreeBSD.org>
> AuthorDate: 2024-01-26 02:00:06 +0000
> Commit:     Kevin Bowling <kbowling@FreeBSD.org>
> CommitDate: 2024-01-26 02:00:06 +0000
>
>     audio/strawberry: Add gstreamer plugins
>
>     Without these, the software is not useful and requires extra work.
>     There are probably some better tradeoffs, but ship the default set from
>     the older Clementine port until proven otherwise.
>
>     PR:             276488
>     Approved by:    maintainer
> ---
>  audio/strawberry/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/audio/strawberry/Makefile b/audio/strawberry/Makefile
> index fbdc4b4c3e7c..3ebea3e26936 100644
> --- a/audio/strawberry/Makefile
> +++ b/audio/strawberry/Makefile
> @@ -69,6 +69,7 @@ EBUR128_IMPLIES=      GSTREAMER
>
>  GSTREAMER_USES=                gstreamer
>  GSTREAMER_CMAKE_BOOL=  ENABLE_GSTREAMER
> +GSTREAMER_USE=         GSTREAMER=cdparanoia,chromaprint,faac,faad,flac,lame,mpg123,neon,opus,shout2,soup,taglib,twolame,vorbis
>
>  ICONV_USES=            iconv:translit
>

I actually did not approve this and even mentioned in the PR that many
of these plugins are superfluous and that the cdparanoia plugin is
only useful for the CDIO option.

- Jason