Re: git: fabf8b5d1165 - main - Mk/bsd.default-versions.mk: Switch SAMBA default to 4.16

> On Jan 1, 2024, at 4:17 PM, Alexander Leidinger <Alexander@leidinger.net> wrote:
> 
> Am 2023-12-31 05:26, schrieb Muhammad Moinur Rahman:
>> The branch main has been updated by bofh:
>> URL: https://cgit.FreeBSD.org/ports/commit/?id=fabf8b5d116512e2c0339c1a17340370d753e271
>> commit fabf8b5d116512e2c0339c1a17340370d753e271
>> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>> AuthorDate: 2023-12-31 01:29:20 +0000
>> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
>> CommitDate: 2023-12-31 03:51:03 +0000
>>    Mk/bsd.default-versions.mk: Switch SAMBA default to 4.16
> 
> I have tried samba 4.16 after this commit on FreeBSD-current in a jail. This doesn't work. The samba shares are physically on zfs, which are nullfs mounted into a jail which runs samba and exports to Windows 11 and Windows 10. I can see the directory contents, but when I try to access a file (e.g. text file), Windows tells me it can not access the file. The samba log contains in the log log.<windows_host_name> the lines
> ---snip---
> [2024/01/01 16:01:16.059649,  0] ../../source3/modules/vfs_zfsacl.c:363(fget_zfsacl)
>  fget_zfsacl: fdescfs filesystem must be mounted with 'nodup' option
> ---snip---
> 
> Inside this jail I have this:
> ---snip---
> # mount -v | grep fdesc
> fdescfs on /dev/fd (fdescfs, vnodes: count 5 )
> fdescfs on /var/run/samba4/fd (fdescfs, vnodes: count 2 )
> ---snip---
> 
> The second fdescfs (in the samba pid dir) is mounted from the jail-host with the options rw,noatime,nodup.
> 
> This doesn't look to me that samba 4.16 is ready on FreeBSD to replace 4.13.
> 
> I'm aware that there is a big VFS change in samba which is the cause of this new bug, and I understand the need to change the default away from 4.13, but having the default on something which breaks valid setups will cause serious issues and wasted time.
> 
> Bye,
> Alexander.
> 
> --
> http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF
> http://www.FreeBSD.org    netchild@FreeBSD.org  : PGP 0x8F31830F9F2772BF

Hi,

I am not SAMBA expert but can you also notify this in the bug report 275224?

I will look into the possibilities of reverting. But then again so far I know
samba413 is broken with 13 and later while it worked well with 12. Or maybe
I am wrong.

Kind regards,
Moin