Re: git: ca21dddc0e31 - main - graphics/libnsgif: Update to 1.0.0

Hi all,

On Sat, 17 Feb 2024 07:26:22 +0000 Nuno Teixeira wrote:
> Did you do a consumers test?
> 
> -include/libnsgif.h
> +include/nsgif.h
> 
> graphics/imv:
> ../src/backend_libnsgif.c:9:10: fatal error: 'libnsgif.h' file not found
>     9 | #include <libnsgif.h>
> 
> Any clues on recomended way to fix?
> 
> Neel Chauhan <nc@freebsd.org> escreveu (sexta, 16/02/2024 à(s) 18:24):
> >
> > The branch main has been updated by nc:
> >
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=ca21dddc0e31a6be1db1f5966a283f52d89cddf5
> >
> > commit ca21dddc0e31a6be1db1f5966a283f52d89cddf5
> > Author:     Neel Chauhan <nc@FreeBSD.org>
> > AuthorDate: 2024-02-16 17:42:44 +0000
> > Commit:     Neel Chauhan <nc@FreeBSD.org>
> > CommitDate: 2024-02-16 18:24:27 +0000
> >
> >     graphics/libnsgif: Update to 1.0.0
> > ---
> >  graphics/libnsgif/Makefile             |  2 +-
> >  graphics/libnsgif/distinfo             |  6 +++---
> >  graphics/libnsgif/files/patch-Makefile | 10 ----------
> >  graphics/libnsgif/pkg-plist            |  4 ++--
> >  4 files changed, 6 insertions(+), 16 deletions(-)
> >
> > diff --git a/graphics/libnsgif/Makefile b/graphics/libnsgif/Makefile
> > index 09c07dda9f9a..7e0697f3b78c 100644
> > --- a/graphics/libnsgif/Makefile
> > +++ b/graphics/libnsgif/Makefile
> > @@ -1,5 +1,5 @@
> >  PORTNAME=      libnsgif
> > -PORTVERSION=   0.2.1
> > +PORTVERSION=   1.0.0
> >  CATEGORIES=    graphics
> >  MASTER_SITES=  http://download.netsurf-browser.org/libs/releases/
> >  EXTRACT_SUFX=  -src.tar.gz

skip

> > diff --git a/graphics/libnsgif/pkg-plist b/graphics/libnsgif/pkg-plist
> > index 38365be87a3a..927929719b65 100644
> > --- a/graphics/libnsgif/pkg-plist
> > +++ b/graphics/libnsgif/pkg-plist
> > @@ -1,5 +1,5 @@
> > -include/libnsgif.h
> > +include/nsgif.h
> >  lib/libnsgif.so
> > -lib/libnsgif.so.0
> > +lib/libnsgif.so.1
> >  lib/libnsgif.so.%%VERSION%%
> >  libdata/pkgconfig/libnsgif.pc

What was the reason for this commit?

Changes like this require from the maintainer to test consumer ports. Request exp-run if you can't test all consumers locally, notify other maintainers about the change (exp-run won't catch all cases), ask for help if you need it. To me committing untested stuff that breaks other ports is disrespectful to fellow maintainers and users.

Cheers,
Max