From nobody Thu Aug 29 15:18:04 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvlKJ0TLQz5PcBZ; Thu, 29 Aug 2024 15:18:12 +0000 (UTC) (envelope-from makc.freebsd@gmail.com) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvlKH5d5Jz4ppB; Thu, 29 Aug 2024 15:18:11 +0000 (UTC) (envelope-from makc.freebsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-53346132348so939691e87.2; Thu, 29 Aug 2024 08:18:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724944686; x=1725549486; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EH39dcEkqMRnWOfOo2FkrXt3n2zTLHozYLXhYOn3oos=; b=fkoEkQbrIqdHBtXIB7fGHTbn6oFWtPTf5FZGlYxIg4guInfkJw6d3fIbNsus2LWyZr eEFJFHrAAauA2saqjg5B4aS0j/qZ/XiKYTFafLmqL5kquH4aQl/VqBF5MSVtlv98qPTQ e8k5unw9t7sCWMq9ZXr3DG6iAypwn9P0pVXBCtiTMPtNwAmBNp9SDuqPz1Y/JxmyrdPc wl1e0Zmk71O9QHTgsZzz8tHR7L4N3gY1TVBFM6O0/AwviP3oeBOh6Nv6v3LrZ1disQkK Y0+QpnyRd1HVkuofsnvfXIjXcLFdyyLqzY+H/Kl7wZRVyeqUG2OX+WQnPkUeZqbNxQ1C 5OKw== X-Forwarded-Encrypted: i=1; AJvYcCVaQg6gKsNjoi7OFn3G33RWFtM6zACcQwtee+RH8LzxMYdEk3Ct5KAR+8w9Q2wj7yFFk0mcRqcMcsTbezFaDmHxxGb9EUMfqQ==@freebsd.org, AJvYcCVjCCsccdAz1hhnK0R4rbFo01fxpoYLQjRifEJcX15bMme23wNclz4YSKShWjYvCVuhnBLPh1IO5yN3etZ5tW21ReAzA9P7@freebsd.org, AJvYcCWi05Sa751QbU2rss4vPBflWBG5O41vo1+T4TbmaYwFxuD3kAgNxmCJPcKqKpEZiGBFt/CkoG0=@freebsd.org X-Gm-Message-State: AOJu0YxXpaN+0MqkP6MX84D14ObQtsS/bVJmUB3EoAlnBOn28NdiyZSG kMwBn8QZARhFAAtrXkUDmR7ropjx9CzBw34rHr6VOIWtsGnG5bmPe+y41A== X-Google-Smtp-Source: AGHT+IFf/eCJwMpiWh1dwY3IGdnOZEymqQ0/KbfQZyCw917Bx1YeCg6dxWmxyQyeGQK1Plryn8CHsg== X-Received: by 2002:a05:6512:1309:b0:52e:fcd0:241f with SMTP id 2adb3069b0e04-5353e57cbf1mr2319793e87.29.1724944686109; Thu, 29 Aug 2024 08:18:06 -0700 (PDT) Received: from mercury.localnet ([83.149.244.82]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f615171cd9sm1939001fa.94.2024.08.29.08.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 08:18:05 -0700 (PDT) From: Max Brazhnikov To: Nicola Vitale , Gleb Popov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 981929d361d7 - main - audio/pulseaudio-module-sndio: Fix an error on loading Date: Thu, 29 Aug 2024 18:18:04 +0300 Message-ID: <2397939.bDOn7JOVgO@mercury> In-Reply-To: References: <202408291300.47TD0MLL067590@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4WvlKH5d5Jz4ppB On Thu, 29 Aug 2024 16:47:43 +0300 Gleb Popov wrote: > On Thu, Aug 29, 2024 at 4:00=E2=80=AFPM Nicola Vitale = wrote: > > > > +PULSE_MODDIR!=3D ${LOCALBASE}/bin/pkg-config --variable=3Dmodlibexecdi= r libpulse > > +PULSE_VERSION!=3D ${LOCALBASE}/bin/pkg-config --modversion libp= ulse >=20 > This doesn't work when building in Poudriere, because the pkg-config > executable isn't there at the time the variable value is evaluated. > You might workaround it by adding pkg-config to PATCH_DEPENDS, but it > is still quite a non-canonical solution. It seems the port has to be rebuilt whenever pulseaudio is updated. In this= case I'd just fixed PULSE_MODDIR and PULSE_VERSION to the required values. Cheers, Max