From nobody Thu Aug 29 14:36:25 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvkPF2cFwz5PXvn; Thu, 29 Aug 2024 14:36:33 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvkPF22Tqz4lNX; Thu, 29 Aug 2024 14:36:33 +0000 (UTC) (envelope-from jrm@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724942193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S4tvv9AmmhBLXdpiQicbqqXFxY3fsWzN+eeP19jvTbQ=; b=J01Y+Iwq9rfVCphOC3bEfquQXwC2/Zm3LlS2AYCq7Z3A2lQ3NVvArAE2lI30+qroyqZGVF 45q+VotaZ5M5oYs+d7yjgQXKzG9hQz7+7h7CRrdwCVUWjNcXhUxiEQ4OG90XyW9ExaIfQ2 LIkWTOZ1AiCnTslPX5dcg237rvtxKi+/O3FF/XI1hNbXSCfvAor72tD7ei5mIEyLjvQfVx kGsYMzFofYPixF+45CvOF3JEhUxGRKzNVju2snHDZmc3O3IRLSCZGXdFvOsZ/tHskfR2Wa NzLvydzOu0GY2aEV1n/pPfl4z1CtAYcwPRQb/nGvKYyjuZUI0fk6t9zq4SjGAA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724942193; a=rsa-sha256; cv=none; b=LazEUw2kCTCKxEKl3Y/No/VESnt0jvVW3DXVMbyh0BsSVkHMoB3o9YfLLO/rucSaK0ihfQ 9M1i+pUxRK7D0idWy3ha6AEfSjwAytgQcmxPyirzhQkkfV5R/6y2imoLwk2pvs0O/DKqIb h49hGGdU91psFjzIKvLhhTqZANwWzb3irDYqHS6zfir3ty+x9FfdmYcg+Jg4oNIaA8rjLF 5owQcIgnwWK6fTWg9ppKynvJ2F0ZHXIFxZP9FS3o28ONbcUN0kvs6ZLB74yUcP6JpqAvh+ z+Lih/Rddv65IIxQfVpqORMWY7EAw1uwD530TkWS3qR1cMUBZyNF2Nb7GHZLXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724942193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S4tvv9AmmhBLXdpiQicbqqXFxY3fsWzN+eeP19jvTbQ=; b=dcRBOXWCxfwDNvLZhUNUqLgRhpm6/2eQjYbaHXYOPxD9CdORiKcKU4L68OxZvs17NPLB8t eYxwb3TvosyCl4QG7oEsQbOPk1DSubVRSflCQ4bIIPs30DDn1Kq6R4iLTR+YPzP917k4Zy 7eQjjB44TaDE7WcmJQJf29GNQkVgR2aZKLG81OiELSC9raUXe4UoVgt98+zMwHXhENfA6h LsfNIIu25LVivYYAQyqlCGV8M33umbe2L5iZYOkRR0LyYEzuObrPbgv8+PakmG9/Rhkyzw netz33jasx8dESZh/kjcYPIrE4QIynmLbg1vvCFsP1wQIOp6cZkQlr45p0vDLQ== Received: from phe.ftfl.ca.ftfl.ca (drmons0544w-207-231-233-42.dhcp-dynamic.fibreop.ns.bellaliant.net [207.231.233.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jrm/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WvkPD5mQ7zMwC; Thu, 29 Aug 2024 14:36:32 +0000 (UTC) (envelope-from jrm@freebsd.org) From: Joseph Mingrone To: Cy Schubert Cc: Mathieu Arnold , Gleb Popov , Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options In-Reply-To: <20240829124237.6E277483@slippy.cwsent.com> (Cy Schubert's message of "Thu, 29 Aug 2024 05:42:37 -0700") References: <202408281603.47SG35Q9035605@gitrepo.freebsd.org> <20240828180439.22B0730E@slippy.cwsent.com> <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> <20240829124237.6E277483@slippy.cwsent.com> Date: Thu, 29 Aug 2024 11:36:25 -0300 Message-ID: <86o75bpf9y.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Thu, 2024-08-29 at 05:42, Cy Schubert wrote: > In message <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> > , M > athieu Arnold writes: >> --t2cwj7kshsfy5exo >> Content-Type: text/plain; charset=us-ascii >> Content-Disposition: inline >> Content-Transfer-Encoding: quoted-printable >> On Wed, Aug 28, 2024 at 11:04:39AM GMT, Cy Schubert wrote: >> > In message > ail.c >> > om> >> > , Gleb Popov writes: >> > > On Wed, Aug 28, 2024 at 7:03=3DE2=3D80=3DAFPM Cy Schubert > rg> wrote: >> > > > +# In case devel/elfutils has been previously installed. >> > > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebugin= >> fod.=3D >> > > so) >> > > > +LIB_DEPENDS+=3D3D libdebuginfod.so:devel/elfutils >> > > > +.endif >> > > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in >> > > libraries that are missing, but then the "exists" condition will >> > > always be false. >> >=20 >> > Correct. The condition will always be false when building with poudriere= >> =20 >> > but for those building the port by hand, and have manually installed=20 >> > devel/elfutils prior to building and installing manually the condition wi= >> ll=20 >> > then be true. >> >=20 >> > Much committers' dismay some users don't use binary packages, you and I a= >> s=20 >> > committers prefer people use binary packages. But unfortunately this is n= >> ot=20 >> > always the case. The PR was submitted by a person who builds his ports by= >> =20 >> > hand. >> It would be better to disable the finding of libdebuginfod in LOCALBASE, >> so that everyone has the same binutils, and nobody gets a possibly >> different behavior. > In other words, just let it auto-detect? Hi Cy, It looks like there is a --with-debuginfod configure option. Could we remove the OPTIONS_RADIO and make it a single ELFU knob? Something like below would make detection of the library and the dependency on devel/elfutils deterministic. ELFU_DESC= Depend on devel/elfutils ELFU_CONFIGURE_WITH= debuginfod ELFU_LIB_DEPENDS= libdebuginfod.so:devel/elfutils Joe --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmbQh2lfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvnoSbD/4llILqs2gkrigDPVA7gl+DAtCowJTpnGLk OpU3wstH19S4eoc4jQXrG3jWapzpG1TF/8u/dRAhBJchwEBpE+SJj/ygpQhOPw2d J89kzJkdTl9YpWJOMeQpYPrJCOsVXokMqbvhXcAfvxEGps1ZBIBp26+4wH0pMdyU MEw1yQUDTeAs0lFkCoQQgzo2geUXNkhwv34rii9QkVDGt4WAr1YwYGamhH3x1GaI F4QhstJaRuKM1S49qDUKfKoW4Htmt6eNVnosC2nC1aj8Cm5ZhRrTIWab8DX1aazS 7UMDDVf/x3K3Y8rKzRdVqhROiDnMCZoanTlJYLzwqVRyw7ryZDFbsxDRApImMdrI EVJXX4sKhkmPa/vLJo+mSNsM2W/gwer0i942tXZ5p1guxOgVtI3zYoX5OX5Ba74j E2idvxfEfRY1RgPEe5WLtaMXsbXcmank1pK79xvyi3ayqoWJ3gTeEO/UkUYqtQL+ jW53WJxZ+fsMoRBXYAURrSFhj+fif6/JW29JLU9Fav7c4RQltE2rl8tdjliW4vYe Das7qPQf81hDcpy0bVnhV9hhnsbRB72+ulke8sR4OnIPcYTqwtdl4ITdzy4IM7Wg pZY8T7AXS4hGiva5JrIWVD6+A03MSfQjleXbO6pjXP0OBRRn/OnDWRgEEd9ZfUQO tu/Y2FAAZw== =lANH -----END PGP SIGNATURE----- --=-=-=--