Re: git: b634e8f3fcb1 - main - math/wxmaxima: Update to 24.08.0

From: Zsolt Udvari <uzsolt_at_freebsd.org>
Date: Wed, 28 Aug 2024 18:39:47 UTC
On Wed, Aug 28, 2024 at 05:34:44PM +0200, Fernando Apesteguía wrote:
> Did you actually run test it?
Only a little: start it, write something into window.

> $ wxmaxima
> 
> (wxmaxima:17911): Gtk-WARNING **: 17:31:34.988: Negative content height -4
> (allocation 6, extents 5x5) while allocating gadget (node button, owner
> GtkButton)
> Abort trap
I see this message, appears in previous version too (except the "Abort
trap").

> It seems awfully unstable.
> I could reproduce this just running wxmaxima -> Integrate -> OK in the
> emerging window -> select something in the text area and click with the
> right button.
I can reproduce too. Later it works.

> But basically, just clicking around a bit make it crash.
I can't reproduce now.

I test now better and for example I don't see outputs (%o1, etc.). You?
The previous version works.

I don't have time now solve it (AFK two days) so I'll revert the
changes and bump PORTEPOCH.

Really sorry for my mistake.

Cheers,
  Zsolt

> Cheers.
> 
> ---
> >  math/wxmaxima/Makefile                         |  5 ++---
> >  math/wxmaxima/distinfo                         |  6 +++---
> >  math/wxmaxima/files/patch-src_Dirstructure.cpp |  4 ++--
> >  math/wxmaxima/files/patch-src_wxMaxima.cpp     | 16 ++++++++--------
> >  math/wxmaxima/pkg-plist                        | 20 ++++++++++++++++++++
> >  5 files changed, 35 insertions(+), 16 deletions(-)
> >
> > diff --git a/math/wxmaxima/Makefile b/math/wxmaxima/Makefile
> > index d636fb6a4c27..45af449ca594 100644
> > --- a/math/wxmaxima/Makefile
> > +++ b/math/wxmaxima/Makefile
> > @@ -1,10 +1,9 @@
> >  PORTNAME=      wxmaxima
> > -PORTVERSION=   23.12.0
> >  DISTVERSIONPREFIX=     Version-
> > -PORTREVISION=  1
> > +DISTVERSION=   24.08.0
> >  CATEGORIES=    math
> >
> > -MAINTAINER=    ports@FreeBSD.org
> > +MAINTAINER=    uzsolt@FreeBSD.org
> >  COMMENT=       WxWidgets GUI for the computer algebra system maxima
> >  WWW=           https://wxmaxima-developers.github.io/wxmaxima/
> >
> > diff --git a/math/wxmaxima/distinfo b/math/wxmaxima/distinfo
> > index 620412ceb844..4f7c6b97b994 100644
> > --- a/math/wxmaxima/distinfo
> > +++ b/math/wxmaxima/distinfo
> > @@ -1,3 +1,3 @@
> > -TIMESTAMP = 1703439889
> > -SHA256 (wxMaxima-Developers-wxmaxima-Version-23.12.0_GH0.tar.gz) =
> > abec636e96474adf6451e81728b16afaa83ed1a70b86a695fa083ecec65aaae1
> > -SIZE (wxMaxima-Developers-wxmaxima-Version-23.12.0_GH0.tar.gz) = 16491009
> > +TIMESTAMP = 1724789876
> > +SHA256 (wxMaxima-Developers-wxmaxima-Version-24.08.0_GH0.tar.gz) =
> > a0957c1852ca2d93e34f8f0329673f40af065e7648739d088da28bd33627b758
> > +SIZE (wxMaxima-Developers-wxmaxima-Version-24.08.0_GH0.tar.gz) = 15868393
> > diff --git a/math/wxmaxima/files/patch-src_Dirstructure.cpp
> > b/math/wxmaxima/files/patch-src_Dirstructure.cpp
> > index 42ab59c742be..2ff43853afcd 100644
> > --- a/math/wxmaxima/files/patch-src_Dirstructure.cpp
> > +++ b/math/wxmaxima/files/patch-src_Dirstructure.cpp
> > @@ -1,6 +1,6 @@
> > ---- src/Dirstructure.cpp.orig  2023-02-19 14:20:34 UTC
> > +--- src/Dirstructure.cpp.orig  2024-08-28 07:17:18 UTC
> >  +++ src/Dirstructure.cpp
> > -@@ -120,6 +120,7 @@ wxString Dirstructure::ResourcesDir() const {
> > +@@ -121,6 +121,7 @@ wxString Dirstructure::ResourcesDir() {
> >       exepath = exe.GetPath();
> >     } else {
> >       exepath = CMAKE_INSTALL_PREFIX;
> > diff --git a/math/wxmaxima/files/patch-src_wxMaxima.cpp
> > b/math/wxmaxima/files/patch-src_wxMaxima.cpp
> > index 7f2ef251df91..8254d92e0568 100644
> > --- a/math/wxmaxima/files/patch-src_wxMaxima.cpp
> > +++ b/math/wxmaxima/files/patch-src_wxMaxima.cpp
> > @@ -1,11 +1,11 @@
> > ---- src/wxMaxima.cpp.orig      2023-12-25 16:45:03 UTC
> > +--- src/wxMaxima.cpp.orig      2024-08-28 07:18:18 UTC
> >  +++ src/wxMaxima.cpp
> > -@@ -3393,8 +3393,6 @@ void wxMaxima::VariableActionMaximaHtmldir(const
> > wxStr
> > -   wxLogMessage(_("Maxima's HTML manuals are in directory %s"),
> > -                dir_canonical.utf8_str());
> > -   GetWorksheet()->SetMaximaDocDir(dir_canonical);
> > --  GetWorksheet()->LoadHelpFileAnchors(dir_canonical,
> > --                                   GetWorksheet()->GetMaximaVersion());
> > +@@ -3520,8 +3520,6 @@ void wxMaxima::VariableActionMaximaHtmldir(const
> > wxStr
> > +   if(GetWorksheet())
> > +     {
> > +       GetWorksheet()->SetMaximaDocDir(dir_canonical);
> > +-      GetWorksheet()->LoadHelpFileAnchors(dir_canonical,
> > +-
> > m_configuration.GetMaximaVersion());
> > +     }
> >   }
> >   void wxMaxima::GnuplotCommandName(wxString gnuplot) {
> > -   m_gnuplotcommand = gnuplot;
> > diff --git a/math/wxmaxima/pkg-plist b/math/wxmaxima/pkg-plist
> > index d5768c477b18..dcbb9f7a5c89 100644
> > --- a/math/wxmaxima/pkg-plist
> > +++ b/math/wxmaxima/pkg-plist
> > @@ -56,6 +56,26 @@ share/bash-completion/completions/wxmaxima
> >  %%NLS%%share/locale/uk/LC_MESSAGES/wxMaxima.mo
> >  %%NLS%%share/locale/zh_CN/LC_MESSAGES/wxMaxima.mo
> >  %%NLS%%share/locale/zh_TW/LC_MESSAGES/wxMaxima.mo
> >
> > +share/icons/hicolor/1024x1024/apps/io.github.wxmaxima_developers.wxMaxima.png
> >
> > +share/icons/hicolor/128x128/apps/io.github.wxmaxima_developers.wxMaxima.png
> >
> > +share/icons/hicolor/150x150/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/16x16/apps/io.github.wxmaxima_developers.wxMaxima.png
> >
> > +share/icons/hicolor/192x192/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/22x22/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/24x24/apps/io.github.wxmaxima_developers.wxMaxima.png
> >
> > +share/icons/hicolor/256x256/apps/io.github.wxmaxima_developers.wxMaxima.png
> >
> > +share/icons/hicolor/310x310/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/32x32/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/36x36/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/42x42/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/44x44/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/48x48/apps/io.github.wxmaxima_developers.wxMaxima.png
> >
> > +share/icons/hicolor/512x512/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/64x64/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/72x72/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/8x8/apps/io.github.wxmaxima_developers.wxMaxima.png
> > +share/icons/hicolor/96x96/apps/io.github.wxmaxima_developers.wxMaxima.png
> >
> > +share/icons/hicolor/scalable/apps/io.github.wxmaxima_developers.wxMaxima.svg
> >  share/man/de/man1/wxmaxima.1.gz
> >  share/man/man1/wxmaxima.1.gz
> >  share/metainfo/io.github.wxmaxima_developers.wxMaxima.appdata.xml
> >