From nobody Wed Aug 28 18:04:39 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvC3v0F9gz5MTbL; Wed, 28 Aug 2024 18:04:43 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvC3t592Fz4hg0; Wed, 28 Aug 2024 18:04:42 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id jFstsVF5sMArNjN29ss7wf; Wed, 28 Aug 2024 18:04:41 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id jN27srasa2M9qjN28spDDQ; Wed, 28 Aug 2024 18:04:41 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=ce5xrWDM c=1 sm=1 tr=0 ts=66cf66b9 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=yoJbH4e0A30A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=kCjDlRWMEm2BWOwYlFQA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 26ECF1F3; Wed, 28 Aug 2024 11:04:39 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 22B0730E; Wed, 28 Aug 2024 11:04:39 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Gleb Popov cc: Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options In-reply-to: References: <202408281603.47SG35Q9035605@gitrepo.freebsd.org> Comments: In-reply-to Gleb Popov message dated "Wed, 28 Aug 2024 20:55:38 +0300." List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 28 Aug 2024 11:04:39 -0700 Message-Id: <20240828180439.22B0730E@slippy.cwsent.com> X-CMAE-Envelope: MS4xfAl2C36M1AcKU7UnNfkBto1x1cWd+IMSkJc/DGd6bQELJdyDvJD8U2XC8+gemZCaDagPYDhm0vTZoP5Okp7L99eNNUcsIP4xn+zX+vHRagrolYQ/g1sd yS3p6S7EB6rRM3gXdz/kV6CF6N++YQFvx6P/1X4kKnV0DYxFbkBCBPE9VmTdRPAA/aLhbFUEGB7QYCFp4Jj5YuGVzZcNDfyhxBjyHc8pmXuKKKk7wmqeXum4 NUhWA3ekV5hWGpNZtcYcnZ4y4TTPY/jZBLV91Jy/1pimjhbIK0q6DvFmfbEdxvtb/1w3dPfF+4VFgsEkIMx3JWmTzVh0mdkV9QOiUoIA2WQSKDkciSGD6sMn CxPiWCr7b1R91n3pWrN2WeUNHbHs1Q== X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4WvC3t592Fz4hg0 In message , Gleb Popov writes: > On Wed, Aug 28, 2024 at 7:03=E2=80=AFPM Cy Schubert wrote: > > > > +# In case devel/elfutils has been previously installed. > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebuginfod.= > so) > > +LIB_DEPENDS+=3D libdebuginfod.so:devel/elfutils > > +.endif > > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in > libraries that are missing, but then the "exists" condition will > always be false. Correct. The condition will always be false when building with poudriere but for those building the port by hand, and have manually installed devel/elfutils prior to building and installing manually the condition will then be true. Much committers' dismay some users don't use binary packages, you and I as committers prefer people use binary packages. But unfortunately this is not always the case. The PR was submitted by a person who builds his ports by hand. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0