From nobody Thu Aug 08 07:52:42 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WffQz1Krjz5SnjM; Thu, 08 Aug 2024 07:52:43 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WffQz0b86z4l1t; Thu, 8 Aug 2024 07:52:43 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723103563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LBhtLbRoYysRLuabRCl5m+/j/Qipt1YAxqTrSjtC0Cs=; b=wrvmGTpJCtyffB/y3rbfIvjej9VMON73CYOtZJNoVW2Czsxg92GdyJ4XVXpvtm9+fmfp8m I+olRSbyAnq5SgvozSiAiIBrEJCtcqUuGEXf6IsgvFDi1Lig0uIduyz09Xhm1vfJFHV91u XDsARsBUboXbv9rkXGLdnnnCbPuSrEBPYeIxMWJ0oh9qOW73rZjbACwVd0amb/NpWQdy0h R6HgCXf3GzvZKgjL7n6xiWlMILe0J+3eluK0zoHvc/uWNnrAxkat8dCxXn+uJbrtf5nJ2+ IgCMBSs6jYshddLcEZVuUs5DBfOyIYNkhPogcS63QmmjewjSU/41oUkRZQdnng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723103563; a=rsa-sha256; cv=none; b=Hh8ZvfAqrROh5x+jjTCOPB0MaITaqUiAMnvLLMWoW95Ic1gtMEQ9rnNb77zCNaGk+6eDZJ 2SCHvoJhYZGxmt4guBL1GsC78Tsan+fbFS3HC7jSoRRJ4lf3GggpckFGBANv/V2CoVwI9a /c6xjIivT12HcEzi89l/qD4k3v6x3/BZe4paV/IFA6bt8k7wf88qodrAmz9Fn4ptS3NyAW QqCesQnfgC7DGVhM3ulp4y4jjAvrpr3SAEbx2EAwwOhcB2s9eRPiXiGVN8fb+QfeVzdHna p3LfHwvA26NNtrvPb5Hx3VxWj3fZsBnStmMXccUm5civf/Ftk43jSozaiiB4cg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723103563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LBhtLbRoYysRLuabRCl5m+/j/Qipt1YAxqTrSjtC0Cs=; b=p55ylOtQl9QLKw+8v/4s2wT0VEO1LE+A185Uy1dEejiy05bG1LJ1ycPVGeHRrRfiTpe7KB B+ejDwxi2kKHfNw5b6gmasknO/hBDqiPX2Et/YggtNKAfsgCwuW9/GGfIQCICEKCOAiykV dPsCtP4mpm5Og5vrVwwb2mrkz0HfVeq8iBBHzILLk7kV1/JRMCHBLQcqet1d1NIYUM4uRO LemwsamoKJMmbgM578HdCcwmhi5VnOFDM71g6xOnvT/0gtKo79IVjtV62QXrUZ8f09X4+S ux2K81Xylq/xpV/050LkIVouvZwWOh4bJJoh1RXOnX/MhsoGcjNyOYyr15w18A== Received: by freefall.freebsd.org (Postfix, from userid 1033) id F19C77986; Thu, 08 Aug 2024 07:52:42 +0000 (UTC) Date: Thu, 8 Aug 2024 07:52:42 +0000 From: Alexey Dokuchaev To: "Jason E. Hale" Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6c2f347f45e4 - main - devel/abseil: update Abseil C++ to LTS version 20240722.0 Message-ID: References: <202408070601.47761HrZ051940@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 07, 2024 at 11:56:30PM -0400, Jason E. Hale wrote: > On Wed, Aug 7, 2024 at 2:01???AM Alexey Dokuchaev wrote: > > commit 6c2f347f45e45cd71bb0aa7fdcaa96667c5a483b > > > > devel/abseil: update Abseil C++ to LTS version 20240722.0 > > > > ... > > +USES= cmake compiler:c++17-lang pathfix > > CMAKE_ARGS= -DBUILD_SHARED_LIBS:BOOL=ON \ > > -DCMAKE_CXX_STANDARD=17 # force the same highest ... > > Is there anything preventing > CMAKE_ARGS+=-DABSL_PROPAGATE_CXX_STD:BOOL=ON from being set for > dependencies such as devel/libphonenumber? Nothing, I guess, I simply didn't know about this knob, which is a rather lame excuse because it says quite loud in the build log: CMake Warning at CMakeLists.txt:52 (message): A future Abseil release will default ABSL_PROPAGATE_CXX_STD to ON for CMake 3.8 and up. We recommend enabling this option to ensure your project still builds correctly. > It would be nice to get rid of the current workaround in that port. Sure thing, I'll add it. It would probably require to rebuild all dependent ports again to check that nothing breaks which might take time though. :( Thanks for letting me know! ./danfe