Re: git: 6c2f347f45e4 - main - devel/abseil: update Abseil C++ to LTS version 20240722.0

On Wed, Aug 7, 2024 at 2:01 AM Alexey Dokuchaev <danfe@freebsd.org> wrote:
>
> The branch main has been updated by danfe:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=6c2f347f45e45cd71bb0aa7fdcaa96667c5a483b
>
> commit 6c2f347f45e45cd71bb0aa7fdcaa96667c5a483b
> Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
> AuthorDate: 2024-08-07 06:00:30 +0000
> Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
> CommitDate: 2024-08-07 06:00:30 +0000
>
>     devel/abseil: update Abseil C++ to LTS version 20240722.0
>
>     Switch to the "real" distfile over the GitHub-generated one
>     and fix the warning emitted by `fixup-lib-pkgconfig' target.
>
>     PR:             275887
>     Reported by:    portscout
> ---
>  devel/abseil/Makefile  | 14 ++++-----
>  devel/abseil/distinfo  |  6 ++--
>  devel/abseil/pkg-plist | 85 ++++++++++++++++++++++++++++++++++++++------------
>  3 files changed, 75 insertions(+), 30 deletions(-)
>
> diff --git a/devel/abseil/Makefile b/devel/abseil/Makefile
> index 427f8bd15c48..54b2627b5f65 100644
> --- a/devel/abseil/Makefile
> +++ b/devel/abseil/Makefile
> @@ -1,6 +1,8 @@
>  PORTNAME=      abseil
> -PORTVERSION=   20230125.3
> +PORTVERSION=   20240722.0
>  CATEGORIES=    devel
> +MASTER_SITES=  https://github.com/abseil/abseil-cpp/releases/download/${PORTVERSION}/
> +DISTNAME=      ${PORTNAME}-cpp-${PORTVERSION}
>
>  MAINTAINER=    danfe@FreeBSD.org
>  COMMENT=       Abseil Common Libraries (C++)
> @@ -8,15 +10,13 @@ WWW=         https://abseil.io/
>
>  LICENSE=       APACHE20
>
> -USES=          cmake compiler:c++17-lang
> -USE_GITHUB=    yes
> -GH_PROJECT=    ${PORTNAME}-cpp
> -
> +USES=          cmake compiler:c++17-lang pathfix
>  CMAKE_ARGS=    -DBUILD_SHARED_LIBS:BOOL=ON \
>                 -DCMAKE_CXX_STANDARD=17 # force the same highest C++ standard because of ABI differences: see https://github.com/abseil/abseil-cpp/issues/819
> +PATHFIX_CMAKELISTSTXT= AbseilHelpers.cmake
>
> -_GET_SOVER=    ${GREP} SOVERSION ${WRKSRC}/CMake/AbseilHelpers.cmake 2>/dev/null \
> -               | ${CUT} -d\" -f2
> +_GET_SOVER=    ${GREP} ABSL_SOVERSION ${WRKSRC}/CMakeLists.txt \
> +               2>/dev/null | ${CUT} -d\" -f2
>  PLIST_SUB+=    LIBSUFX=${_GET_SOVER:sh}
>
>  .include <bsd.port.mk>

Is there anything preventing
CMAKE_ARGS+=-DABSL_PROPAGATE_CXX_STD:BOOL=ON from being set for
dependencies such as devel/libphonenumber? It would be nice to get rid
of the current workaround in that port.

- Jason