Re: git: e710744f6c83 - main - graphics/GraphicsMagick: Update to 1.3.43

On Fri, Apr 19, 2024 at 12:21 AM Vladimir Druzenko <vvd@freebsd.org> wrote:

> 18.04.2024 15:53, Po-Chuan Hsieh пишет:
> > The branch main has been updated by sunpoet:
> >
> > URL:
> https://cgit.FreeBSD.org/ports/commit/?id=e710744f6c835f2b99cbfca56d523d46109e63b0
> >
> > commit e710744f6c835f2b99cbfca56d523d46109e63b0
> > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > AuthorDate: 2024-04-18 12:47:58 +0000
> > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > CommitDate: 2024-04-18 12:47:58 +0000
> >
> >      graphics/GraphicsMagick: Update to 1.3.43
> >
> >      Changes:        http://www.graphicsmagick.org/NEWS.html
> > ---
> >   graphics/GraphicsMagick/Makefile                 |  5 +-
> >   graphics/GraphicsMagick/distinfo                 |  6 +--
> >   graphics/GraphicsMagick/files/patch-Makefile.in  | 11 ----
> >   graphics/GraphicsMagick/files/patch-coders_jxl.c | 63
> ----------------------
> >   graphics/GraphicsMagick/files/patch-configure    | 28 +++-------
> >   graphics/GraphicsMagick/files/patch-jpeg-turbo   | 67
> ------------------------
> >   graphics/GraphicsMagick/pkg-plist                | 11 ++--
> >   7 files changed, 20 insertions(+), 171 deletions(-)
> >
> > diff --git a/graphics/GraphicsMagick/Makefile
> b/graphics/GraphicsMagick/Makefile
> > index be2ef664e5cf..98b9b182def1 100644
> > --- a/graphics/GraphicsMagick/Makefile
> > +++ b/graphics/GraphicsMagick/Makefile
> > @@ -1,6 +1,5 @@
> >   PORTNAME=   GraphicsMagick
> > -PORTVERSION= 1.3.40
> > -PORTREVISION=        5
> > +PORTVERSION= 1.3.43
> >   PORTEPOCH=  1
> >   CATEGORIES= graphics
> >   MASTER_SITES=       SF
> > @@ -11,7 +10,7 @@ WWW=                http://www.graphicsmagick.org/
> >
> >   LICENSE=    MIT
> >
> > -USES=                cpe libtool localbase pathfix pkgconfig tar:zst
> > +USES=                cpe libtool localbase pathfix pkgconfig tar:xz
> >
> >   CONFIGURE_ARGS=     --enable-shared --enable-static \
> >               --with-windows-font-dir=${WINDOWS_FONT_DIR} \
>
> Hello!
>
> Build fails with FPX option on:
>
> > libtool: link: cc -fopenmp -O2 -pipe -march=nehalem
> > -fstack-protector-strong -isystem /usr/local/include
> > -fno-strict-aliasing -Wall -D_THREAD_SAFE -fstack-protector-strong
> > -fstack-protector-strong -o utilities/.libs/gm utilities/gm.o
> > -L/usr/local/lib magick/.libs/libGraphicsMagick.so -ljasper -lwmflite
> > -ljxl -ljxl_threads -ltiff -ljbig -lsharpyuv -lwebp -lwebpmux
> > -lfreetype -ljpeg -lpng16 -llcms2 -llcms2_fast_float -llcms2_threaded
> > -lXext -lSM -lICE -lX11 -lxml2 -llzma -lbz2 -lz -lm -lpthread -lomp
> > -fopenmp -Wl,-rpath -Wl,/usr/local/lib
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_InitSystem
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_SetToolkitMemoryLimit
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_ClearSystem
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_OpenImageByFilename
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_GetSummaryInformation
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_GetImageResultAspectRatio
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_CloseImage
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_SetResampleMethod
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_ReadImageRectangle
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_ReadImageTransformRectangle
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_CreateImageByFilename
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_SetJPEGCompression
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_SetSummaryInformation
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> >
> > ld: error: undefined reference due to --no-allow-shlib-undefined:
> > FPX_WriteImageLine
> > >>> referenced by magick/.libs/libGraphicsMagick.so
> > cc: error: linker command failed with exit code 1 (use -v to see
> > invocation)
> > *** [utilities/gm] Error code 1
>
>
> Fixed with patch:
> -USES=           cpe libtool localbase pathfix pkgconfig tar:xz
> +USES=           cpe libtool localbase:ldflags pathfix pkgconfig tar:xz
> +FPX_LDFLAGS=            -lfpx
>
> Tested on 13.3-p1 amd64 in poudriere and on live system.
>
> If you agree I can commit self.
>
> --
> Best regards,
> Vladimir Druzenko
>

Fixed in ports f57677209d3a6981cbb5e2bceba03c37ea2f65a8. Thanks.
However, I'd like to remove it. I wonder if people really use fpx nowadays.