Re: git: 0660187ad07f - main - cleanup: remove occurrences of WITH_DEBUG

From: Max Brazhnikov <makc_at_freebsd.org>
Date: Fri, 12 Apr 2024 09:41:09 UTC
I don't quite understand something about ports options and features.

Can we have the same knob as an option and as a feature?

For example, graphics/glaxnimate has DEBUG in the OPTIONS_DEFINE and
the following lines in the Makefile:

.if !${PORT_OPTIONS:MDEBUG}
CXXFLAGS:=      ${CXXFLAGS:C/-O([2-9]|[sz]|fast)/-O1/}
-fstack-protector-strong -fno-strict-aliasing
.endif

Now to build this port in the debug mode I have to set WITH_DEBUG and
enable DEBUG option at the same time.

We should either disallow having DEBUG in the options and check only
for WITH_DEBUG everywhere,
or WITH_DEBUG feature should set DEBUG option automatically.

Max