From nobody Sun Oct 15 17:15:29 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S7n2B1L35z4xBD1; Sun, 15 Oct 2023 17:15:46 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S7n273Hw7z4Xc7; Sun, 15 Oct 2023 17:15:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=VUSfDsfM; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::c30 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oo1-xc30.google.com with SMTP id 006d021491bc7-57f02eeabcaso2398955eaf.0; Sun, 15 Oct 2023 10:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697390141; x=1697994941; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BUl4o6dX/OvSaR7j8/JrIeyy8/IwzHh/2aQvJNqaxfs=; b=VUSfDsfMpJykG6AnxHxr+/+gKLQWZOq2rXeBi8LSzbxHqLpD/GuKm9k3IhQ458npjv 0J0pSr9g5DU9XbUxEMKz5Qwj89OHSODJfLdRMkkE+LRBGD5uwkPbCHUYqoKvibK4Xo8l v2MkGbkm7MOIksbWIpHawvdgUq6dGSwObdjILDRgOC25m1vIPl9bwvMUxn6Ir0ZALjtM nKqOUTGaXhUQUt7MZlOrZn69ubOaTrEHiGN1uMmS4pq3VhUZBI4xnMRa7glPLn6+qT4R 4sLkL0NuMlgtaH0nT00RoVWF+knLVO0ZNtgQYhmPQh0Ig0N9Qx/M4V+hPprSdTzsv99J VxyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697390141; x=1697994941; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BUl4o6dX/OvSaR7j8/JrIeyy8/IwzHh/2aQvJNqaxfs=; b=e7IgotWQbR86PcDn+Md3S4RQ91GdE0UGJ5toK0YElCibiR5nukENLjHpXLwg9NjAr6 5sZtXYlX4iIl+dMbudIY3K/DE5zlOm6rCvMihqAaD1GaJoqss1l44gP3/aZHaIbQGJN9 AwLAdKQHTWfFAH6jhl4cMFE3zuEVwd1R+1xvLuBF6p0P4zKi613KsL/BWqzLFXHBw1Yy Fpm1Bwx7FDBdCzZe2O2+v+gmou20M1074pik7ihJAC0FptJlYhwFurRgV8LeHBMBmkRM qPRxfil5dEndruT1sAJgIs8qeEMcdI/xvPGfmVBGF2MUDrSuPZukC2et7Ej2Fua37ZFc o15A== X-Gm-Message-State: AOJu0YzziRfOIjen2QRsxwyA6unGGG3VSfHsBMtRg+mDSxo4c/PDyOwd aBCT1qNT6Lj4H6a/hlQF8lRTTdguvl5xLw== X-Google-Smtp-Source: AGHT+IF9QcIhWrwcS5hkmy+yWJggE5kGPeyolVLlbjoaDoBaI2sAHyP7wcei4KbIfsUd9Nq/N+ydBg== X-Received: by 2002:a05:6358:2605:b0:12b:e45b:3fac with SMTP id l5-20020a056358260500b0012be45b3facmr34915489rwc.32.1697390141392; Sun, 15 Oct 2023 10:15:41 -0700 (PDT) Received: from smtpclient.apple (c-73-35-248-51.hsd1.wa.comcast.net. [73.35.248.51]) by smtp.gmail.com with ESMTPSA id z23-20020a63ac57000000b00577f8f4df6bsm6385806pgn.18.2023.10.15.10.15.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Oct 2023 10:15:40 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_3B86D10A-2D64-4058-9E37-74F486C36C74"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: git: 9204fb371cbe - main - default-versions: add rust-bootstrap to RUST section From: Enji Cooper In-Reply-To: <6808f1da-fead-46de-8328-74bc30ba51f2@freebsd.org> Date: Sun, 15 Oct 2023 10:15:29 -0700 Cc: Enji Cooper , "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" Message-Id: <7D9F1312-17EA-4AD9-B5D6-E3DDC8874074@gmail.com> References: <202310030450.3934oxqI028852@gitrepo.freebsd.org> <6808f1da-fead-46de-8328-74bc30ba51f2@freebsd.org> To: Charlie Li X-Mailer: Apple Mail (2.3731.700.6) X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.60 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::c30:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4S7n273Hw7z4Xc7 --Apple-Mail=_3B86D10A-2D64-4058-9E37-74F486C36C74 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi Charlie, > On Oct 2, 2023, at 11:05 PM, Charlie Li wrote: >=20 > Enji Cooper wrote: >> default-versions: add rust-bootstrap to RUST section >> lang/rust-bootstrap is another potential option for RUST. >> document the value in the comment so others might consider its = use. >>=20 > There are some choice words about this part that I will spare the room = for now. >> lang/rust-bootstrap has more tunable knobs which allow for more = minimal >> builds of the rust toolchain than lang/rust -- which may be = desirable >> for appliance or iterative builds. >>=20 > [citation needed]: no OPTIONS exist, amongst other things. >=20 > Ultimately this doesn't make sense. This port has one purpose, for = providing a bootstrap toolchain to build the full lang/rust or the = tarball outside of the ports framework. "Appliance or iterative builds" = fall under the general purpose category. Not only is there a "circular" = dependency on the full lang/rust to bootstrap this port, but both = rust-std and cargo are built regardless and are required for the = toolchain to work at all; neither are light or minimal by any means. = cargo especially uses many dependent crates that use the FFI to link to = libraries provided by other ports or base or bundled. Finally, the built = results are installed/staged into a special bootstrap hierarchy, and not = a more "standard" one, for which the singular use case could not be more = obvious. Ok. It would be nice if I had known that earlier.. FWIW, I thought this = would have solved the lang/rust bootstrapping problem at work, but it = didn=E2=80=99t. >> Approved by: portmgr (bapt) >> Reviewed by: allanjude, bapt >> Differential Revision: https://reviews.freebsd.org/D42052 > Why was rust@ conveniently bypassed here? That was purely an oversight. I am not a ports committer and am not = really aware of the rust ports cadre and didn=E2=80=99t think to look = first, so I failed to include rust@. I apologize for that. I see that tobik@ reverted the change later. I agree that was the right = thing to do, but it would be helpful if there was a comment somewhere = noting that rust-bootstrap shouldn=E2=80=99t be used for = `DEFAULT_VERSIONS+=3D rust=3D`, even if it=E2=80=99s in the = bsd.default-versions.mk code itself (checking for valid versions), or a = separate USES+=3D rust file. If a check or comment had been in there = sooner, I would have known that value was invalid and wouldn=E2=80=99t = have bothered with suggesting the change in the first place (and it = would have saved me a day or two of wasted time at $work). Thank you, -Enji --Apple-Mail=_3B86D10A-2D64-4058-9E37-74F486C36C74 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEtvtxN6kOllEF3nmX5JFNMZeDGN4FAmUsHjEACgkQ5JFNMZeD GN62axAAm3GHj6EEeh9wLt6USP23s9UcLk7i5VnddxKPpSQjXAgbLgG4fnQ7jkqw 9H4wNubrMTou+x4EzJlEanSUaBP1WrYLyOWAbMWh2/deHatz/M5XAls0U+MmKlGt PP2WEDRbfrmsEF7BrXNr19tjhn5feTbQ/JtXncH7QLOM1T2rcMqfHv/sQoi9tyV2 scKx4OfxqxKX5nhCOWMnNeoTvsD05rhLX7zEICbW1h7CTu6FSbEjhya/uNLG+nLX 27rijToBBsZJ5omGEA0wpg9TuArCXK7ih7Q+NLlSdjNFpc3seQNC/DseS6mxxzz2 BLPkNQn1pMWgSc41COF5qzU/ykdvP+aiqztbBfeAX98ZY5sz6VQvy6UbzZDtptyn MILTXJmmV4dXSChUUy75JU+1cTQ5b7A2XoaA5MRapCEpnICV3HNmqWNFh+u8ScxD mg2zfKBXZa74Na4jSC0vPmzJ64SpYzrVFS/krC8igzlx8LMTAi7c8iumEk+Cc5Kq EW1961HOyUIiHaVK2tG3th9+/zpGdQ2gYBBk8BaCSjZ8XIkGtYLRwKEjl5nol36e Uc2bgYyng9r2CSTGJtzOBh5t5D4yfYsUzVIumOkKZp5MaJ3yCaaNgDn6t6LMiqUh z7XDWOwYStBaRGg3L9e0s055M88Wid84p7Lze+jDDc16tTjJnnM= =RKDx -----END PGP SIGNATURE----- --Apple-Mail=_3B86D10A-2D64-4058-9E37-74F486C36C74--