Re: git: 3f47a0b1eb91 - main - converters/wkhtmltopdf: Fix build with gcc10

From: Moin Rahman <bofh_at_freebsd.org>
Date: Thu, 23 Nov 2023 10:12:48 UTC

> On Nov 23, 2023, at 2:22 AM, Gerald Pfeifer <gerald@pfeifer.com> wrote:
> 
> On Mon, 20 Nov 2023, Muhammad Moinur Rahman wrote:
>>    converters/wkhtmltopdf: Fix build with gcc10
> 
> That's a good move, from GCC 8 at least to GCC 10, thank you!
> 
> Would it also work with GCC 11 or, preferrably, GCC 12 now?
I started testing with 13 and stopped at 10 when it worked. :P
> 
> Did you intentionally adjust the deprecation date to 2023-12-31 before the
> next quarterly branch is cut? No objection, though it could have given
> folks using such branches a safety net to use 2024-01-15 instead.

For gcc8 yes. That is indeed true. But as we are also removing 12 support
before next quarter it makes a little bit sense to me for faster removal.
So far from experience the build/update time for an entire pkg set in 12
is around 3.5-5 days compared to 2.5-3.5 days in 13 and 14. So after we
create the quarterly it will be there in no time or less than 4 days. As
the build times are reducing with the improvements of compilers I believe
we should not plan on thinking about the safety net any more. But it's just
my observation and experience and am open for discussion.


> Gerald