git: 9b214a66ea87 - main - x11-toolkits/wxgtk32: fix build with lld 17
Date: Thu, 09 Nov 2023 19:32:51 UTC
The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=9b214a66ea8788a6da299139decf506a4b4f5ff1 commit 9b214a66ea8788a6da299139decf506a4b4f5ff1 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2023-11-09 19:26:44 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2023-11-09 19:32:02 +0000 x11-toolkits/wxgtk32: fix build with lld 17 Building x11-toolkits/wxgtk32 with lld 17 results in the following link errors: ld: error: version script assignment of 'WXU_3.2.1' to symbol 'wxApp::GTKAllowDiagnosticsControl()' failed: symbol not defined ld: error: version script assignment of 'WXU_3.2.1' to symbol 'wxFileDialog::AddShortcut(const wxString&, int)' failed: symbol not defined Add -Wl,--undefined-version to LDFLAGS to suppress these errors, since wxWidgets reuses the same linker version script for all its shared libraries. PR: 273753 Approved by: blanket (desktop) MFH: 2023Q4 --- x11-toolkits/wxgtk32/Makefile | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/x11-toolkits/wxgtk32/Makefile b/x11-toolkits/wxgtk32/Makefile index 934fd79c649b..794704329f2a 100644 --- a/x11-toolkits/wxgtk32/Makefile +++ b/x11-toolkits/wxgtk32/Makefile @@ -108,6 +108,11 @@ CONFIGURE_ARGS+=--disable-tls CONFIGURE_ARGS+=--disable-precomp-headers .endif +# wxWidgets uses the same linker version script for all its shared libraries, so +# some symbols are expectedly undefined. Suppress errors with lld >= 17 due to +# these undefined symbols. +LDFLAGS+= -Wl,--undefined-version + post-build-NLS-on: @${DO_MAKE_BUILD} allmo -C ${BUILD_WRKSRC}/locale