git: 3a94457ab044 - 2023Q4 - www/qt6-webengine: Really disable PCH
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 06 Nov 2023 20:51:11 UTC
The branch 2023Q4 has been updated by jhale:
URL: https://cgit.FreeBSD.org/ports/commit/?id=3a94457ab0440aa3a9384700c9e108272f0b3aa0
commit 3a94457ab0440aa3a9384700c9e108272f0b3aa0
Author: Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2023-11-06 19:53:12 +0000
Commit: Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2023-11-06 20:51:06 +0000
www/qt6-webengine: Really disable PCH
Due to the way qt_evaluate_config_expression()[1] parses conditions,
De Morgan's Laws do not apply. This function is internal to the Qt
build process and this behavior may be by design for simplicity.
NOT (A OR B) defies logic and always evaluates to NOT A OR B, so we
must express this as NOT A AND NOT B instead to get the desired result.
Disabling PCH (pre-compiled headers) greatly decreases build time,
especially with ccache and should fix the build on arm64 (not tested).
../../../../../qtwebengine-everywhere-src-6.5.3/src/3rdparty/chromium/base/strings/string_util.h:51:3:
error: non-const lvalue reference to type '__builtin_va_list' cannot bind to a value of unrelated type 'va_list' (aka 'std::__va_list')
va_start(arguments, format);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/sys/_stdarg.h:45:49: note: expanded from macro 'va_start'
#define va_start(ap, last) __builtin_va_start((ap), (last))
^~~~
[1] https://code.qt.io/cgit/qt/qtbase.git/tree/cmake/QtFeature.cmake?h=6.5.3#n84
(cherry picked from commit 089da4a7a764183a8d63d22dedc12537f90b50db)
---
www/qt6-webengine/files/patch-cmake_Functions.cmake | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/qt6-webengine/files/patch-cmake_Functions.cmake b/www/qt6-webengine/files/patch-cmake_Functions.cmake
index 2ebeb4684add..919c24219f0b 100644
--- a/www/qt6-webengine/files/patch-cmake_Functions.cmake
+++ b/www/qt6-webengine/files/patch-cmake_Functions.cmake
@@ -23,7 +23,7 @@
extend_gn_list(gnArgArg
ARGS enable_precompiled_headers
- CONDITION BUILD_WITH_PCH AND NOT LINUX
-+ CONDITION BUILD_WITH_PCH AND NOT (LINUX OR FREEBSD)
++ CONDITION BUILD_WITH_PCH AND NOT LINUX AND NOT FREEBSD
)
extend_gn_list(gnArgArg
ARGS dcheck_always_on