From nobody Sun May 21 07:29:37 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QPC031HTBz4C9vQ; Sun, 21 May 2023 07:29:55 +0000 (UTC) (envelope-from developer@lorenzosalvadore.it) Received: from mail-4018.proton.ch (mail-4018.proton.ch [185.70.40.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QPC0250qcz3qhC; Sun, 21 May 2023 07:29:54 +0000 (UTC) (envelope-from developer@lorenzosalvadore.it) Authentication-Results: mx1.freebsd.org; none Date: Sun, 21 May 2023 07:29:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lorenzosalvadore.it; s=protonmail2; t=1684654192; x=1684913392; bh=otIoW6EMdU7U/q+S6gUp2tRlnIwWgvbOcCkHOQBt1Do=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ewNjqX6BBsM8103JHoWflWqBWpuEI9D2qoAMQH28NXGzgy3zH46nLFr3TnNwNYjaH et4cKBQnQkcd7AxvsYc7LCasSRVREUhy2FV2aNAacG2LiLHXGmYfm0NUXD0u7AFrG5 tX7Ip4RMp4CXpkHPw8uIWleBN9hui5aZjLQ2gPuwtj0Ae8+jn1WCjYMD0pXdSkXbyU XMHGARleeDjuVXB8fiEy0didI1EKB+zuF+3h+4Wi780nQABp91buUmSStPlNUCuDez 7k6kFa1ePqGPPd1RwKsKIF2n1lwtAHTN/YUEQHWvT3bscPioBttvsIkhIWdvc4jZNs vDu8niPi1w/ww== To: Rene Ladan From: Lorenzo Salvadore Cc: Lorenzo Salvadore , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 779e8ab2600f - main - lang/gcc12-devel: Fix enable init_array patch Message-ID: In-Reply-To: References: <202305201418.34KEI8Ii081953@gitrepo.freebsd.org> Feedback-ID: 53711648:user:proton List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4QPC0250qcz3qhC X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:62371, ipnet:185.70.40.0/24, country:CH] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N ------- Original Message ------- On Saturday, May 20th, 2023 at 6:01 PM, Rene Ladan wrote= : > > > On Sat, May 20, 2023 at 02:18:08PM +0000, Lorenzo Salvadore wrote: > > > The branch main has been updated by salvadore: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D779e8ab2600fba5f045d80= a1420f9f2278daad62 > > > > commit 779e8ab2600fba5f045d80a1420f9f2278daad62 > > Author: Lorenzo Salvadore salvadore@FreeBSD.org > > AuthorDate: 2023-05-20 00:38:33 +0000 > > Commit: Lorenzo Salvadore salvadore@FreeBSD.org > > CommitDate: 2023-05-20 14:17:36 +0000 > > > > lang/gcc12-devel: Fix enable init_array patch > > > > Add an error line that was missing in case _FreeBSD_version < 1000010. > > > > Reported by: gnikl@users.sourceforge.net > > Fixes: 8c2a479977f0 lang/gcc12-devel: Enable support for .init_array an= d .fini_array > > > A bit late, but why check for FreeBSD versions that are end-of-life for a= t > least five years instead of just unconditionally enabling them? For consistency with upstream. Upstream does such kind of checks for glibc = and Solaris, so I have added a similar check for FreeBSD to increase the chance= s to have the patch merged upstream. I should probably have written it in the original commit message, I am sorr= y I have forgotten it. Anyway, if I manage to get the patch upstreamed, then = the corresponding files in the ports tree will not be needed any more, so it sh= ould not be a big deal hopefully. Cheers, Lorenzo Salvadore