Re: git: 0eb6406f6594 - main - devel/opencl: Update OpenCL to 3.0.14

From: O. Hartmann <o.hartmann_at_walstatt.org>
Date: Fri, 05 May 2023 16:09:21 UTC
Am Fri, 5 May 2023 09:37:58 +0200
Fernando Apesteguía <fernape@freebsd.org> schrieb:

Hello,

sorry for the breakage. I found the reason why the poudriere build didn't fail on CURRENT
here, my bad. 

In the Makefile provided, there needs to be 

[WORKING] CONFIGURE_ARGS+=--enable-official-khronos-headers 

instead of the provided 

[NONWORKING] CONFIGURE_ARGS+=--disable-official-khronos-headers.

Several ICDs come (and came) with their own copy of Khronos OCL headers, they are outdated and
I guess (just a hunch right now) make is picking then outdated headers.

I compiled successfully on CURRENT by setting 

--enable-official-khronos-headers

I have no chance this weekend to compile a clean ports tree, since my personal hardware is a
bit outdated. I'll provide a new/updated patchset for devel/ocl-icd immediately, but need some
help in checking from your side whether it will compile on all supported platforms.

Thanks in advance,

O. Hartmann





> On Fri, May 5, 2023 at 9:25 AM Craig Leres <leres@freebsd.org> wrote:
> 
> > On 5/5/23 00:14, Fernando Apesteguía wrote:  
> > >
> > >
> > > On Thu, May 4, 2023 at 9:29 PM Craig Leres <leres@freebsd.org
> > > <mailto:leres@freebsd.org>> wrote:
> > >
> > >     On 5/3/23 01:05, Fernando Apesteguía wrote:  
> > >      > The branch main has been updated by fernape:
> > >      >
> > >      >  
> > >     URL:  
> > https://cgit.FreeBSD.org/ports/commit/?id=0eb6406f6594c96bef9b692cd7e4fa763a653cd7
> > <
> > https://cgit.FreeBSD.org/ports/commit/?id=0eb6406f6594c96bef9b692cd7e4fa763a653cd7  
> > >  
> > >      >
> > >      > commit 0eb6406f6594c96bef9b692cd7e4fa763a653cd7
> > >      > Author:     O. Hartmann<ohartmann@walstatt.org  
> > >     <mailto:ohartmann@walstatt.org>>  
> > >      > AuthorDate: 2023-05-02 10:38:39 +0000
> > >      > Commit:     Fernando Apesteguía<fernape@FreeBSD.org>
> > >      > CommitDate: 2023-05-03 08:01:08 +0000
> > >      >
> > >      >      devel/opencl: Update OpenCL to 3.0.14
> > >      >
> > >      >      PR:             271158
> > >      >      Reported by:ohartmann@walstatt.org  
> > >     <mailto:by%3Aohartmann@walstatt.org>  (maintainer)  
> > >      > ---  
> > >
> > >     Unfortunately this breaks building devel/ocl-icd for me (see  
> > appended).  
> > >     Looks like some things ocl-icd was defining in (ocl-idcd)
> > >     ocl_icd_loader.c are conflicting with a new version in (opencl)
> > >     CL/cl_ext.h.
> > >
> > >
> > > Can you try this patch
> > > https://people.freebsd.org/~fernape/patches/devel_ocl-icd.patch
> > > <https://people.freebsd.org/~fernape/patches/devel_ocl-icd.patch>
> > >
> > > I was able to build in 12.4 {adm64,i386}, 13.1 amd64 and -current(ish)  
> > amd64
> >
> > That fixes my build (13.2 amd64).
> >  
> 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271255
> 
> devel/opencl and devel/ocl-icd share maintainer. I'll wait for him to chime
> in before committing.
> 
> Thanks!
> 
> 
> >
> >                 Craig
> >  



-- 
O. Hartmann

Ich widerspreche der Nutzung oder Übermittlung meiner Daten für
Werbezwecke oder für die Markt- oder Meinungsforschung (§ 28 Abs. 4 BDSG).