From nobody Wed Mar 08 04:00:56 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PWdsJ71PJz3x4Pr; Wed, 8 Mar 2023 04:01:08 +0000 (UTC) (envelope-from meta@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PWdsJ6bPVz3D3q; Wed, 8 Mar 2023 04:01:08 +0000 (UTC) (envelope-from meta@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678248068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nAq0WdA3D0KEEr2XqjgotpSCnXhAanLEI55BRGs0Wqo=; b=PsmH37fgXEJ/el/L4x6yrIS9VudCajPzY0HyJu3avpVN+0DKP9tZ81cNU80dIxqNW+vbYV m0FV4nQ9bzVuhfT1Do8HJBudKlENY+5pzf6c289myB7XDJMgK3Hia82I+7eTCmHmOhAZlg AN6YYt0YUmMh+lnZLi39ktkXcaFwwZv9AUuZUDtHyL7dsjRdU3Wjpi/YyRisyXCEFwr11L aqipTkkIoPMHvKyBeLnPFCnrTPTzGLKYp06f40zozAHfB2vhSiK78IrNKppzb9OL/jkSwN iL6XY40J5Q/k166le64Su+0O8JNOF9niJkwHEkMmERoK6WNEvOR7w6P6MU2XJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678248068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nAq0WdA3D0KEEr2XqjgotpSCnXhAanLEI55BRGs0Wqo=; b=r/Jr4O4ChvwY+/cRnNbnutK+UiyG17tlfXmEZNeC6Y540e8PGpm5IxJ96be71MJPmeHp54 7EK6ouCxknRtq8mb1o78rG9KesZHqN9wmcweVJnqNphJ0Uv1H3tiVH+bQ0Yf0847v4Ox84 EVIUVyFZ5XZ3ZGGyap1NSeZfRfblGfSne/ycvEuu8/wkEvbuRGKbNrkPQuBinC76w4QPq7 7M82DNOTH0J7U9bUfdzz11QqPoUjkOtKvGHVHGswju4XWKtCNpDt1G/2d6aIHhBayf2yt8 sKOr5qrgErewQKRB+MLvMte/5FShvXe3cYMXY1Uali6rr1nAzqLPkrDv22U16Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678248068; a=rsa-sha256; cv=none; b=dY9HnaeVeHWrLGgdo5r5PuAcUciBvn7EzOu3UqJNpjrmUF4xfmU8L7R9EE8A0g2YCzVICQ 8+kA1QbWDgdo6QYbQUMp4yOISCUcZRarbft1bmS4UWAcnnsVGbsS0DTqa/1UnokyV+IYuA zuiln7fNqyz1fWiVEM9oATlJpdN4A00TRfvB2vhQGmPBxADAZ67AWiKk97VTotv3aPqKrs x5RoTFX4JWIVEaFBfvHZhd4FF6ydu0b11KyryH+YLcfrXZxA3g1p09BF2oVfjexcwhX4vx OWm/W23Pq9GUlitYMO4VSwbsMX0dG1GcNLw4GcoD7PF0Hpf1sENkxnL6n0M2ug== Received: from icepick.vmeta.jp (unknown [IPv6:2403:bd80:c100:411:19b7:fde8:e8d5:eda0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: meta/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PWdsH0wpPzssM; Wed, 8 Mar 2023 04:01:06 +0000 (UTC) (envelope-from meta@FreeBSD.org) Date: Wed, 8 Mar 2023 13:00:56 +0900 From: Koichiro Iwao To: Alexey Dokuchaev Cc: Mathieu Arnold , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d69b20995dec - main - security/softether5: add DEBUG option Message-ID: <20230308040056.anw63o63vft52fow@icepick.vmeta.jp> X-Operating-System: FreeBSD 13.2-STABLE amd64 References: <202303060432.3264Wbtc041269@gitrepo.freebsd.org> <20230306142506.kckwmjxqgyv6usry@icepick.vmeta.jp> <20230306195254.n3gxqbchj5voyypw@aching.in.mat.cc> <20230306195501.ithqt45oxm2z2mgn@aching.in.mat.cc> <20230307001606.j7vhypsfrohkz62s@icepick.vmeta.jp> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Tue, Mar 07, 2023 at 06:33:06AM +0000, Alexey Dokuchaev wrote: > On Tue, Mar 07, 2023 at 09:16:06AM +0900, Koichiro Iwao wrote: > > On Mon, Mar 06, 2023 at 08:55:01PM +0100, Mathieu Arnold wrote: > > > > ... > > > > WITH_DEBUG is a global user facing knob, it must never be activated > > > > via options. > > > > > > Sorry, bad wording, it must never be set in any Makefile, wether > > > options, flavor, or whatever. It is not a port setting, that one sets > > > in a Makefile, it is a user setting that one sets in make.conf. > > > > Understood. Other ports which have DEBUG option mostly don't set > > WITH_DEBUG but just add something like --enable-debug to *_ARGS. This > > kind of DEBUG options are allowed, right (ex. lang/php8[012])? > > No, it's not, PHP ports do it wrong. Correct way is: > > .if defined(WITH_DEBUG) > CONFIGURE_ARGS+= --enable-debug > .endif > > ./danfe Understood, thanks for the correction. -- meta