From nobody Mon Jul 31 18:31:39 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RF6LC5pW3z4pNsv for ; Mon, 31 Jul 2023 18:32:20 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RF6Kb0v4zz3swq for ; Mon, 31 Jul 2023 18:32:19 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690828339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4yg9uiQRpiLVROPUCgtH2NpmW2gjZUMcZ7X28Oc4RJU=; b=mgkwKDiERAhPqxp4n9G+SOdFeeYJX7wLtupNZWAcWVehZX59BLCPIhCxfDb+YFjBKKgln/ R9OzIFkr8Ch4e9kUyfiShE36D+2oOai1XicrtH1U/LvOL91jzSvHEc+054QcA8c3k5Y030 bhXQBWp3PCFpCdWJl+U5y6BEuX+VciTLxM9jVJ7ZttKopxEWoKKnFikRZZ7zIJDWeOrlvi tRhy7mi0FZIJWRH2v5fjpsUHDYRitgWwZozhmGfhL9mcSJiybw0KsE1IJrs7DbeKsFRNkT /kqQwbsuo9mJ32Har4vOHopAMNwNiDrYRg/fy7Kh1LtFG+ukWaIGTUg8bOgTRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690828339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4yg9uiQRpiLVROPUCgtH2NpmW2gjZUMcZ7X28Oc4RJU=; b=FbeMD/92VspdXKcyZA5mQCHx1U+lJAbjkqezFMurhIKrG7zoedYrH2NKkhrFtyPtGhiybH d+8pUy0naDIUDP05l6nH23xDbfdmrgBhyNt6YCi/fjtyFBTOlwFrj9EYl5R7eJkKEBoON7 XfErpVXrAAzxo46gCxOWOQQDwrbU2IhKYQk39p6TsPyozM559wtnaO4YUo1Tg7+IcNnt2X rly8VM2pBQIcpoT76C+JNrnq2tFUnXvm4rDOdR1MlkLoBtnEfXofVtdRtvUodMQTzgG/Lj PJgitaK6ijg6SfAj2pVsYWLBqXNyauOLjEJhrD7isu/jW53S5aO7M5efkSTPQQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690828339; a=rsa-sha256; cv=none; b=McPB014lB/dg0extevenPxGdMAP7EzJApBRHAGqPrPy5J1Bd8ryYfEJBelp5OFvOmEug1k AbkF0Jd3GDZXG3XaL2ZsY66jjJoXNDoYqWs4Yi9i88ofAJ4CUW0L846kIBx0y5zlMh6ZAI 93Z9/jlgeeeZ9LPfRJYkWBA0IusJjTlw0g4tIqHvQ+W7t1sX9weq+7gthTIKWb7hmSylK7 bSBzZMssHjeyEu0UvP64V3Kld/QcyfsfHiNtJ6uQ6eZ213w0l3TIoo4405y2PIPf7hXhru R6LrndBSdu3PnOFOqCJoVHk4g0c++rDLdMuAph1Lu/7pcB8lRl+Uf4kIAs4QIw== Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RF6KZ22GNzNgw for ; Mon, 31 Jul 2023 18:32:18 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-99bd1d0cf2fso753509766b.3 for ; Mon, 31 Jul 2023 11:32:17 -0700 (PDT) X-Gm-Message-State: ABy/qLZHlzatcoutNclT+9qNdGrX+Iw+fb1aMU/NSj3Usym4bSZoJiMg mctJiy7EwTIs753g/qqHpukI1W3Ro9ReM3r5MKmphg== X-Google-Smtp-Source: APBJJlHzvWIyIpc6OOCCzBbjDGYmDWEWa7LYLE43C42UwzuXDItZlKl1Wcd6hduu1BEQK1QHVA50T+1xVpTIb03ugqc= X-Received: by 2002:a17:906:1010:b0:992:a836:a194 with SMTP id 16-20020a170906101000b00992a836a194mr519480ejm.59.1690828335315; Mon, 31 Jul 2023 11:32:15 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202307220748.36M7mgIt016872@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Tue, 1 Aug 2023 02:31:39 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 7bb64b89d0e5 - main - framework: add Mk/Uses/pycryptography To: "Tobias C. Berner" , Antoine Brodin Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000004d910b0601cca605" --0000000000004d910b0601cca605 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, How about USE_PYTHON=3D{cryptography_build,cryptography,cryptography_test}? USE_PYTHON=3Dcryptography is the runtime dependency because it is mostly us= ed in RUN_DEPENDS. For the current ports tree, I get the following result via "git grep pycryptography": 89 USES=3Dpycryptography:run 5 USES=3Dpycryptography:test 2 USES=3Dpycryptography:run,test 1 USES=3Dpycryptography:build,run 0 USES=3Dpycryptography Regards, sunpoet On Mon, Jul 24, 2023 at 10:54=E2=80=AFPM Tobias C. Berner wrote: > Moin moin > > It seemed an easier way to stop-gap fix this issue separately. But > you're probably right, that python.mk would be the preferred location > to do so. > > I can move it there. > > > mfg Tobias > > On Sat, 22 Jul 2023 at 14:51, Antoine Brodin wrote: > > > > On Sat, Jul 22, 2023 at 7:48=E2=80=AFAM Tobias C. Berner > wrote: > > > > > > The branch main has been updated by tcberner: > > > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D7bb64b89d0e5ec8d77b28f8341269= ffbad279ebf > > > > > > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf > > > Author: Tobias C. Berner > > > AuthorDate: 2023-07-22 06:16:46 +0000 > > > Commit: Tobias C. Berner > > > CommitDate: 2023-07-22 07:46:38 +0000 > > > > > > framework: add Mk/Uses/pycryptography > > > > > > With the added new DEFAULT_VERSION > "PYCRYPTOGRAHY_DEFAULT=3Drust|legacy" > > > it is important to transparently depend on the right one. > > > > > > This is the job of this new uses. > > > > > > So instead of manually adding dependency lines like > > > > > > > RUN_DEPENDS=3D${PYTHON_PKGNAMEPREFIX}cryptography>0:security/py-cryptogr= aphy@ > ${PY_FLAVOR} > > > > > > this should now be > > > > > > USES=3Dpycryptography:run > > > > > > Supported arguments: ,build,run,test > > > If no argument is given, it defaults to 'build,run'. > > > > > > A future commit will update to security/py-cryptography will > introduce a > > > rust dependency. > > > > > > PR: 254853 > > > > Hi, > > > > Why isn't it a USE_PYTHON=3D pycryptography? > > > > Antoine > --0000000000004d910b0601cca605 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

How about USE_PYTHON= =3D{cryptography_build,cryptography,cryptography_test}?
USE_PYTHO= N=3Dcryptography is the runtime dependency because it is mostly used in RUN= _DEPENDS.

For the current ports tree, I get the fo= llowing result via "git grep pycryptography":
89 USES= =3Dpycryptography:run
=C2=A05 USES=3Dpycryptography:test
=C2=A02 USES=3Dpycryptography:run,test
=C2=A01 USES=3Dpycryptog= raphy:build,run
=C2=A00 USES=3Dpycryptography

Regards,
sunpoet

On Mon, Jul 24, 2= 023 at 10:54=E2=80=AFPM Tobias C. Berner <tcberner@freebsd.org> wrote:
Moin moin

It seemed an easier way to stop-gap fix this issue separately. But
you're probably right, that python.mk would be the preferred location
to do so.

I can move it there.


mfg Tobias

On Sat, 22 Jul 2023 at 14:51, Antoine Brodin <antoine@freebsd.org> wrote:
>
> On Sat, Jul 22, 2023 at 7:48=E2=80=AFAM Tobias C. Berner <tcberner@freebsd.org= > wrote:
> >
> > The branch main has been updated by tcberner:
> >
> > URL: h= ttps://cgit.FreeBSD.org/ports/commit/?id=3D7bb64b89d0e5ec8d77b28f8341269ffb= ad279ebf
> >
> > commit 7bb64b89d0e5ec8d77b28f8341269ffbad279ebf
> > Author:=C2=A0 =C2=A0 =C2=A0Tobias C. Berner <tcberner@FreeBSD.= org>
> > AuthorDate: 2023-07-22 06:16:46 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Tobias C. Berner <tcberner@FreeBSD.= org>
> > CommitDate: 2023-07-22 07:46:38 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0framework: add Mk/Uses/pycryptography
> >
> >=C2=A0 =C2=A0 =C2=A0With the added new DEFAULT_VERSION "PYCRY= PTOGRAHY_DEFAULT=3Drust|legacy"
> >=C2=A0 =C2=A0 =C2=A0it is important to transparently depend on the= right one.
> >
> >=C2=A0 =C2=A0 =C2=A0This is the job of this new uses.
> >
> >=C2=A0 =C2=A0 =C2=A0So instead of manually adding dependency lines= like
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0RUN_DEPENDS=3D${PY= THON_PKGNAMEPREFIX}cryptography>0:security/py-cryptography@${PY_FLAVOR}<= br> > >
> >=C2=A0 =C2=A0 =C2=A0this should now be
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0USES=3Dpycryptogra= phy:run
> >
> >=C2=A0 =C2=A0 =C2=A0Supported arguments: <none>,build,run,te= st
> >=C2=A0 =C2=A0 =C2=A0If no argument is given, it defaults to 'b= uild,run'.
> >
> >=C2=A0 =C2=A0 =C2=A0A future commit will update to security/py-cry= ptography will introduce a
> >=C2=A0 =C2=A0 =C2=A0rust dependency.
> >
> >=C2=A0 =C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0254853
>
> Hi,
>
> Why isn't it a USE_PYTHON=3D pycryptography?
>
> Antoine
--0000000000004d910b0601cca605--