From nobody Mon Jul 31 15:37:38 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RF2Xd5Qf3z4qDHx; Mon, 31 Jul 2023 15:41:34 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RF2SH5VMcz3Br4; Mon, 31 Jul 2023 15:37:51 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-522ab301692so4247725a12.2; Mon, 31 Jul 2023 08:37:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690817870; x=1691422670; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mH/f4bhbOzn0D4l4vw9nLNHPbhp5Y+RkrdLKAh+o+Yk=; b=ZOALZGoo9jEf2TPS7lElsHAza3ClP9cWbSKBhaoCBAwcdO3NbvwvLE+tCKS91IBfyV l/FhehGX9Kt9TTV1RXJeoOseSk/LDkhHRbN2wvuwUZMhSCJHerjvz4uhm78jy9MD9XEe A0YiJWP3ix/0kj/1J+zsRhv1SuczrdfP83fYkVsmAxtDyC5JBjK1YFUjTU8AmksC7rve zf9IruvnG3YH1K6sirallykffol/mv6DWMXFGG5B8MIXWHytCY+NdfiClnDeQ4mnYaSY PcyQ0EY48sk3EVZIfkqNYg76bQxT0zGq5Kbe2zF5oryyVAbzgHSLHSZVdLWbukqJKI5A v6Wg== X-Gm-Message-State: ABy/qLa9oJKrP6qe9QvuAaCPcRh7mVU6uIk/yG4YvvkUScU3ofHYCl6O LmAlqW1xSai4DYcXwPwWrrpt8HWOaaZ9EcFdt40YJXAo X-Google-Smtp-Source: APBJJlGwNFODw00qjKWKBwwesfXhVXQ0mYB3/QY28ujC6mWVhitVLhdZdjHceN6tmUfJ2vd/b4qEO3wvvZZGxZBYpHA= X-Received: by 2002:aa7:c745:0:b0:522:36f0:f1a3 with SMTP id c5-20020aa7c745000000b0052236f0f1a3mr244329eds.10.1690817869855; Mon, 31 Jul 2023 08:37:49 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202307302015.36UKFpFO036109@gitrepo.freebsd.org> <39e34dfa-db88-0b05-6ae1-02137701dd9d@freebsd.org> <21e21bfd-e0e2-f3d8-2f7c-34333f2c94dd@freebsd.org> <5afa5396-12f2-baa7-573a-6608225c25b2@freebsd.org> <0a630993-2521-e330-02dd-606ac146b91a@freebsd.org> In-Reply-To: <0a630993-2521-e330-02dd-606ac146b91a@freebsd.org> From: "Jason E. Hale" Date: Mon, 31 Jul 2023 11:37:38 -0400 Message-ID: Subject: Re: git: 7ebddd96d372 - main - multimedia/mlt7*: Update to 7.18.0 To: Vladimir Druzenko Cc: Daniel Engberg , Charlie Li , "Jason E. Hale" , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4RF2SH5VMcz3Br4 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Sun, Jul 30, 2023 at 9:15=E2=80=AFPM Vladimir Druzenko = wrote: > > 31.07.2023 03:02, Daniel Engberg =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On 2023-07-31 01:45, Charlie Li wrote: > >> Vladimir Druzenko wrote: > >>> It's very big dependency. I can create patch for multimedia/mlt7 > >>> with choice which libebur128 to use: 1) huge external on rust or 2) > >>> small internal on C. > >>> > >> There is no rust code anywhere in audio/libebur128 or its > >> dependencies. So don't even think about it any further. > >> > >> Furthermore, MLT and its consumers are not designed or intended to be > >> used in insufficiently-resourced computing environments. > > > > We actually have two implementations available in tree, > > > > audio/ebur128 and audio/libebur128 > > > > audio/ebur128 is a Rust implementation that performs noticably better > > and we moved all consumers almost 3 months ago to that variant. > > https://cgit.freebsd.org/ports/commit/?id=3D4cd440845e24202042e8b35a1c1= db08a928b5946 > > > > > > Worth mentioning is that it's only a build dependency > > > > Best regards, > > Daniel > > > If there's a need further down the road we can add an option to choose > > between. > The need has arisen. > I think the most sensible approach would be to handle the ebur128 dependency similar to librsvg2 and pycryptography. It would be trivial to create a Mk/Uses/ebur128.mk and allow the user to set whether they wanted to use the legacy C implementation via DEFAULT_VERSIONS in /etc/make.conf. The rust version would still be the default, however. Does that sound like an agreeable solution? -Jason